XoopsModules\About\Tree

Complexity

Total Complexity

23

Size/Duplication

Total Lines	126
Duplicated Lines	0 %

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	makeSelBox()	0	17	3
B	getAllChildArray()	0	19	8
B	makeTreeItems()	0	16	8
A	__construct()	0	3	1
A	makeArrayTree()	0	9	2
A	makeTree()	0	6	1

<?php

namespace XoopsModules\About;



require_once XOOPS_ROOT_PATH . '/class/tree.php';

if (!\class_exists('About\Tree')) {
    /**
     * Class Tree
     */
    class Tree extends \XoopsObjectTree
    {
        /**
         * Tree constructor.
         * @param array $objectArr
         * @param null  $rootId

Are you sure the doc-type for parameter $rootId is correct as it would always require null to be passed?

         */
        public function __construct($objectArr, $rootId = null)
        {
            parent::__construct($objectArr, 'page_id', 'page_pid', $rootId);
        }

        /**
         * @param            $key
         * @param            $ret
         * @param            $prefix_orig
         * @param string     $prefix_curr
         * @param null|array $tags
         */
        public function makeTreeItems($key, &$ret, $prefix_orig, $prefix_curr = '', $tags = null)
        {
            if ($key > 0) {
                if ($tags && \is_array($tags)) {
                    foreach ($tags as $tag) {
                        $ret[$key][$tag] = $this->tree[$key]['obj']->getVar($tag);
                    }
                } else {
                    $ret[$key]['page_title'] = $this->tree[$key]['obj']->getVar('page_title');
                }
                $ret[$key]['prefix'] = $prefix_curr;
                $prefix_curr         .= $prefix_orig;
            }
            if (isset($this->tree[$key]['child']) && !empty($this->tree[$key]['child'])) {
                foreach ($this->tree[$key]['child'] as $childkey) {
                    $this->makeTreeItems($childkey, $ret, $prefix_orig, $prefix_curr, $tags);
                }
            }
        }

        /**
         * @param string $prefix
         * @param int    $key
         * @param null   $tags

Are you sure the doc-type for parameter $tags is correct as it would always require null to be passed?

         * @return array
         */
        public function &makeTree($prefix = '-', $key = 0, $tags = null)
        {
            $ret = [];
            $this->makeTreeItems($key, $ret, $prefix, '', $tags);

            return $ret;
        }

        /**
         * @param string $name
         * @param string $fieldName
         * @param string $prefix
         * @param string $selected
         * @param bool   $addEmptyOption
         * @param int    $key
         * @param string $extra
         * @return string
         */
        public function makeSelBox(
            $name,
            $fieldName,
            $prefix = '-',
            $selected = '',
            $addEmptyOption = false,
            $key = 0,
            $extra = ''
        ) {
            $ret = '<select name=' . $name . '>';
            if (!empty($addEmptyOption)) {
                $ret .= '<option value="0">' . (\is_string($addEmptyOption) ? $addEmptyOption : '') . '</option>';

The condition is_string($addEmptyOption) is always false.

            }
            $this->makeSelBoxOptions('page_title', $selected, $key, $ret, $prefix);

The function XoopsObjectTree::makeSelBoxOptions() has been deprecated: since 2.5.9, please use makeSelectElement() functionality

            $ret .= '</select>';

            return $ret;
        }

        /**
         * @param       $key
         * @param       $ret
         * @param array $tags
         * @param int   $depth
         */
        public function getAllChildArray($key, &$ret, $tags = [], $depth = 0)
        {
            if (0 == --$depth) {
                return;
            }

            if (isset($this->tree[$key]['child'])) {
                foreach ($this->tree[$key]['child'] as $childkey) {
                    if (isset($this->tree[$childkey]['obj'])):
                        if ($tags && \is_array($tags)) {
                            foreach ($tags as $tag) {
                                $ret['child'][$childkey][$tag] = $this->tree[$childkey]['obj']->getVar($tag);
                            }
                        } else {
                            $ret['child'][$childkey]['page_title'] = $this->tree[$childkey]['obj']->getVar('page_title');
                        }
                    endif;

                    $this->getAllChildArray($childkey, $ret['child'][$childkey], $tags, $depth);
                }
            }
        }

        /**
         * @param int  $key
         * @param null $tags

Are you sure the doc-type for parameter $tags is correct as it would always require null to be passed?

         * @param int  $depth
         * @return array
         */
        public function makeArrayTree($key = 0, $tags = null, $depth = 0)
        {
            $ret = [];
            if ($depth > 0) {
                $depth++;
            }
            $this->getAllChildArray($key, $ret, $tags, $depth);

            return $ret;
        }
    }
}