BaseCommand::loadCSR() - Code Metrics - Inspection of "Put loading CSR into its own function" - XigenChris/ComodoDecodeCSR - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — develop ( 819fb3...3b8721 )

by Chris

created 2016-08-09 11:39 UTC

BaseCommand::loadCSR() A

↳ Parent: BaseCommand

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	12
ccs	0
cts	10
cp	0
rs	9.4285
cc	2
eloc	7
nc	2
nop	2
crap	6

<?php
/**
 * @author     Chris Hilsdon <[email protected]>
 * @package    ComodoDecodeCSR
 * @copyright  2016 Xigen
 * @license    GNU General Public License v3
 * @link       https://github.com/XigenChris/ComodoDecodeCSR
 */

namespace Xigen\Console;

use Xigen\Application;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;
use Symfony\Component\Console\Command\Command;

abstract class BaseCommand extends Command
{
    /**
     * Load a .csr file via an CLI argument
     * @param  Symfony\Component\Console\Input\InputInterface $input
     * @param  Symfony\Component\Console\Output\OutputInterface $output
     * @return bool|void
     */
    public function loadCSR(InputInterface $input, OutputInterface $output)
    {
        $csrFile = $input->getArgument('csr');
        if (!file_exists($csrFile)) {
            $output->writeln('<error>Unable to load '. $csrFile .'</error>');
            $output->writeln('<error>Please check the path and try again</error>');

            exit();

        }

        return file_get_contents($csrFile);
    }
}


1			<?php
2			/**
3			* @author Chris Hilsdon <[email protected]>
4			* @package ComodoDecodeCSR
5			* @copyright 2016 Xigen
6			* @license GNU General Public License v3
7			* @link https://github.com/XigenChris/ComodoDecodeCSR
8			*/
9
10			namespace Xigen\Console;
11
12			use Xigen\Application;
13			use Symfony\Component\Console\Input\InputInterface;
14			use Symfony\Component\Console\Output\OutputInterface;
15			use Symfony\Component\Console\Command\Command;
16
17			abstract class BaseCommand extends Command
18			{
19			/**
20			* Load a .csr file via an CLI argument
21			* @param Symfony\Component\Console\Input\InputInterface $input
22			* @param Symfony\Component\Console\Output\OutputInterface $output
23			* @return bool\|void
24			*/
25			public function loadCSR(InputInterface $input, OutputInterface $output)
26			{
27			$csrFile = $input->getArgument('csr');
28			if (!file_exists($csrFile)) {
29			$output->writeln('<error>Unable to load '. $csrFile .'</error>');
30			$output->writeln('<error>Please check the path and try again</error>');
31
32			exit();
			1 ignored issue – show Coding Style Compatibility introduced 2016-08-09 11:42 UTC by Report Bug Copy Issue Report The method `loadCSR()` contains an exit expression. An exit expression should only be used in rare cases. For example, if you write a short command line script. In most cases however, using an `exit` expression makes the code untestable and often causes incompatibilities with other libraries. Thus, unless you are absolutely sure it is required here, we recommend to refactor your code to avoid its usage. Loading history...
33			}
34
35			return file_get_contents($csrFile);
36			}
37			}
38

XigenChris / ComodoDecodeCSR

Push — develop ( 819fb3...3b8721 )

BaseCommand::loadCSR() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like