Check::execute() - Code Metrics - Inspection of "Documented about the new console app" - XigenChris/ComodoDecodeCSR - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( db382d...b26fd3 )

by Chris

created 2016-08-05 12:28 UTC

Check::execute() B

↳ Parent: Check

Complexity

Conditions	3
Paths	3

Size

Total Lines	27
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	12

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	27
ccs	0
cts	21
cp	0
rs	8.8571
cc	3
eloc	17
nc	3
nop	2
crap	12

<?php
/**
 * @author     Chris Hilsdon <[email protected]>
 * @package    ComodoDecodeCSR
 * @copyright  2016 Xigen
 * @license    GNU General Public License v3
 * @link       https://github.com/XigenChris/ComodoDecodeCSR
 */

namespace Xigen\Console;

use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Output\OutputInterface;
use Xigen\ComodoDecodeCSR;

class Check extends BaseCommand
{
    protected function configure()
    {
        $this
            ->setName("check")
            ->setDescription("Check if a domain will pass the DCV")
            ->addArgument(
                'csr',
                InputArgument::REQUIRED,
                'Location of csr file for this domain'
            )
        ;
    }

    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $csrFile = $input->getArgument('csr');
        if (!file_exists($csrFile)) {
            $output->writeln('<error>Unable to load '. $csrFile .'</error>');
            $output->writeln('<error>Please check the path and try again</error>');
            return false;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }

        $csr = file_get_contents($csrFile);

        $ComodoDecodeCSR = new ComodoDecodeCSR();
        $ComodoDecodeCSR->setCSR($csr);
        $ComodoDecodeCSR->fetchHashes();

        if ($ComodoDecodeCSR->checkInstalled()) {
            $output->writeln('<info>Success!</info>');
            $output->writeln('This domain should pass DCV');

            return true;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
        }

        $output->writeln('<error>Fail!</error>');
        $output->writeln('There is something wrong with the validation file');

        return false;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }
}


1			<?php
2			/**
3			* @author Chris Hilsdon <[email protected]>
4			* @package ComodoDecodeCSR
5			* @copyright 2016 Xigen
6			* @license GNU General Public License v3
7			* @link https://github.com/XigenChris/ComodoDecodeCSR
8			*/
9
10			namespace Xigen\Console;
11
12			use Symfony\Component\Console\Input\InputInterface;
13			use Symfony\Component\Console\Input\InputArgument;
14			use Symfony\Component\Console\Output\OutputInterface;
15			use Xigen\ComodoDecodeCSR;
16
17			class Check extends BaseCommand
18			{
19			protected function configure()
20			{
21			$this
22			->setName("check")
23			->setDescription("Check if a domain will pass the DCV")
24			->addArgument(
25			'csr',
26			InputArgument::REQUIRED,
27			'Location of csr file for this domain'
28			)
29			;
30			}
31
32			protected function execute(InputInterface $input, OutputInterface $output)
33			{
34			$csrFile = $input->getArgument('csr');
35			if (!file_exists($csrFile)) {
36			$output->writeln('<error>Unable to load '. $csrFile .'</error>');
37			$output->writeln('<error>Please check the path and try again</error>');
38			return false;
			0 ignored issues – show Bug Best Practice introduced 2016-08-05 12:01 UTC by Report Bug Copy Issue Report The return type of `return false;` (`false`) is incompatible with the return type of the parent method `Symfony\Component\Console\Command\Command::execute` of type `null\|integer`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
39			}
40
41			$csr = file_get_contents($csrFile);
42
43			$ComodoDecodeCSR = new ComodoDecodeCSR();
44			$ComodoDecodeCSR->setCSR($csr);
45			$ComodoDecodeCSR->fetchHashes();
46
47			if ($ComodoDecodeCSR->checkInstalled()) {
48			$output->writeln('<info>Success!</info>');
49			$output->writeln('This domain should pass DCV');
50
51			return true;
			0 ignored issues – show Bug Best Practice introduced 2016-08-05 12:01 UTC by Report Bug Copy Issue Report The return type of `return true;` (`boolean`) is incompatible with the return type of the parent method `Symfony\Component\Console\Command\Command::execute` of type `null\|integer`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
52			}
53
54			$output->writeln('<error>Fail!</error>');
55			$output->writeln('There is something wrong with the validation file');
56
57			return false;
			0 ignored issues – show Bug Best Practice introduced 2016-08-05 12:01 UTC by Report Bug Copy Issue Report The return type of `return false;` (`false`) is incompatible with the return type of the parent method `Symfony\Component\Console\Command\Command::execute` of type `null\|integer`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
58			}
59			}
60

XigenChris / ComodoDecodeCSR

Push — master ( db382d...b26fd3 )

Check::execute() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like