Xetaravel\Models\Presenters\ArticlePresenter

Complexity

Total Complexity

5

Size/Duplication

Total Lines	47
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getArticleBannerAttribute()	0	3	1
A	getArticleUrlAttribute()	0	7	2
A	parseMedia()	0	7	2

<?php
namespace Xetaravel\Models\Presenters;

trait ArticlePresenter
{
    /**
     * The default banner used when there is no banner for the article.
     *
     * @var string
     */
    protected $defaultBanner = '/images/articles/default_banner.jpg';

    /**
     * Get the article url.
     *
     * @return string
     */
    public function getArticleUrlAttribute(): string
    {
        if (!isset($this->slug)) {
            return '';
        }

        return route('blog.article.show', ['slug' => $this->slug, 'id' => $this->getKey()]);

It seems like getKey() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * Get the small avatar.
     *
     * @return string
     */
    public function getArticleBannerAttribute(): string
    {
        return $this->parseMedia('article.banner');
    }

    /**
     * Parse a media and return it if isset or return the default banner.
     *
     * @param string $type The type of the media to get.
     *
     * @return string
     */
    protected function parseMedia(string $type): string
    {
        if (isset($this->getMedia('article')[0])) {

It seems like getMedia() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            return $this->getMedia('article')[0]->getUrl($type);
        }

        return $this->defaultBanner;
    }
}