DiscussPostPolicy::update() - Code Metrics - Inspection of "Discuss Forum" - XetaIO/Xetaravel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#34)

by Fèvre

created 2017-07-04 13:44 UTC

DiscussPostPolicy::update() A

↳ Parent: DiscussPostPolicy

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	4
Ratio	100 %

Importance

Changes

Metric	Value
dl	4
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	2

<?php
namespace Xetaravel\Policies;

use Xetaravel\Models\User;
use Xetaravel\Models\DiscussPost;
use Illuminate\Auth\Access\HandlesAuthorization;

class DiscussPostPolicy

{
    use HandlesAuthorization;

    /**
     * Authorize all actions if the user has the given permission.
     *
     * @param \Xetaravel\Models\User $user
     * @param string $ability
     *
     * @return true|void

     */
    public function before(User $user, string $ability)

    {
        if ($user->hasPermission('manage.discuss.posts')) {
            return true;
        }
    }

    /**
     * Determine whether the user can update the discuss post.
     *
     * @param \Xetaravel\Models\User $user
     * @param \Xetaravel\Models\DiscussPost $discussPost
     *
     * @return bool
     */
    public function update(User $user, DiscussPost $discussPost)
    {
        return $user->id === $discussPost->user_id;
    }

    /**
     * Determine whether the user can delete the discuss post.
     *
     * @param \Xetaravel\Models\User $user
     * @param \Xetaravel\Models\DiscussPost $discussPost
     *
     * @return bool
     */
    public function delete(User $user, DiscussPost $discussPost)
    {
        return $user->id === $discussPost->user_id;
    }
}


1		<?php
2		namespace Xetaravel\Policies;
3
4		use Xetaravel\Models\User;
5		use Xetaravel\Models\DiscussPost;
6		use Illuminate\Auth\Access\HandlesAuthorization;
7
8	View Code Duplication	class DiscussPostPolicy
		0 ignored issues – show Duplication introduced 2017-06-12 09:40 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
9		{
10		use HandlesAuthorization;
11
12		/**
13		* Authorize all actions if the user has the given permission.
14		*
15		* @param \Xetaravel\Models\User $user
16		* @param string $ability
17		*
18		* @return true\|void
		0 ignored issues – show Documentation introduced 2017-06-12 09:40 UTC by Report Bug Copy Issue Report Should the return type not be `boolean\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
19		*/
20		public function before(User $user, string $ability)
		0 ignored issues – show Unused Code introduced 2017-06-12 09:40 UTC by Report Bug Copy Issue Report The parameter `$ability` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
21		{
22		if ($user->hasPermission('manage.discuss.posts')) {
23		return true;
24		}
25		}
26
27		/**
28		* Determine whether the user can update the discuss post.
29		*
30		* @param \Xetaravel\Models\User $user
31		* @param \Xetaravel\Models\DiscussPost $discussPost
32		*
33		* @return bool
34		*/
35		public function update(User $user, DiscussPost $discussPost)
36		{
37		return $user->id === $discussPost->user_id;
38		}
39
40		/**
41		* Determine whether the user can delete the discuss post.
42		*
43		* @param \Xetaravel\Models\User $user
44		* @param \Xetaravel\Models\DiscussPost $discussPost
45		*
46		* @return bool
47		*/
48		public function delete(User $user, DiscussPost $discussPost)
49		{
50		return $user->id === $discussPost->user_id;
51		}
52		}
53

XetaIO / Xetaravel

Pull Request — master (#34)

DiscussPostPolicy::update() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like