Xetaravel\Policies\DiscussConversationPolicy

Complexity

Total Complexity

4

Size/Duplication

Total Lines	45
Duplicated Lines	100 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	before()	6	6	2
A	update()	4	4	1
A	delete()	4	4	1

<?php
namespace Xetaravel\Policies;

use Xetaravel\Models\User;
use Xetaravel\Models\DiscussConversation;
use Illuminate\Auth\Access\HandlesAuthorization;

class DiscussConversationPolicy

This class seems to be duplicated in your project.

{
    use HandlesAuthorization;

    /**
     * Authorize all actions if the user has the given permission.
     *
     * @param \Xetaravel\Models\User $user
     * @param string $ability
     *
     * @return true|void

Should the return type not be boolean|null?

     */
    public function before(User $user, string $ability)

The parameter $ability is not used and could be removed.

    {
        if ($user->hasPermission('manage.discuss.conversations')) {
            return true;
        }
    }

    /**
     * Determine whether the user can update the discuss conversation.
     *
     * @param \Xetaravel\Models\User $user
     * @param \Xetaravel\Models\DiscussConversation $discussConversation
     *
     * @return bool
     */
    public function update(User $user, DiscussConversation $discussConversation)
    {
        return $user->id === $discussConversation->user_id;
    }

    /**
     * Determine whether the user can delete the discuss conversation.
     *
     * @param \Xetaravel\Models\User $user
     * @param \Xetaravel\Models\DiscussConversation $discussConversation
     *
     * @return bool
     */
    public function delete(User $user, DiscussConversation $discussConversation)
    {
        return $user->id === $discussConversation->user_id;
    }
}