Xetaravel\Http\Controllers\UserController

Complexity

Total Complexity

15

Size/Duplication

Total Lines	169
Duplicated Lines	5.92 %

Coupling/Cohesion

Components	1
Dependencies	9

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	11	2
A	index()	0	4	1
A	show()	0	23	2
A	showSettingsForm()	0	8	1
A	update()	0	20	3
A	delete()	5	21	3
A	updateEmail()	0	9	1
A	updatePassword()	5	17	2

<?php
namespace Xetaravel\Http\Controllers;

use Illuminate\Http\RedirectResponse;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Facades\Hash;
use Illuminate\Support\Facades\Route;
use Illuminate\View\View;
use Xetaravel\Models\Repositories\UserRepository;
use Xetaravel\Models\User;
use Xetaravel\Models\Validators\UserValidator;

class UserController extends Controller
{
    /**
     * Constructor
     */
    public function __construct()
    {
        parent::__construct();

        $route = Route::getCurrentRoute()->getActionName();
        list($controller, $action) = explode('@', $route);

The assignment to $controller is unused. Consider omitting it like so list($first,,$third).

        if (in_array($action, ['index', 'show'])) {
            $this->breadcrumbs->addCrumb('Users', route('users.user.index'));

The property breadcrumbs does not exist. Did you maybe forget to declare it?

        }
    }

    /**
     * Show all the users.
     *
     * @return \Illuminate\View\View
     */
    public function index(): View
    {
        return view('user.index');
    }

    /**
     * Show the user profile page.
     *
     * @return \Illuminate\Http\RedirectResponse|\Illuminate\View\View

Should the return type not be RedirectResponse|View|\Illuminate\Contracts\View\Factory?

     */
    public function show(Request $request, $slug, $id)

The parameter $request is not used and could be removed.

The parameter $slug is not used and could be removed.

    {
        $user = User::with('articles', 'comments')

The method where does only exist in Illuminate\Database\Eloquent\Builder, but not in Illuminate\Database\Eloquent\Model.

            ->where('id', $id)
            ->first();

        if (is_null($user)) {
            return redirect()
                ->route('page.index')
                ->with('danger', 'This user doesn\'t exist or has been deleted !');
        }

        $this->breadcrumbs->addCrumb(
            e($user->username),
            route(
                'users.user.show',
                ['slug' => $user->slug, 'id' => $user->id]
            )
        );
        $this->breadcrumbs->setCssClasses('breadcrumb');

        return view('user.show', ['user' => $user, 'breadcrumbs' => $this->breadcrumbs]);
    }

    /**
     * Show the settings form.
     *
     * @return \Illuminate\View\View
     */
    public function showSettingsForm(): View
    {
        $this->breadcrumbs
            ->addCrumb('Settings', route('users.user.settings'))
            ->setCssClasses('breadcrumb');

        return view('user.settings', ['breadcrumbs' => $this->breadcrumbs]);
    }

    /**
     * Handle an update request for the user.
     *
     * @param \Illuminate\Http\Request $request
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function update(Request $request): RedirectResponse
    {
        $type = $request->input('type');

        switch ($type) {
            case 'email':
                return $this->updateEmail($request);
                break;

break is not strictly necessary here and could be removed.

            case 'password':
                return $this->updatePassword($request);
                break;

break is not strictly necessary here and could be removed.

            default:
                return back()
                    ->withInput()
                    ->with('danger', 'Invalid type.');
                break;

break is not strictly necessary here and could be removed.

        }
    }

    /**
     * Handle the delete request for the user.
     *
     * @param \Illuminate\Http\Request $request
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function delete(Request $request): RedirectResponse
    {
        $user = Auth::user();

        if (!Hash::check($request->input('password'), $user->password)) {

Accessing password on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

This code seems to be duplicated across your project.

            return redirect()
                ->route('users.user.settings')
                ->with('danger', 'Your Password does not match !');
        }
        Auth::logout();

        if ($user->delete()) {
            return redirect()
                ->route('page.index')
                ->with('success', 'Your Account has been deleted successfully !');
        }

        return redirect()
            ->route('page.index')
            ->with('danger', 'An error occurred while deleting your account !');
    }

    /**
     * Handle a E-mail update request for the user.
     *
     * @param \Illuminate\Http\Request $request
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    protected function updateEmail(Request $request): RedirectResponse
    {
        UserValidator::updateEmail($request->all())->validate();
        UserRepository::updateEmail($request->all(), Auth::user());

\Illuminate\Support\Facades\Auth::user() is of type object<Illuminate\Contracts\Auth\Authenticatable>|null, but the function expects a object<Xetaravel\Models\User>.

        return redirect()
            ->route('users.user.settings')
            ->with('success', 'Your E-mail has been updated successfully !');
    }

    /**
     * Handle a Password update request for the user.
     *
     * @param \Illuminate\Http\Request $request
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    protected function updatePassword(Request $request): RedirectResponse
    {
        $user = Auth::user();

        if (!Hash::check($request->input('oldpassword'), $user->password)) {

Accessing password on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

This code seems to be duplicated across your project.

            return redirect()
                ->route('users.user.settings')
                ->with('danger', 'Your current Password does not match !');
        }

        UserValidator::updatePassword($request->all())->validate();
        UserRepository::updatePassword($request->all(), $user);

$user of type object<Illuminate\Contracts\Auth\Authenticatable> is not a sub-type of object<Xetaravel\Models\User>. It seems like you assume a concrete implementation of the interface Illuminate\Contracts\Auth\Authenticatable to be always present.

        return redirect()
            ->route('users.user.settings')
            ->with('success', 'Your Password has been updated successfully !');
    }
}