Xetaravel\Http\Controllers\UserController

Complexity

Total Complexity

4

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	6	1
A	index()	0	4	1
A	show()	0	23	2

<?php
namespace Xetaravel\Http\Controllers;

use Xetaravel\Models\User;
use Illuminate\Http\Request;
use Illuminate\View\View;

class UserController extends Controller
{
    public function __construct()
    {
        parent::__construct();

        $this->breadcrumbs->addCrumb('Users', route('users_user_index'));

The property breadcrumbs does not exist. Did you maybe forget to declare it?

    }

    /**
     * Show the account update form.
     *
     * @return \Illuminate\View\View
     */
    public function index(): View
    {
        return view('user.index');
    }

    /**
     * Show the user profile page.
     *
     * @return \Illuminate\Http\RedirectResponse|\Illuminate\View\View

Should the return type not be \Illuminate\Http\RedirectResponse|View|\Illuminate\Contracts\View\Factory?

     */
    public function show(Request $request, $slug, $id)

The parameter $request is not used and could be removed.

The parameter $slug is not used and could be removed.

    {
        $user = User::with('articles', 'comments')

The method where does only exist in Illuminate\Database\Eloquent\Builder, but not in Illuminate\Database\Eloquent\Model.

            ->where('id', $id)
            ->first();

        if (is_null($user)) {
            return redirect()
                ->route('page_index')
                ->with('danger', 'This user doesn\'t exist or has been deleted !');
        }

        $this->breadcrumbs->addCrumb(
            e($user->username),
            route(
                'users_user_show',
                ['slug' => $user->slug, 'id' => $user->id]
            )
        );
        $this->breadcrumbs->setCssClasses('breadcrumb');

        return view('user.show', ['user' => $user, 'breadcrumbs' => $this->breadcrumbs]);
    }
}