Xetaravel\Exceptions\Handler

Complexity

Total Complexity

13

Size/Duplication

Total Lines	95
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	8

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	report()	0	4	1
B	render()	0	18	6
A	unauthenticated()	0	8	2
A	convertExceptionToResponse()	0	15	4

<?php

namespace Xetaravel\Exceptions;

use Exception;
use Illuminate\Auth\AuthenticationException;
use Illuminate\Foundation\Exceptions\Handler as ExceptionHandler;
use Illuminate\Support\Facades\Auth;

class Handler extends ExceptionHandler
{
    /**
     * A list of the exception types that should not be reported.
     *
     * @var array
     */
    protected $dontReport = [
        \Illuminate\Auth\AuthenticationException::class,
        \Illuminate\Auth\Access\AuthorizationException::class,
        \Symfony\Component\HttpKernel\Exception\HttpException::class,
        \Illuminate\Database\Eloquent\ModelNotFoundException::class,
        \Illuminate\Session\TokenMismatchException::class,
        \Illuminate\Validation\ValidationException::class,
    ];

    /**
     * Report or log an exception.
     *
     * This is a great spot to send exceptions to Sentry, Bugsnag, etc.
     *
     * @param  \Exception  $exception
     * @return void
     */
    public function report(Exception $exception)
    {
        parent::report($exception);
    }

    /**
     * Render an exception into an HTTP response.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  \Exception  $exception
     * @return \Illuminate\Http\Response
     */
    public function render($request, Exception $exception)
    {
        if ($exception instanceof \Ultraware\Roles\Exceptions\RoleDeniedException ||
            $exception instanceof \Ultraware\Roles\Exceptions\PermissionDeniedException ||
            $exception instanceof \Ultraware\Roles\Exceptions\LevelDeniedException) {
            //If the user is banished, redirect him to the banished page.
            if (Auth::check() && Auth::user()->hasRole('banished')) {

It seems like you code against a concrete implementation and not the interface Illuminate\Contracts\Auth\Authenticatable as the method hasRole() does only exist in the following implementations of said interface: Xetaravel\Models\User.

                return redirect()
                    ->route('page_banished');
            }

            return redirect()
                ->route('page_index')
                ->with('danger', 'You don\'t have the permission to view this page.');
        }

        return parent::render($request, $exception);
    }

    /**
     * Convert an authentication exception into an unauthenticated response.
     *
     * @param \Illuminate\Http\Request $request
     * @param \Illuminate\Auth\AuthenticationException $exception
     *
     * @return \Illuminate\Http\Response

Should the return type not be \Illuminate\Http\JsonResponse|\Illuminate\Http\RedirectResponse?

     */
    protected function unauthenticated($request, AuthenticationException $exception)

The parameter $exception is not used and could be removed.

    {
        if ($request->expectsJson()) {
            return response()->json(['error' => 'Unauthenticated.'], 401);
        }

        return redirect()->guest(route('users_auth_login'));
    }

    /**
     * Create a Symfony response for the given exception.
     *
     * @param \Exception $e The exception to convert.
     *
     * @return mixed
     */
    protected function convertExceptionToResponse(Exception $e)
    {
        if (config('app.debug')) {
            $whoops = new \Whoops\Run;
            $whoops->pushHandler(new \Whoops\Handler\PrettyPageHandler);

new \Whoops\Handler\PrettyPageHandler() is of type object<Whoops\Handler\PrettyPageHandler>, but the function expects a callable.

            return response()->make(
                $whoops->handleException($e),

It seems like $whoops->handleException($e) targeting Whoops\Run::handleException() can also be of type false; however, Illuminate\Contracts\Routing\ResponseFactory::make() does only seem to accept string, did you maybe forget to handle an error condition?

                method_exists($e, 'getStatusCode') ? $e->getStatusCode() : 500,

It seems like you code against a specific sub-type and not the parent class Exception as the method getStatusCode() does only exist in the following sub-classes of Exception: Illuminate\Foundation\Http\Exceptions\MaintenanceModeException, Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException, Symfony\Component\HttpKernel\Exception\BadRequestHttpException, Symfony\Component\HttpKernel\Exception\ConflictHttpException, Symfony\Component\HttpKernel\Exception\GoneHttpException, Symfony\Component\HttpKernel\Exception\HttpException, Symfony\Component\HttpKernel\Exception\LengthRequiredHttpException, Symfony\Component\HttpKernel\Exception\MethodNotAllowedHttpException, Symfony\Component\HttpKernel\Exception\NotAcceptableHttpException, Symfony\Component\HttpKernel\Exception\NotFoundHttpException, Symfony\Component\HttpKernel\Exception\PreconditionFailedHttpException, Symfony\Component\HttpKernel\Exception\PreconditionRequiredHttpException, Symfony\Component\HttpKernel\Exception\ServiceUnavailableHttpException, Symfony\Component\HttpKernel\Exception\TooManyRequestsHttpException, Symfony\Component\HttpKernel\Exception\UnauthorizedHttpException, Symfony\Component\HttpKernel\Exception\UnprocessableEntityHttpException, Symfony\Component\HttpKernel\Exception\UnsupportedMediaTypeHttpException. Maybe you want to instanceof check for one of these explicitly?

                method_exists($e, 'getHeaders') ? $e->getHeaders() : []

It seems like you code against a specific sub-type and not the parent class Exception as the method getHeaders() does only exist in the following sub-classes of Exception: Illuminate\Foundation\Http\Exceptions\MaintenanceModeException, Symfony\Component\HttpKernel\Exception\AccessDeniedHttpException, Symfony\Component\HttpKernel\Exception\BadRequestHttpException, Symfony\Component\HttpKernel\Exception\ConflictHttpException, Symfony\Component\HttpKernel\Exception\GoneHttpException, Symfony\Component\HttpKernel\Exception\HttpException, Symfony\Component\HttpKernel\Exception\LengthRequiredHttpException, Symfony\Component\HttpKernel\Exception\MethodNotAllowedHttpException, Symfony\Component\HttpKernel\Exception\NotAcceptableHttpException, Symfony\Component\HttpKernel\Exception\NotFoundHttpException, Symfony\Component\HttpKernel\Exception\PreconditionFailedHttpException, Symfony\Component\HttpKernel\Exception\PreconditionRequiredHttpException, Symfony\Component\HttpKernel\Exception\ServiceUnavailableHttpException, Symfony\Component\HttpKernel\Exception\TooManyRequestsHttpException, Symfony\Component\HttpKernel\Exception\UnauthorizedHttpException, Symfony\Component\HttpKernel\Exception\UnprocessableEntityHttpException, Symfony\Component\HttpKernel\Exception\UnsupportedMediaTypeHttpException. Maybe you want to instanceof check for one of these explicitly?

            );
        }

        return parent::convertExceptionToResponse($e);
    }
}