Xetaravel\Http\Controllers\NotificationController

Complexity

Total Complexity

4

Size/Duplication

Total Lines	48
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	4	1
A	markAsRead()	0	15	2
A	markAllAsRead()	0	9	1

<?php
namespace Xetaravel\Http\Controllers;

use Illuminate\Http\JsonResponse;
use Illuminate\Support\Facades\Auth;
use Xetaravel\Models\User;

class NotificationController extends Controller
{
    /**
     * Undocumented function
     *
     * @return void
     */
    public function index()
    {
        //
    }

    /**
     * Mark a notification as read.
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function markAsRead(): JsonResponse
    {
        $user = Auth::user();
        $notification = $user->notifications()
            ->where('id', $request->input('id'))

The variable $request does not exist. Did you forget to declare it?

            ->first();
        
        if ($notification) {
            $notification->markAsRead();
        }
        
        return response()->json([
            'error' => false
        ]);
    }

    /**
     * Mark all notifications as read.
     *
     * @return \Illuminate\Http\JsonResponse
     */
    public function markAllAsRead(): JsonResponse
    {
        $user = Auth::user();
        $user->unreadNotifications->markAsRead();

Accessing unreadNotifications on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        
        return response()->json([
            'error' => false
        ]);
    }
}