Completed
Pull Request — master (#34)
by Fèvre
04:45 queued 02:16
created

CategoryController   A

Complexity

Total Complexity 1

Size/Duplication

Total Lines 16
Duplicated Lines 50 %

Coupling/Cohesion

Components 1
Dependencies 2

Importance

Changes 0
Metric Value
wmc 1
lcom 1
cbo 2
dl 8
loc 16
rs 10
c 0
b 0
f 0

1 Method

Rating   Name   Duplication   Size   Complexity  
A index() 8 8 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
namespace Xetaravel\Http\Controllers\Discuss;
3
4
use Illuminate\View\View;
5
use Xetaravel\Models\DiscussCategory;
6
7
class CategoryController extends Controller
8
{
9
    /**
10
     * View all categories.
11
     *
12
     * @return \Illuminate\View\View
13
     */
14 View Code Duplication
    public function index(): View
0 ignored issues
show
Duplication introduced by
This method seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
15
    {
16
        $categories = DiscussCategory::orderBy('title', 'asc')->get();
17
18
        $breadcrumbs = $this->breadcrumbs->addCrumb('All Categories', route('discuss.category.index'));
19
20
        return view('Discuss::category.index', compact('categories', 'breadcrumbs'));
21
    }
22
}
23