ResetPasswordController::sendResetResponse() - Code Metrics - Inspection of "Added the Reset Password system" - XetaIO/Xetaravel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#17)

by Fèvre

created 2017-05-12 01:25 UTC

ResetPasswordController::sendResetResponse() A

↳ Parent: ResetPasswordController

Complexity

Conditions	1
Paths	1

Size

Total Lines	5
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	5
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	3
nc	1
nop	1

<?php
namespace Xetaravel\Http\Controllers\Auth;

use Illuminate\Foundation\Auth\ResetsPasswords;
use Illuminate\Http\Request;
use Xetaravel\Http\Controllers\Controller;

class ResetPasswordController extends Controller
{
    /*
    |--------------------------------------------------------------------------
    | Password Reset Controller
    |--------------------------------------------------------------------------
    |
    | This controller is responsible for handling password reset requests
    | and uses a simple trait to include this behavior. You're free to
    | explore this trait and override any methods you wish to tweak.
    |
    */
    use ResetsPasswords;

    /**
     * Where to redirect users after resetting their password.
     *
     * @var string
     */
    protected $redirectTo = '/';

    /**
     * Create a new controller instance.
     *
     * @return void

     */
    public function __construct()
    {
        $this->middleware('guest');
    }

    /**
     * Display the password reset view for the given token.
     *
     * If no token is present, display the link request form.
     *
     * @param  \Illuminate\Http\Request  $request
     * @param  string|null  $token
     * @return \Illuminate\Contracts\View\Factory|\Illuminate\View\View
     */
    public function showResetForm(Request $request, $token = null)
    {
        return view('Auth.passwords.reset')->with(
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ['token' => $token, 'email' => $request->email]
        );
    }

    /**
     * Get the response for a successful password reset.
     *
     * @param  string  $response
     * @return \Illuminate\Http\RedirectResponse
     */
    protected function sendResetResponse($response)
    {
        return redirect($this->redirectPath())
            ->with('success', trans($response));
    }
}


1			<?php
2			namespace Xetaravel\Http\Controllers\Auth;
3
4			use Illuminate\Foundation\Auth\ResetsPasswords;
5			use Illuminate\Http\Request;
6			use Xetaravel\Http\Controllers\Controller;
7
8			class ResetPasswordController extends Controller
9			{
10			/*
11			\|--------------------------------------------------------------------------
12			\| Password Reset Controller
13			\|--------------------------------------------------------------------------
14			\|
15			\| This controller is responsible for handling password reset requests
16			\| and uses a simple trait to include this behavior. You're free to
17			\| explore this trait and override any methods you wish to tweak.
18			\|
19			*/
20			use ResetsPasswords;
21
22			/**
23			* Where to redirect users after resetting their password.
24			*
25			* @var string
26			*/
27			protected $redirectTo = '/';
28
29			/**
30			* Create a new controller instance.
31			*
32			* @return void
			0 ignored issues – show Comprehensibility Best Practice introduced 2017-05-03 18:29 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
33			*/
34			public function __construct()
35			{
36			$this->middleware('guest');
37			}
38
39			/**
40			* Display the password reset view for the given token.
41			*
42			* If no token is present, display the link request form.
43			*
44			* @param \Illuminate\Http\Request $request
45			* @param string\|null $token
46			* @return \Illuminate\Contracts\View\Factory\|\Illuminate\View\View
47			*/
48			public function showResetForm(Request $request, $token = null)
49			{
50			return view('Auth.passwords.reset')->with(
			0 ignored issues – show Bug introduced 2017-05-12 01:27 UTC by Report Bug Copy Issue Report The method `with` does only exist in `Illuminate\View\View`, but not in `Illuminate\Contracts\View\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
51			['token' => $token, 'email' => $request->email]
52			);
53			}
54
55			/**
56			* Get the response for a successful password reset.
57			*
58			* @param string $response
59			* @return \Illuminate\Http\RedirectResponse
60			*/
61			protected function sendResetResponse($response)
62			{
63			return redirect($this->redirectPath())
64			->with('success', trans($response));
65			}
66			}
67

XetaIO / Xetaravel

Pull Request — master (#17)

ResetPasswordController::sendResetResponse() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like