RoleController::update() - Code Metrics - Inspection of "Add Roles Management" - XetaIO/Xetaravel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#21)

by Fèvre

created 2017-05-22 16:02 UTC

RoleController::update() A

↳ Parent: RoleController

Complexity

Conditions	1
Paths	1

Size

Total Lines	13
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	13
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	8
nc	1
nop	2

<?php
namespace Xetaravel\Http\Controllers\Admin\Role;

use Illuminate\Http\RedirectResponse;
use Illuminate\Http\Request;
use Illuminate\View\View;
use Ultraware\Roles\Models\Permission;
use Xetaravel\Http\Controllers\Admin\Controller;
use Xetaravel\Models\Repositories\RoleRepository;
use Xetaravel\Models\Role;
use Xetaravel\Models\Validators\RoleValidator;

class RoleController extends Controller
{
    /**
     * Show the search page.
     *
     * @return \Illuminate\View\View
     */
    public function index(): View

    {
        $roles = Role::paginate(10);

        $breadcrumbs = $this->breadcrumbs->addCrumb('Manage Roles', route('admin.role.role.index'));
class MyClass { }

$x = new MyClass();
$x->foo = true;

        return view('Admin::Role.role.index', compact('roles', 'breadcrumbs'));
    }

    /**
     * Show the role create form.
     *
     * @return \Illuminate\View\View
     */
    public function showCreateForm(): View

    {
        $permissions = Permission::pluck('name', 'id');

        $optionsAttributes = $this->getOptionAttributes();

        $breadcrumbs = $this->breadcrumbs
            ->addCrumb('Manage Roles', route('admin.role.role.index'))
            ->addCrumb("Create", route('admin.role.role.create'));

        return view('Admin::Role.role.create', compact('permissions', 'breadcrumbs', 'optionsAttributes'));
    }

    /**
     * Handle a role create request for the application.
     *
     * @param \Illuminate\Http\Request $request
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function create(Request $request): RedirectResponse
    {
        RoleValidator::create($request->all())->validate();

        $role = RoleRepository::create($request->all());
        $role->syncPermissions($request->get('permissions'));

        return redirect()
            ->route('admin.role.role.index')
            ->with('success', 'This role has been created successfully !');
    }

    /**
     * Show the update form.
     *
     * @param \Illuminate\Http\Request $request
     * @param string $slug The slug of the role.
     * @param int $id The id of the role.
     *
     * @return \Illuminate\Http\RedirectResponse|\Illuminate\View\View

     */
    public function showUpdateForm(Request $request, string $slug, int $id)

    {
        $role = Role::findOrFail($id);

        $permissions = Permission::pluck('name', 'id');
        $permission = Permission::where('slug', 'access.administration')->first();

        $optionsAttributes = $this->getOptionAttributes();

        $breadcrumbs = $this->breadcrumbs
            ->setCssClasses('breadcrumb breadcrumb-inverse bg-inverse mb-0')
            ->addCrumb('Manage Roles', route('admin.role.role.index'))
            ->addCrumb(
                'Update ' . e($role->name),
                route('admin.role.role.update', $role->slug, $role->id)
            );

        return view(
            'Admin::Role.role.update',
            compact('role', 'permissions', 'breadcrumbs', 'optionsAttributes', 'permission')
        );
    }

    /**
     * Handle an user update request for the application.
     *
     * @param \Illuminate\Http\Request $request
     * @param int $id The id of the role to update.
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function update(Request $request, int $id): RedirectResponse
    {
        $role = Role::findOrFail($id);

        RoleValidator::update($request->all(), $role->id)->validate();
        RoleRepository::update($request->all(), $role);

        $role->syncPermissions($request->get('permissions'));

        return redirect()
            ->back()
            ->with('success', 'This role has been updated successfully !');
    }

    /**
     * Handle the delete request for the role.
     *
     * @param int $id The id of the role to delete.
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function delete(int $id): RedirectResponse
    {
        $role = Role::findOrFail($id);

        if (!$role->is_deletable) {
            return redirect()
                ->route('admin.role.role.index')
                ->with('danger', 'You can not delete this role !');
        }

        // Sync the `user` role on all users for this group.
        foreach ($role->users as $user) {
            // Only do that if the user does not have another role.
            if ($user->roles->count() == 1) {
                $user->roles()->sync(Role::find(3), false);
            }
        }

        if ($role->delete()) {
            return redirect()
                ->route('admin.role.role.index')
                ->with('success', 'This role has been deleted successfully !');
        }

        return redirect()
            ->route('admin.role.role.index')
            ->with('danger', 'An error occurred while deleting this role !');
    }

    /**
     * Return a list of attributes for the permissions option field.
     *
     * @return array
     */
    protected function getOptionAttributes(): array
    {
        $attributes = Permission::pluck('id')->toArray();
        $optionsAttributes = [];

        foreach ($attributes as $attribute) {
            $optionsAttributes[$attribute] = [
                'title' => 'Role Information',
                'data-content' => Permission::where('id', $attribute)->select('description')->first()->description,
                'data-toggle' => 'popover',
                'data-trigger' => 'hover',
                'data-placement' => 'top'
            ];
        }

        return $optionsAttributes;
    }
}


1		<?php
2		namespace Xetaravel\Http\Controllers\Admin\Role;
3
4		use Illuminate\Http\RedirectResponse;
5		use Illuminate\Http\Request;
6		use Illuminate\View\View;
7		use Ultraware\Roles\Models\Permission;
8		use Xetaravel\Http\Controllers\Admin\Controller;
9		use Xetaravel\Models\Repositories\RoleRepository;
10		use Xetaravel\Models\Role;
11		use Xetaravel\Models\Validators\RoleValidator;
12
13		class RoleController extends Controller
14		{
15		/**
16		* Show the search page.
17		*
18		* @return \Illuminate\View\View
19		*/
20	View Code Duplication	public function index(): View
		0 ignored issues – show Duplication introduced 2017-05-21 23:03 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
21		{
22		$roles = Role::paginate(10);
23
24		$breadcrumbs = $this->breadcrumbs->addCrumb('Manage Roles', route('admin.role.role.index'));
		0 ignored issues – show Bug introduced 2017-05-17 17:24 UTC by Report Bug Copy Issue Report The property `breadcrumbs` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
25
26		return view('Admin::Role.role.index', compact('roles', 'breadcrumbs'));
27		}
28
29		/**
30		* Show the role create form.
31		*
32		* @return \Illuminate\View\View
33		*/
34	View Code Duplication	public function showCreateForm(): View
		0 ignored issues – show Duplication introduced 2017-05-22 16:06 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
35		{
36		$permissions = Permission::pluck('name', 'id');
37
38		$optionsAttributes = $this->getOptionAttributes();
39
40		$breadcrumbs = $this->breadcrumbs
41		->addCrumb('Manage Roles', route('admin.role.role.index'))
42		->addCrumb("Create", route('admin.role.role.create'));
43
44		return view('Admin::Role.role.create', compact('permissions', 'breadcrumbs', 'optionsAttributes'));
45		}
46
47		/**
48		* Handle a role create request for the application.
49		*
50		* @param \Illuminate\Http\Request $request
51		*
52		* @return \Illuminate\Http\RedirectResponse
53		*/
54		public function create(Request $request): RedirectResponse
55		{
56		RoleValidator::create($request->all())->validate();
57
58		$role = RoleRepository::create($request->all());
59		$role->syncPermissions($request->get('permissions'));
60
61		return redirect()
62		->route('admin.role.role.index')
63		->with('success', 'This role has been created successfully !');
64		}
65
66		/**
67		* Show the update form.
68		*
69		* @param \Illuminate\Http\Request $request
70		* @param string $slug The slug of the role.
71		* @param int $id The id of the role.
72		*
73		* @return \Illuminate\Http\RedirectResponse\|\Illuminate\View\View
		0 ignored issues – show Documentation introduced 2017-05-20 15:15 UTC by Report Bug Copy Issue Report Should the return type not be `View\|\Illuminate\Contracts\View\Factory`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
74		*/
75		public function showUpdateForm(Request $request, string $slug, int $id)
		0 ignored issues – show Unused Code introduced 2017-05-18 21:30 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-05-18 21:30 UTC by Report Bug Copy Issue Report The parameter `$slug` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
76		{
77		$role = Role::findOrFail($id);
78
79		$permissions = Permission::pluck('name', 'id');
80		$permission = Permission::where('slug', 'access.administration')->first();
81
82		$optionsAttributes = $this->getOptionAttributes();
83
84		$breadcrumbs = $this->breadcrumbs
85		->setCssClasses('breadcrumb breadcrumb-inverse bg-inverse mb-0')
86		->addCrumb('Manage Roles', route('admin.role.role.index'))
87		->addCrumb(
88		'Update ' . e($role->name),
89		route('admin.role.role.update', $role->slug, $role->id)
90		);
91
92		return view(
93		'Admin::Role.role.update',
94		compact('role', 'permissions', 'breadcrumbs', 'optionsAttributes', 'permission')
95		);
96		}
97
98		/**
99		* Handle an user update request for the application.
100		*
101		* @param \Illuminate\Http\Request $request
102		* @param int $id The id of the role to update.
103		*
104		* @return \Illuminate\Http\RedirectResponse
105		*/
106		public function update(Request $request, int $id): RedirectResponse
107		{
108		$role = Role::findOrFail($id);
109
110		RoleValidator::update($request->all(), $role->id)->validate();
111		RoleRepository::update($request->all(), $role);
112
113		$role->syncPermissions($request->get('permissions'));
114
115		return redirect()
116		->back()
117		->with('success', 'This role has been updated successfully !');
118		}
119
120		/**
121		* Handle the delete request for the role.
122		*
123		* @param int $id The id of the role to delete.
124		*
125		* @return \Illuminate\Http\RedirectResponse
126		*/
127		public function delete(int $id): RedirectResponse
128		{
129		$role = Role::findOrFail($id);
130
131		if (!$role->is_deletable) {
132		return redirect()
133		->route('admin.role.role.index')
134		->with('danger', 'You can not delete this role !');
135		}
136
137		// Sync the `user` role on all users for this group.
138		foreach ($role->users as $user) {
139		// Only do that if the user does not have another role.
140		if ($user->roles->count() == 1) {
141		$user->roles()->sync(Role::find(3), false);
142		}
143		}
144
145		if ($role->delete()) {
146		return redirect()
147		->route('admin.role.role.index')
148		->with('success', 'This role has been deleted successfully !');
149		}
150
151		return redirect()
152		->route('admin.role.role.index')
153		->with('danger', 'An error occurred while deleting this role !');
154		}
155
156		/**
157		* Return a list of attributes for the permissions option field.
158		*
159		* @return array
160		*/
161		protected function getOptionAttributes(): array
162		{
163		$attributes = Permission::pluck('id')->toArray();
164		$optionsAttributes = [];
165
166		foreach ($attributes as $attribute) {
167		$optionsAttributes[$attribute] = [
168		'title' => 'Role Information',
169		'data-content' => Permission::where('id', $attribute)->select('description')->first()->description,
170		'data-toggle' => 'popover',
171		'data-trigger' => 'hover',
172		'data-placement' => 'top'
173		];
174		}
175
176		return $optionsAttributes;
177		}
178		}
179

XetaIO / Xetaravel

Pull Request — master (#21)

RoleController::update() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like