ForgotPasswordController::sendResetLinkEmail() - Code Metrics - Inspection of "Return type PHP7 in controllers and splited the va..." - XetaIO/Xetaravel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — reset-password ( a259cf...0d7ca4 )

by Fèvre

created 2017-05-12 13:47 UTC

ForgotPasswordController::sendResetLinkEmail() A

↳ Parent: ForgotPasswordController

Complexity

Conditions	2
Paths	2

Size

Total Lines	15
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	15
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	7
nc	2
nop	1

<?php
namespace Xetaravel\Http\Controllers\Auth;

use Illuminate\Foundation\Auth\SendsPasswordResetEmails;
use Illuminate\Http\Request;
use Illuminate\Http\RedirectResponse;
use Illuminate\Support\Facades\Password;
use Illuminate\View\View;
use Xetaravel\Http\Controllers\Controller;
use Xetaravel\Models\Validators\PasswordResetValidator;

class ForgotPasswordController extends Controller
{
    /*
    |--------------------------------------------------------------------------
    | Password Reset Controller
    |--------------------------------------------------------------------------
    |
    | This controller is responsible for handling password reset emails and
    | includes a trait which assists in sending these notifications from
    | your application to your users. Feel free to explore this trait.
    |
    */
    use SendsPasswordResetEmails;

    /**
     * Create a new controller instance.
     *
     * @return void

     */
    public function __construct()
    {
        $this->middleware('guest');
    }

    /**
     * Display the form to request a password reset link.
     *
     * @return \Illuminate\Http\Response

     */
    public function showLinkRequestForm(): View
    {
        return view('Auth.passwords.email');
    }

    /**
     * Send a reset link to the given user.
     *
     * @param \Illuminate\Http\Request $request
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function sendResetLinkEmail(Request $request): RedirectResponse
    {
        PasswordResetValidator::validateEmail($request->all())->validate();

        // We will send the password reset link to this user. Once we have attempted
        // to send the link, we will examine the response then see the message we
        // need to show to the user. Finally, we'll send out a proper response.
        $response = $this->broker()->sendResetLink(
            $request->only('email')
        );

        return $response == Password::RESET_LINK_SENT
                    ? $this->sendResetLinkResponse($response)
                    : $this->sendResetLinkFailedResponse($request, $response);
    }

    /**
     * Get the response for a successful password reset link.
     *
     * @param string $response
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    protected function sendResetLinkResponse($response): RedirectResponse

    {
        return redirect()
            ->route('page.index')
            ->with('success', 'We have e-mailed your password reset link!');
    }
}


1			<?php
2			namespace Xetaravel\Http\Controllers\Auth;
3
4			use Illuminate\Foundation\Auth\SendsPasswordResetEmails;
5			use Illuminate\Http\Request;
6			use Illuminate\Http\RedirectResponse;
7			use Illuminate\Support\Facades\Password;
8			use Illuminate\View\View;
9			use Xetaravel\Http\Controllers\Controller;
10			use Xetaravel\Models\Validators\PasswordResetValidator;
11
12			class ForgotPasswordController extends Controller
13			{
14			/*
15			\|--------------------------------------------------------------------------
16			\| Password Reset Controller
17			\|--------------------------------------------------------------------------
18			\|
19			\| This controller is responsible for handling password reset emails and
20			\| includes a trait which assists in sending these notifications from
21			\| your application to your users. Feel free to explore this trait.
22			\|
23			*/
24			use SendsPasswordResetEmails;
25
26			/**
27			* Create a new controller instance.
28			*
29			* @return void
			0 ignored issues – show Comprehensibility Best Practice introduced 2017-05-03 18:29 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
30			*/
31			public function __construct()
32			{
33			$this->middleware('guest');
34			}
35
36			/**
37			* Display the form to request a password reset link.
38			*
39			* @return \Illuminate\Http\Response
			0 ignored issues – show Documentation introduced 2017-05-12 13:50 UTC by Report Bug Copy Issue Report Should the return type not be `View`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
40			*/
41			public function showLinkRequestForm(): View
42			{
43			return view('Auth.passwords.email');
44			}
45
46			/**
47			* Send a reset link to the given user.
48			*
49			* @param \Illuminate\Http\Request $request
50			*
51			* @return \Illuminate\Http\RedirectResponse
52			*/
53			public function sendResetLinkEmail(Request $request): RedirectResponse
54			{
55			PasswordResetValidator::validateEmail($request->all())->validate();
56
57			// We will send the password reset link to this user. Once we have attempted
58			// to send the link, we will examine the response then see the message we
59			// need to show to the user. Finally, we'll send out a proper response.
60			$response = $this->broker()->sendResetLink(
61			$request->only('email')
62			);
63
64			return $response == Password::RESET_LINK_SENT
65			? $this->sendResetLinkResponse($response)
66			: $this->sendResetLinkFailedResponse($request, $response);
67			}
68
69			/**
70			* Get the response for a successful password reset link.
71			*
72			* @param string $response
73			*
74			* @return \Illuminate\Http\RedirectResponse
75			*/
76			protected function sendResetLinkResponse($response): RedirectResponse
			0 ignored issues – show Unused Code introduced 2017-05-12 13:50 UTC by Report Bug Copy Issue Report The parameter `$response` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
77			{
78			return redirect()
79			->route('page.index')
80			->with('success', 'We have e-mailed your password reset link!');
81			}
82			}
83

XetaIO / Xetaravel

Push — reset-password ( a259cf...0d7ca4 )

ForgotPasswordController::sendResetLinkEmail() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like