DiscussThreadPresenter - Code Metrics - Inspection of "Added a CommentWasDelete Event to DiscussLogs & ad..." - XetaIO/Xetaravel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — discuss ( 21bc4b...031d9d )

by Fèvre

created 2017-06-12 13:02 UTC

DiscussThreadPresenter A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Coupling/Cohesion

Components	3
Dependencies	0

Importance

Changes

Metric	Value
wmc	6
lcom	3
cbo	0
dl	0
loc	43
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Size	Complexity
A	getContentMarkdownAttribute()	4	1
A	getThreadUrlAttribute()	8	2
A	getLastPageAttribute()	11	3

<?php
namespace Xetaravel\Models\Presenters;

use GrahamCampbell\Markdown\Facades\Markdown;

trait DiscussThreadPresenter
{
    /**
     * Get the content parsed in HTML.
     *
     * @return string
     */
    public function getContentMarkdownAttribute(): string
    {
        return Markdown::convertToHtml($this->content);
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Get the thread url.
     *
     * @return string
     */
    public function getThreadUrlAttribute(): string
    {
        if (!isset($this->slug)) {
            return '';
        }

        return route('discuss.thread.show', ['slug' => $this->slug, 'id' => $this->getKey()]);
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Get the last page number for the thread.
     *
     * @return int
     */
    public function getLastPageAttribute(): int
    {
        $comments = $this->comment_count;
class MyClass { }

$x = new MyClass();
$x->foo = true;

        if ($this->is_solved) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            $comments = $this->comment_count - 1;
        }
        $page = ceil($comments / config('xetaravel.pagination.discuss.comment_per_page'));

        return ($page) ? $page : 1;
    }
}


1			<?php
2			namespace Xetaravel\Models\Presenters;
3
4			use GrahamCampbell\Markdown\Facades\Markdown;
5
6			trait DiscussThreadPresenter
7			{
8			/**
9			* Get the content parsed in HTML.
10			*
11			* @return string
12			*/
13			public function getContentMarkdownAttribute(): string
14			{
15			return Markdown::convertToHtml($this->content);
			0 ignored issues – show Bug introduced 2017-06-12 13:05 UTC by Report Bug Copy Issue Report The property `content` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
16			}
17
18			/**
19			* Get the thread url.
20			*
21			* @return string
22			*/
23			public function getThreadUrlAttribute(): string
24			{
25			if (!isset($this->slug)) {
26			return '';
27			}
28
29			return route('discuss.thread.show', ['slug' => $this->slug, 'id' => $this->getKey()]);
			0 ignored issues – show Bug introduced 2017-06-08 01:00 UTC by Report Bug Copy Issue Report The property `slug` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Bug introduced 2017-06-08 01:00 UTC by Report Bug Copy Issue Report It seems like `getKey()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
30			}
31
32			/**
33			* Get the last page number for the thread.
34			*
35			* @return int
36			*/
37			public function getLastPageAttribute(): int
38			{
39			$comments = $this->comment_count;
			0 ignored issues – show Bug introduced 2017-06-12 13:05 UTC by Report Bug Copy Issue Report The property `comment_count` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
40
41			if ($this->is_solved) {
			0 ignored issues – show Bug introduced 2017-06-12 13:05 UTC by Report Bug Copy Issue Report The property `is_solved` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
42			$comments = $this->comment_count - 1;
43			}
44			$page = ceil($comments / config('xetaravel.pagination.discuss.comment_per_page'));
45
46			return ($page) ? $page : 1;
47			}
48			}
49

XetaIO / Xetaravel

Push — discuss ( 21bc4b...031d9d )

DiscussThreadPresenter A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

Duplication Side-by-Side

Filter issues like