DiscussThreadPresenter::getThreadUrlAttribute() - Code Metrics - Inspection of "Discuss Forum" - XetaIO/Xetaravel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#34)

by Fèvre

created 2017-06-08 15:02 UTC

DiscussThreadPresenter::getThreadUrlAttribute() A

↳ Parent: DiscussThreadPresenter

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	4
nc	2
nop	0

<?php
namespace Xetaravel\Models\Presenters;

trait DiscussThreadPresenter
{
    /**
     * Get the thread url.
     *
     * @return string
     */
    public function getThreadUrlAttribute(): string
    {
        if (!isset($this->slug)) {
            return '';
        }

        return route('discuss.thread.show', ['slug' => $this->slug, 'id' => $this->getKey()]);
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Get the last page number for the thread.
     *
     * @return int
     */
    public function getLastPageAttribute(): int
    {
        $page = ceil($this->comment_count / config('xetaravel.pagination.discuss.comment_per_page'));
class MyClass { }

$x = new MyClass();
$x->foo = true;

        return ($page) ? $page : 1;
    }
}


1			<?php
2			namespace Xetaravel\Models\Presenters;
3
4			trait DiscussThreadPresenter
5			{
6			/**
7			* Get the thread url.
8			*
9			* @return string
10			*/
11			public function getThreadUrlAttribute(): string
12			{
13			if (!isset($this->slug)) {
14			return '';
15			}
16
17			return route('discuss.thread.show', ['slug' => $this->slug, 'id' => $this->getKey()]);
			0 ignored issues – show Bug introduced 2017-06-08 01:00 UTC by Report Bug Copy Issue Report The property `slug` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Bug introduced 2017-06-08 01:00 UTC by Report Bug Copy Issue Report It seems like `getKey()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
18			}
19
20			/**
21			* Get the last page number for the thread.
22			*
23			* @return int
24			*/
25			public function getLastPageAttribute(): int
26			{
27			$page = ceil($this->comment_count / config('xetaravel.pagination.discuss.comment_per_page'));
			0 ignored issues – show Bug introduced 2017-06-08 15:06 UTC by Report Bug Copy Issue Report The property `comment_count` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
28
29			return ($page) ? $page : 1;
30			}
31			}
32

XetaIO / Xetaravel

Pull Request — master (#34)

DiscussThreadPresenter::getThreadUrlAttribute() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like