DiscussConversationPresenter::getLastPageAttribute() - Code Metrics - Inspection of "Added news requirements" - XetaIO/Xetaravel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c7e879...390e33 )

by Fèvre

created 2018-03-11 14:44 UTC

getLastPageAttribute() A

↳ Parent: DiscussConversationPresenter

Complexity

Conditions	3
Paths	4

Size

Total Lines	12
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	6
nc	4
nop	0

<?php
namespace Xetaravel\Models\Presenters;

use GrahamCampbell\Markdown\Facades\Markdown;

trait DiscussConversationPresenter
{
    /**
     * We must decrement the post count due to the first post being counted.
     *
     * @param int $count The actual post count cache.
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     *
     * @return int
     */
    public function getPostCountFormatedAttribute(): int
    {
        return $this->post_count - 1;
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Get the conversation url.
     *
     * @return string
     */
    public function getConversationUrlAttribute(): string
    {
        if (!isset($this->slug)) {
            return '';
        }

        return route('discuss.conversation.show', ['slug' => $this->slug, 'id' => $this->getKey()]);
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Get the last page number for the conversation.
     *
     * @return int
     */
    public function getLastPageAttribute(): int
    {
        $posts = $this->post_count_formated;


        if ($this->is_solved) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            $posts = $posts - 1;
        }

        $page = ceil($posts / config('xetaravel.pagination.discuss.post_per_page'));

        return ($page) ? $page : 1;
    }
}


1			<?php
2			namespace Xetaravel\Models\Presenters;
3
4			use GrahamCampbell\Markdown\Facades\Markdown;
5
6			trait DiscussConversationPresenter
7			{
8			/**
9			* We must decrement the post count due to the first post being counted.
10			*
11			* @param int $count The actual post count cache.
			0 ignored issues – show Bug introduced 2017-06-14 23:44 UTC by Report Bug Copy Issue Report There is no parameter named `$count`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
12			*
13			* @return int
14			*/
15			public function getPostCountFormatedAttribute(): int
16			{
17			return $this->post_count - 1;
			0 ignored issues – show Bug introduced 2017-06-14 23:44 UTC by Report Bug Copy Issue Report The property `post_count` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
18			}
19
20			/**
21			* Get the conversation url.
22			*
23			* @return string
24			*/
25			public function getConversationUrlAttribute(): string
26			{
27			if (!isset($this->slug)) {
28			return '';
29			}
30
31			return route('discuss.conversation.show', ['slug' => $this->slug, 'id' => $this->getKey()]);
			0 ignored issues – show Bug introduced 2017-06-08 01:00 UTC by Report Bug Copy Issue Report The property `slug` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history... Bug introduced 2017-06-08 01:00 UTC by Report Bug Copy Issue Report It seems like `getKey()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
32			}
33
34			/**
35			* Get the last page number for the conversation.
36			*
37			* @return int
38			*/
39			public function getLastPageAttribute(): int
40			{
41			$posts = $this->post_count_formated;
			0 ignored issues – show Bug introduced 2017-06-26 15:01 UTC by Report Bug Copy Issue Report The property `post_count_formated` does not seem to exist. Did you mean `post_count`? An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
42
43			if ($this->is_solved) {
			0 ignored issues – show Bug introduced 2017-06-12 13:05 UTC by Report Bug Copy Issue Report The property `is_solved` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
44			$posts = $posts - 1;
45			}
46
47			$page = ceil($posts / config('xetaravel.pagination.discuss.post_per_page'));
48
49			return ($page) ? $page : 1;
50			}
51			}
52

XetaIO / Xetaravel

Push — master ( c7e879...390e33 )

getLastPageAttribute() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like