Xetaravel\Http\Controllers\User\EmailController

Complexity

Total Complexity

2

Size/Duplication

Total Lines	23
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	update()	0	14	2

<?php

declare(strict_types=1);

namespace Xetaravel\Http\Controllers\User;

use Illuminate\Http\RedirectResponse;
use Illuminate\Support\Facades\Auth;
use Xetaravel\Http\Controllers\Controller;
use Xetaravel\Http\Requests\User\UpdateEmailRequest;

class EmailController extends Controller
{
    /**
     * Updates the authenticated user's email.
     *
     * @param UpdateEmailRequest $request
     *
     * @return RedirectResponse
     */
    public function update(UpdateEmailRequest $request): RedirectResponse
    {
        $user = Auth::user();
        $user->email = $request->input('email');

Accessing email on the interface Illuminate\Contracts\Auth\Authenticatable suggest that you code against a concrete implementation. How about adding an instanceof check?

        if ($user->save()) {
            return redirect()
                ->route('user.setting.index')

The method route() does not exist on Illuminate\Routing\Redirector.

                ->success('Your E-mail has been updated successfully !');
        }

        return redirect()
            ->route('user.setting.index')
            ->error('An error occurred while saving your E-mail!');
    }
}