Xetaravel\Http\Controllers\Admin\PageController

Complexity

Total Complexity

14

Size/Duplication

Total Lines	191
Duplicated Lines	12.04 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
F	index()	23	183	14

<?php
namespace Xetaravel\Http\Controllers\Admin;

use Carbon\Carbon;
use Illuminate\Http\Request;
use Rinvex\Country\CountryLoader;
use Spatie\Analytics\AnalyticsFacade;
use Spatie\Analytics\Period;

class PageController extends Controller
{
    /**
     * Show the application dashboard.
     *
     * @return \Illuminate\Http\Response

Should the return type not be \Illuminate\View\View|\Illuminate\Contracts\View\Factory?

     */
    public function index()
    {
        // Visitors
        $startDate = Carbon::now()->subDays(7);
        $endDate = Carbon::now()->subDay();
        $visitorsData = AnalyticsFacade::performQuery(
            Period::create($startDate, $endDate),
            'ga:sessions,ga:pageviews',
            [
                'dimensions' => 'ga:date',
                'sort' => 'ga:date'
            ]
        );

        $visitorsGraph = [];
        foreach ($visitorsData->rows as $row) {
            $row[0] = Carbon::createFromFormat('Ymd', $row[0]);

            array_push($visitorsGraph, $row);
        }
        $visitorsData->rows = array_reverse($visitorsGraph);

        // Browsers
        $startDate = Carbon::create(2014, 07, 01);
        $browsersData = AnalyticsFacade::performQuery(
            Period::create($startDate, $endDate),
            'ga:pageviews',
            [
                'dimensions' => 'ga:browser',
                'sort' => 'ga:pageviews',
                'filters' => 'ga:browser==Chrome,'
                    .'ga:browser==Firefox,'
                    .'ga:browser==Internet Explorer,'
                    .'ga:browser==Safari,'
                    .'ga:browser==Opera'
            ]
        );

        $browsersGraph = [];
        foreach ($browsersData->rows as $browser) {
            $percent = round(($browser[1] * 100) / $browsersData->totalsForAllResults['ga:pageviews'], 1);

            switch ($browser[0]) {
                case 'Chrome':
                    $color = '#00acac';
                    break;
                case 'Firefox':
                    $color = '#f4645f';
                    break;
                case 'Safari':
                    $color = '#727cb6';
                    break;
                case 'Opera':
                    $color = '#348fe2';
                    break;
                case 'Internet Explorer':
                    $color = '#75e376';
                    break;
                default:
                    $color = '#ddd';
            }

            $browser[] = $percent;
            $browser[] = $color;

            array_push($browsersGraph, $browser);
        }
        $browsersData->rows = array_reverse($browsersGraph);

        // Countries
        $countriesData = AnalyticsFacade::performQuery(
            Period::create($startDate, $endDate),
            'ga:pageviews,ga:sessions',
            [
                'dimensions' => 'ga:countryIsoCode',
                'sort' => '-ga:pageviews'
            ]
        );

        foreach ($countriesData->rows as $country) {
            $countries[$country[0]] = [

$countries was never initialized. Although not strictly required by PHP, it is generally a good practice to add $countries = array(); before regardless.

                'ga:pageviews' => $country[1],
                'ga:sessions' => $country[2],
                'percent' => round(($country[1] * 100) / $countriesData->totalsForAllResults['ga:pageviews'], 1)
            ];

            if (!in_array($country[0], ['ZZ'])) {
                $countryInstance = country((string)strtolower($country[0]));
                $countries[$country[0]] += [
                    'countryName' => $countryInstance->getName()
                ];
            } else {
                $countries[$country[0]] += [

The variable $countries does not seem to be defined for all execution paths leading up to this point.

                    'countryName' => 'Unknown'
                ];
            }
        }
        $countriesData->rows = $countries;
        $topCountries = array_slice($countries, 0, 3);

        // Devices
        $startDate = Carbon::now()->subMonths(7);
        $devicesData = AnalyticsFacade::performQuery(
            Period::create($startDate, $endDate),
            'ga:pageviews',
            [
                'dimensions' => 'ga:mobileDeviceBranding,ga:yearMonth',
                'sort' => '-ga:mobileDeviceBranding',
                'filters' => 'ga:mobileDeviceBranding==Apple,'
                    .'ga:mobileDeviceBranding==Samsung,'
                    .'ga:mobileDeviceBranding==Google,'
                    .'ga:mobileDeviceBranding==HTC,'
                    .'ga:mobileDeviceBranding==Microsoft'
            ]
        );

        $devicesGraph = [];
        for ($i = 0; $i < 8; $i++) {

This code seems to be duplicated across your project.

            $date = Carbon::now()->subMonths($i);

            $devicesGraph[$date->format('Ym')] = [
                'period' => $date->format('Y-m-d'),
                'Apple' => 0,
                'Samsung' => 0,
                'Google' => 0,
                'HTC' => 0,
                'Microsoft' => 0
            ];
        }

        foreach ($devicesData->rows as $device) {
            $devicesGraph[$device[1]][$device[0]] = $device[2];
        }
        $devicesGraph = array_reverse($devicesGraph);
        $devicesGraph = collect($devicesGraph)->toJson();

        // Operating System
        $startDate = Carbon::now()->subMonths(7);
        $operatingSystemData = AnalyticsFacade::performQuery(
            Period::create($startDate, $endDate),
            'ga:pageviews',
            [
                'dimensions' => 'ga:operatingSystem,ga:yearMonth',
                'sort' => '-ga:operatingSystem',
                'filters' => 'ga:operatingSystem==Windows,'
                    .'ga:operatingSystem==Macintosh,'
                    .'ga:operatingSystem==Linux,'
                    .'ga:operatingSystem==(not set)'
            ]
        );

        $operatingSystemGraph = [];
        for ($i = 0; $i < 8; $i++) {

This code seems to be duplicated across your project.

            $date = Carbon::now()->subMonths($i);

            $operatingSystemGraph[$date->format('Ym')] = [
                'period' => $date->format('Y-m-d'),
                'Windows' => 0,
                'Macintosh' => 0,
                'Linux' => 0,
                '(not set)' => 0
            ];
        }

        foreach ($operatingSystemData->rows as $os) {
            $operatingSystemGraph[$os[1]][$os[0]] = $os[2];
        }
        $operatingSystemGraph = array_reverse($operatingSystemGraph);
        $operatingSystemGraph = collect($operatingSystemGraph)->toJson();

        return view(
            'Admin::page.index',
            [
                'breadcrumbs' => $this->breadcrumbs,

The property breadcrumbs does not exist. Did you maybe forget to declare it?

                'visitorsData' => $visitorsData,
                'browsersData' => $browsersData,
                'countriesData' => $countriesData,
                'topCountries' => $topCountries,
                'devicesGraph' => $devicesGraph,
                'operatingSystemGraph' => $operatingSystemGraph
            ]
        );
    }
}