DiscussPostPolicy::solved() - Code Metrics - Inspection of "Fixed PostController::solved() permission" - XetaIO/Xetaravel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — issue-47 ( 257fd0 )

by Fèvre

created 2018-03-15 12:59 UTC

DiscussPostPolicy::solved() A

↳ Parent: DiscussPostPolicy

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	2

<?php
namespace Xetaravel\Policies;

use Xetaravel\Models\User;
use Xetaravel\Models\DiscussPost;
use Illuminate\Auth\Access\HandlesAuthorization;

class DiscussPostPolicy
{
    use HandlesAuthorization;

    /**
     * Authorize all actions if the user has the given permission.
     *
     * @param \Xetaravel\Models\User $user
     * @param string $ability
     *
     * @return true|void

     */
    public function before(User $user, string $ability)

    {
        if ($user->hasPermission('manage.discuss.posts')) {
            return true;
        }
    }

    /**
     * Determine whether the user can update the discuss post.
     *
     * @param \Xetaravel\Models\User $user
     * @param \Xetaravel\Models\DiscussPost $discussPost
     *
     * @return bool
     */
    public function update(User $user, DiscussPost $discussPost)
    {
        return $user->id === $discussPost->user_id;
    }

    /**
     * Determine whether the user can delete the discuss post.
     *
     * @param \Xetaravel\Models\User $user
     * @param \Xetaravel\Models\DiscussPost $discussPost
     *
     * @return bool
     */
    public function delete(User $user, DiscussPost $discussPost)
    {
        return $user->id === $discussPost->user_id;
    }

    /**
     * Determine whether the user can make a discuss post as solved.
     *
     * @param \Xetaravel\Models\User $user
     * @param \Xetaravel\Models\DiscussPost $discussPost
     *
     * @return bool
     */
    public function solved(User $user, DiscussPost $discussPost)
    {
        return $user->id === $discussPost->user_id;
    }
}


1			<?php
2			namespace Xetaravel\Policies;
3
4			use Xetaravel\Models\User;
5			use Xetaravel\Models\DiscussPost;
6			use Illuminate\Auth\Access\HandlesAuthorization;
7
8			class DiscussPostPolicy
9			{
10			use HandlesAuthorization;
11
12			/**
13			* Authorize all actions if the user has the given permission.
14			*
15			* @param \Xetaravel\Models\User $user
16			* @param string $ability
17			*
18			* @return true\|void
			0 ignored issues – show Documentation introduced 2017-06-12 09:40 UTC by Report Bug Copy Issue Report Should the return type not be `boolean\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
19			*/
20			public function before(User $user, string $ability)
			0 ignored issues – show Unused Code introduced 2018-03-11 13:12 UTC by Report Bug Copy Issue Report The parameter `$ability` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
21			{
22			if ($user->hasPermission('manage.discuss.posts')) {
23			return true;
24			}
25			}
26
27			/**
28			* Determine whether the user can update the discuss post.
29			*
30			* @param \Xetaravel\Models\User $user
31			* @param \Xetaravel\Models\DiscussPost $discussPost
32			*
33			* @return bool
34			*/
35			public function update(User $user, DiscussPost $discussPost)
36			{
37			return $user->id === $discussPost->user_id;
38			}
39
40			/**
41			* Determine whether the user can delete the discuss post.
42			*
43			* @param \Xetaravel\Models\User $user
44			* @param \Xetaravel\Models\DiscussPost $discussPost
45			*
46			* @return bool
47			*/
48			public function delete(User $user, DiscussPost $discussPost)
49			{
50			return $user->id === $discussPost->user_id;
51			}
52
53			/**
54			* Determine whether the user can make a discuss post as solved.
55			*
56			* @param \Xetaravel\Models\User $user
57			* @param \Xetaravel\Models\DiscussPost $discussPost
58			*
59			* @return bool
60			*/
61			public function solved(User $user, DiscussPost $discussPost)
62			{
63			return $user->id === $discussPost->user_id;
64			}
65			}
66

XetaIO / Xetaravel

Push — issue-47 ( 257fd0 )

DiscussPostPolicy::solved() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like