Xetaravel\Http\Controllers\Discuss\PostController

Complexity

Total Complexity

16

Size/Duplication

Total Lines	197
Duplicated Lines	16.24 %

Coupling/Cohesion

Components	1
Dependencies	13

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
B	show()	27	27	2
B	create()	5	25	3
B	delete()	0	25	3
B	solved()	0	25	3
B	edit()	0	25	2
A	editTemplate()	0	17	3

<?php
namespace Xetaravel\Http\Controllers\Discuss;

use Carbon\Carbon;
use Illuminate\Http\RedirectResponse;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Auth;
use Xetaio\Mentions\Parser\MentionParser;
use Xetaravel\Models\DiscussConversation;
use Xetaravel\Models\DiscussPost;
use Xetaravel\Models\Repositories\DiscussPostRepository;
use Xetaravel\Models\Repositories\DiscussUserRepository;
use Xetaravel\Models\User;
use Xetaravel\Models\Validators\DiscussPostValidator;

class PostController extends Controller
{
    /**
     * Create a post for a conversation.
     *
     * @param \Illuminate\Http\Request $request
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function create(Request $request): RedirectResponse
    {
        $conversation = DiscussConversation::findOrFail($request->conversation_id);

$conversation is not used, you could remove the assignment.

        // Users that have the permission "manage.discuss" can bypass this rule. (Default to Administrator)
        if (DiscussPost::isFlooding('xetaravel.flood.discuss.post') && !Auth::user()->hasPermission('manage.discuss')) {

It seems like you code against a concrete implementation and not the interface Illuminate\Contracts\Auth\Authenticatable as the method hasPermission() does only exist in the following implementations of said interface: Xetaravel\Models\User.

This code seems to be duplicated across your project.

            return back()
                ->withInput()
                ->with('danger', 'Wow, keep calm bro, and try to not flood !');
        }

        DiscussPostValidator::create($request->all())->validate();
        $post = DiscussPostRepository::create($request->all());
        $user = DiscussUserRepository::create($request->all());

$user is not used, you could remove the assignment.

        $parser = new MentionParser($post);
        $content = $parser->parse($post->content);

        $post->content = $content;
        $post->save();

        return redirect()
            ->route('discuss.post.show', ['id' => $post->getKey()])
            ->with('success', 'Your reply has been posted successfully !');
    }

    /**
     * Redirect an user to a conversation, page and post.
     *
     * @param \Illuminate\Http\Request $request
     * @param int $id The ID of the post.
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function show(Request $request, int $id): RedirectResponse

This method seems to be duplicated in your project.

    {
        $post = DiscussPost::findOrFail($id);

        $postsBefore = DiscussPost::where([
            ['conversation_id', $post->conversation_id],
            ['created_at', '<', $post->created_at]
        ])->count();

        $postsPerPage = config('xetaravel.pagination.discuss.post_per_page');

        $page = floor($postsBefore / $postsPerPage) + 1;
        $page = ($page > 1) ? $page : 1;

        $request->session()->keep(['primary', 'danger', 'warning', 'success', 'info']);

The method keep() does not seem to exist on object<Symfony\Component\HttpFoundation\Session\SessionInterface>.

        return redirect()
            ->route(
                'discuss.conversation.show',
                [
                    'slug' => $post->conversation->slug,
                    'id' => $post->conversation->id,
                    'page' => $page,
                    '#post-' . $post->getKey()
                ]
            );
    }

    /**
     * Handle a delete action for the post.
     *
     * @param \Illuminate\Http\Request $request

There is no parameter named $request. Was it maybe removed?

     * @param int $id
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function delete(int $id): RedirectResponse
    {
        $post = DiscussPost::findOrFail($id);

        $this->authorize('delete', $post);

        if ($post->conversation->first_post_id == $post->getKey()) {
            return redirect()
                ->route('discuss.post.show', ['id' => $post->getKey()])
                ->with('danger', 'You can not delete the first post of a discussion !');
        }

        if ($post->delete()) {
            return redirect()
                ->route(
                    'discuss.conversation.show',
                    ['id' => $post->conversation->getKey(), 'slug' => $post->conversation->slug]
                )
                ->with('success', 'This post has been deleted successfully !');
        }

        return redirect()
            ->route('discuss.post.show', ['id' => $post->getKey()])
            ->with('danger', 'An error occurred while deleting this post !');
    }

    /**
     * Mark as solved.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function solved(int $id): RedirectResponse
    {
        $post = DiscussPost::findOrFail($id);

        $this->authorize('solved', $post);

        if ($post->getKey() == $post->conversation->solved_post_id) {
            return back()
                ->with('danger', 'This post is already the solved post !');
        }

        if (!is_null($post->conversation->solved_post_id)) {
            return back()
                ->with('danger', 'This conversation has already a solved post !');
        }
        $conversation = DiscussConversation::findOrFail($post->conversation_id);

        $conversation->solved_post_id = $post->getKey();
        $conversation->is_solved = true;
        $conversation->save();

        return redirect()
            ->route('discuss.conversation.show', ['slug' => $conversation->slug, 'id' => $conversation->getKey()])
            ->with('success', 'This reply as been marked as solved !');
    }

    /**
     * Handle an edit action for the post.
     *
     * @param Request $request
     * @param int $id The id of the post to edit.
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function edit(Request $request, int $id) : RedirectResponse
    {
        $post = DiscussPost::findOrFail($id);

        if (!Auth::user()->can('update', $post)) {

It seems like you code against a concrete implementation and not the interface Illuminate\Contracts\Auth\Authenticatable as the method can() does only exist in the following implementations of said interface: Illuminate\Foundation\Auth\User, Tests\vendor\Models\User, Xetaravel\Models\User.

            return back()
                ->with('danger', 'You\'re not authorized to edit this message.');
        }

        DiscussPostValidator::edit($request->all())->validate();

        $parser = new MentionParser($post);
        $content = $parser->parse($request->input('content'));

It seems like $request->input('content') targeting Illuminate\Http\Concerns\InteractsWithInput::input() can also be of type array; however, Xetaio\Mentions\Parser\MentionParser::parse() does only seem to accept null|string, maybe add an additional type check?

        $post->content = $content;
        $post->is_edited = true;
        $post->edit_count++;
        $post->edited_user_id = Auth::id();
        $post->edited_at = Carbon::now();
        $post->save();

        return redirect()
            ->route('discuss.post.show', ['id' => $id])
            ->with('success', 'Your post has been edited successfully !');
    }

    /**
     * Get the edit json template.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\JsonResponse|\Illuminate\View\View

Should the return type not be \Symfony\Component\HttpFoundation\Response?

     */
    public function editTemplate(int $id)
    {
        $post = DiscussPost::find($id);

        if (!Auth::user()->can('update', $post) || !$post) {

It seems like you code against a concrete implementation and not the interface Illuminate\Contracts\Auth\Authenticatable as the method can() does only exist in the following implementations of said interface: Illuminate\Foundation\Auth\User, Tests\vendor\Models\User, Xetaravel\Models\User.

            return response()->json([
                'error' => true,
                'message' => 'You\'re not authorized to edit this message or this message has been deleted.'
            ]);
        }

        return response(
            view('Discuss::post.editTemplate', ['post' => $post]),

view('Discuss::post.editTemplate', array('post' => $post)) is of type object<Illuminate\View\View>|object<Illuminate\Contracts\View\Factory>, but the function expects a string.

            200,
            ['Content-Type' => 'application/json']
        );
    }
}