UserController::showUpdateForm() - Code Metrics - Inspection of "Add the update function" - XetaIO/Xetaravel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — manage-users ( 2c714e...6ca97d )

by Fèvre

created 2017-05-19 18:48 UTC

UserController::showUpdateForm() B

↳ Parent: UserController

Complexity

Conditions	3
Paths	3

Size

Total Lines	30
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	30
rs	8.8571
cc	3
eloc	19
nc	3
nop	3

<?php
namespace Xetaravel\Http\Controllers\Admin\User;

use Illuminate\Http\RedirectResponse;
use Illuminate\Http\Request;
use Illuminate\View\View;
use Ultraware\Roles\Models\Role;
use Xetaravel\Http\Controllers\Admin\Controller;
use Xetaravel\Models\Repositories\UserRepository;
use Xetaravel\Models\Repositories\AccountRepository;
use Xetaravel\Models\User;
use Xetaravel\Models\Validators\UserValidator;

class UserController extends Controller
{
    /**
     * Show the search page.
     *
     * @return \Illuminate\View\View
     */
    public function index(): View
    {
        $latestUsers = User::with(['roles'])
            ->limit(5)
            ->latest()
            ->get();

        $breadcrumbs = $this->breadcrumbs->addCrumb('Manage Users', route('admin.user.user.index'));
class MyClass { }

$x = new MyClass();
$x->foo = true;

        return view('Admin::User.user.index', compact('latestUsers', 'breadcrumbs'));
    }
    /**
     * Search users related to the type.
     *
     * @param \Illuminate\Http\Request $request
     *
     * @return \Illuminate\View\View
     */
    public function search(Request $request): View
    {
        $query = User::with(['roles'])->select();
        $search = str_replace('%', '\\%', trim($request->input('search')));
        $type = trim($request->input('type'));

        switch ($type) {
            case 'username':
                $query->where('username', 'like', '%' . $search . '%');
                break;

            case 'email':
                $query->where('email', 'like', '%' . $search . '%');
                break;

            case 'register_ip':
                $query->where('register_ip', 'like', '%' . $search . '%');
                break;

            case 'last_login_ip':
                $query->where('last_login_ip', 'like', '%' . $search . '%');
                break;

            default:
                $query->where('username', 'like', '%' . $search . '%');
                $type = 'username';
                break;
        }
        $users = $query
            ->paginate(10)
            ->appends($request->except('page'));

        $breadcrumbs = $this->breadcrumbs
            ->addCrumb('Manage Users', route('admin.user.user.index'))
            ->addCrumb('Search an user', route('admin.user.user.search'));

        return view('Admin::User.user.search', compact('users', 'breadcrumbs', 'type', 'search'));
    }

    /**
     * Show the update form.
     *
     * @param \Illuminate\Http\Request $request
     * @param string $slug The slug of the user.
     * @param int $id The id of the user.
     *
     * @return \Illuminate\Http\RedirectResponse|\Illuminate\View\View

     */
    public function showUpdateForm(Request $request, string $slug, int $id)

    {
        $user = User::find($id);

        if (is_null($user)) {
            return redirect()
                ->route('admin.user.user.index')
                ->with('danger', 'This user doesn\'t exist or has been deleted !');
        }

        $roles = Role::pluck('name', 'id');
        $attributes = Role::pluck('id')->toArray();

        $optionsAttributes = [];
        foreach ($attributes as $attribute) {
            $optionsAttributes[$attribute] = [
                'style' => Role::where('id', $attribute)->select('css')->first()->css
            ];
        }

        $breadcrumbs = $this->breadcrumbs
            ->setCssClasses('breadcrumb breadcrumb-inverse bg-inverse mb-0')
            ->addCrumb('Manage Users', route('admin.user.user.index'))
            ->addCrumb(
                'Edit ' . e($user->username),
                route('admin.user.user.update', $user->slug, $user->id)
            );

        return view('Admin::User.user.update', compact('user', 'roles', 'optionsAttributes', 'breadcrumbs'));
    }

    /**
     * Handle an user update request for the application.
     *
     * @param \Illuminate\Http\Request $request
     * @param int $id The id of the user to update.
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function update(Request $request, int $id): RedirectResponse
    {
        $user = User::find($id);

        if (is_null($user)) {
            return redirect()
                ->back()
                ->with('danger', 'This user doesn\'t exist or has been deleted !');
        }

        UserValidator::update($request->all(), $user->id)->validate();

        UserRepository::update($request->all(), $user);
        AccountRepository::update($request->get('account'), $user->id);

        $user->roles()->sync($request->get('roles'));

        return redirect()
            ->back()
            ->with('success', 'This user has been updated successfully !');
    }
}


1			<?php
2			namespace Xetaravel\Http\Controllers\Admin\User;
3
4			use Illuminate\Http\RedirectResponse;
5			use Illuminate\Http\Request;
6			use Illuminate\View\View;
7			use Ultraware\Roles\Models\Role;
8			use Xetaravel\Http\Controllers\Admin\Controller;
9			use Xetaravel\Models\Repositories\UserRepository;
10			use Xetaravel\Models\Repositories\AccountRepository;
11			use Xetaravel\Models\User;
12			use Xetaravel\Models\Validators\UserValidator;
13
14			class UserController extends Controller
15			{
16			/**
17			* Show the search page.
18			*
19			* @return \Illuminate\View\View
20			*/
21			public function index(): View
22			{
23			$latestUsers = User::with(['roles'])
24			->limit(5)
25			->latest()
26			->get();
27
28			$breadcrumbs = $this->breadcrumbs->addCrumb('Manage Users', route('admin.user.user.index'));
			0 ignored issues – show Bug introduced 2017-05-17 17:24 UTC by Report Bug Copy Issue Report The property `breadcrumbs` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
29
30			return view('Admin::User.user.index', compact('latestUsers', 'breadcrumbs'));
31			}
32			/**
33			* Search users related to the type.
34			*
35			* @param \Illuminate\Http\Request $request
36			*
37			* @return \Illuminate\View\View
38			*/
39			public function search(Request $request): View
40			{
41			$query = User::with(['roles'])->select();
42			$search = str_replace('%', '\\%', trim($request->input('search')));
43			$type = trim($request->input('type'));
44
45			switch ($type) {
46			case 'username':
47			$query->where('username', 'like', '%' . $search . '%');
48			break;
49
50			case 'email':
51			$query->where('email', 'like', '%' . $search . '%');
52			break;
53
54			case 'register_ip':
55			$query->where('register_ip', 'like', '%' . $search . '%');
56			break;
57
58			case 'last_login_ip':
59			$query->where('last_login_ip', 'like', '%' . $search . '%');
60			break;
61
62			default:
63			$query->where('username', 'like', '%' . $search . '%');
64			$type = 'username';
65			break;
66			}
67			$users = $query
68			->paginate(10)
69			->appends($request->except('page'));
70
71			$breadcrumbs = $this->breadcrumbs
72			->addCrumb('Manage Users', route('admin.user.user.index'))
73			->addCrumb('Search an user', route('admin.user.user.search'));
74
75			return view('Admin::User.user.search', compact('users', 'breadcrumbs', 'type', 'search'));
76			}
77
78			/**
79			* Show the update form.
80			*
81			* @param \Illuminate\Http\Request $request
82			* @param string $slug The slug of the user.
83			* @param int $id The id of the user.
84			*
85			* @return \Illuminate\Http\RedirectResponse\|\Illuminate\View\View
			0 ignored issues – show Documentation introduced 2017-05-16 07:12 UTC by Report Bug Copy Issue Report Should the return type not be `RedirectResponse\|View\|\I...\Contracts\View\Factory`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
86			*/
87			public function showUpdateForm(Request $request, string $slug, int $id)
			0 ignored issues – show Unused Code introduced 2017-05-18 21:30 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-05-18 21:30 UTC by Report Bug Copy Issue Report The parameter `$slug` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
88			{
89			$user = User::find($id);
90
91			if (is_null($user)) {
92			return redirect()
93			->route('admin.user.user.index')
94			->with('danger', 'This user doesn\'t exist or has been deleted !');
95			}
96
97			$roles = Role::pluck('name', 'id');
98			$attributes = Role::pluck('id')->toArray();
99
100			$optionsAttributes = [];
101			foreach ($attributes as $attribute) {
102			$optionsAttributes[$attribute] = [
103			'style' => Role::where('id', $attribute)->select('css')->first()->css
104			];
105			}
106
107			$breadcrumbs = $this->breadcrumbs
108			->setCssClasses('breadcrumb breadcrumb-inverse bg-inverse mb-0')
109			->addCrumb('Manage Users', route('admin.user.user.index'))
110			->addCrumb(
111			'Edit ' . e($user->username),
112			route('admin.user.user.update', $user->slug, $user->id)
113			);
114
115			return view('Admin::User.user.update', compact('user', 'roles', 'optionsAttributes', 'breadcrumbs'));
116			}
117
118			/**
119			* Handle an user update request for the application.
120			*
121			* @param \Illuminate\Http\Request $request
122			* @param int $id The id of the user to update.
123			*
124			* @return \Illuminate\Http\RedirectResponse
125			*/
126			public function update(Request $request, int $id): RedirectResponse
127			{
128			$user = User::find($id);
129
130			if (is_null($user)) {
131			return redirect()
132			->back()
133			->with('danger', 'This user doesn\'t exist or has been deleted !');
134			}
135
136			UserValidator::update($request->all(), $user->id)->validate();
137
138			UserRepository::update($request->all(), $user);
139			AccountRepository::update($request->get('account'), $user->id);
140
141			$user->roles()->sync($request->get('roles'));
142
143			return redirect()
144			->back()
145			->with('success', 'This user has been updated successfully !');
146			}
147			}
148

XetaIO / Xetaravel

Push — manage-users ( 2c714e...6ca97d )

UserController::showUpdateForm() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like