ResetPasswordNotification::toMail() - Code Metrics - Inspection of "Add the Reset Password system" - XetaIO/Xetaravel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#17)

by Fèvre

created 2017-05-12 12:52 UTC

ResetPasswordNotification::toMail() A

↳ Parent: ResetPasswordNotification

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	9
rs	9.6666
c	1
b	0
f	0
cc	1
eloc	7
nc	1
nop	1

<?php
namespace Xetaravel\Notifications;

use Illuminate\Bus\Queueable;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Notifications\Notification;
use Illuminate\Notifications\Messages\MailMessage;

class ResetPasswordNotification extends Notification implements ShouldQueue
{
    use Queueable;

    /**
     * The password reset token.
     *
     * @var string
     */
    public $token;

    /**
     * Create a notification instance.
     *
     * @param  string  $token
     *
     * @return void

     */
    public function __construct($token)
    {
        $this->token = $token;
    }

    /**
     * Get the notification's channels.
     *
     * @param  mixed  $notifiable
     *
     * @return array|string
     */
    public function via($notifiable)

    {
        return ['mail'];
    }

    /**
     * Build the mail representation of the notification.
     *
     * @param mixed $notifiable
     *
     * @return \Illuminate\Notifications\Messages\MailMessage
     */
    public function toMail($notifiable)

    {
        return (new MailMessage)
            ->line('You are receiving this email because we received a password reset request for your account.')
            ->line('If you did not request a password reset, no further action is required.')
            ->action('Reset Password', url(config('app.url') . route('users.auth.password.reset', $this->token, false)))
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->level('primary')
            ->subject('Reset Password - ' . config('app.name'));
    }
}


1			<?php
2			namespace Xetaravel\Notifications;
3
4			use Illuminate\Bus\Queueable;
5			use Illuminate\Contracts\Queue\ShouldQueue;
6			use Illuminate\Notifications\Notification;
7			use Illuminate\Notifications\Messages\MailMessage;
8
9			class ResetPasswordNotification extends Notification implements ShouldQueue
10			{
11			use Queueable;
12
13			/**
14			* The password reset token.
15			*
16			* @var string
17			*/
18			public $token;
19
20			/**
21			* Create a notification instance.
22			*
23			* @param string $token
24			*
25			* @return void
			0 ignored issues – show Comprehensibility Best Practice introduced 2017-05-12 01:43 UTC by Report Bug Copy Issue Report Adding a `@return` annotation to constructors is generally not recommended as a constructor does not have a meaningful return value. Adding a `@return` annotation to a constructor is not recommended, since a constructor does not have a meaningful return value. Please refer to the PHP core documentation on constructors. Loading history...
26			*/
27			public function __construct($token)
28			{
29			$this->token = $token;
30			}
31
32			/**
33			* Get the notification's channels.
34			*
35			* @param mixed $notifiable
36			*
37			* @return array\|string
38			*/
39			public function via($notifiable)
			0 ignored issues – show Unused Code introduced 2017-05-12 01:27 UTC by Report Bug Copy Issue Report The parameter `$notifiable` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
40			{
41			return ['mail'];
42			}
43
44			/**
45			* Build the mail representation of the notification.
46			*
47			* @param mixed $notifiable
48			*
49			* @return \Illuminate\Notifications\Messages\MailMessage
50			*/
51			public function toMail($notifiable)
			0 ignored issues – show Unused Code introduced 2017-05-12 01:27 UTC by Report Bug Copy Issue Report The parameter `$notifiable` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
52			{
53			return (new MailMessage)
54			->line('You are receiving this email because we received a password reset request for your account.')
55			->line('If you did not request a password reset, no further action is required.')
56			->action('Reset Password', url(config('app.url') . route('users.auth.password.reset', $this->token, false)))
			0 ignored issues – show Documentation introduced 2017-05-12 01:27 UTC by Report Bug Copy Issue Report `$this->token` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Bug introduced 2017-05-12 01:27 UTC by Report Bug Copy Issue Report It seems like `url(config('app.url') . ..., $this->token, false))` targeting `url()` can also be of type `object<Illuminate\Contracts\Routing\UrlGenerator>`; however, `Illuminate\Notifications...SimpleMessage::action()` does only seem to accept `string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
57			->level('primary')
58			->subject('Reset Password - ' . config('app.name'));
59			}
60			}
61

XetaIO / Xetaravel

Pull Request — master (#17)

ResetPasswordNotification::toMail() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like