UserEntity::getProfileBackgroundAttribute() - Code Metrics - Inspection of "Re-add scrutinizer" - XetaIO/Xetaravel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (a6481d)

by Fèvre

created 2017-05-04 00:12 UTC

UserEntity::getProfileBackgroundAttribute() A

↳ Parent: UserEntity

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0

<?php
namespace Xetaravel\Models\Entities;

use Xetaravel\Utility\UserUtility;

trait UserEntity
{
    /**
     * Get the small avatar.
     *
     * @return string
     */
    public function getAvatarSmallAttribute(): string
    {
        return $this->getMedia('avatar')[0]->getUrl('thumbnail.small');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Get the medium avatar.
     *
     * @return string
     */
    public function getAvatarMediumAttribute(): string
    {
        return $this->getMedia('avatar')[0]->getUrl('thumbnail.medium');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Get the big avatar.
     *
     * @return string
     */
    public function getAvatarBigAttribute(): string
    {
        return $this->getMedia('avatar')[0]->getUrl('thumbnail.big');
trait Idable {
    public function equalIds(Idable $other) {
        return $this->getId() === $other->getId();
    }
}
    }

    /**
     * Get the porofile background.
     *
     * @return string
     */
    public function getProfileBackgroundAttribute(): string
    {
        return UserUtility::getProfileBackground();
    }
}


1			<?php
2			namespace Xetaravel\Models\Entities;
3
4			use Xetaravel\Utility\UserUtility;
5
6			trait UserEntity
7			{
8			/**
9			* Get the small avatar.
10			*
11			* @return string
12			*/
13			public function getAvatarSmallAttribute(): string
14			{
15			return $this->getMedia('avatar')[0]->getUrl('thumbnail.small');
			0 ignored issues – show Bug introduced 2017-05-03 18:29 UTC by Report Bug Copy Issue Report It seems like `getMedia()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
16			}
17
18			/**
19			* Get the medium avatar.
20			*
21			* @return string
22			*/
23			public function getAvatarMediumAttribute(): string
24			{
25			return $this->getMedia('avatar')[0]->getUrl('thumbnail.medium');
			0 ignored issues – show Bug introduced 2017-05-03 18:29 UTC by Report Bug Copy Issue Report It seems like `getMedia()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
26			}
27
28			/**
29			* Get the big avatar.
30			*
31			* @return string
32			*/
33			public function getAvatarBigAttribute(): string
34			{
35			return $this->getMedia('avatar')[0]->getUrl('thumbnail.big');
			0 ignored issues – show Bug introduced 2017-05-03 18:29 UTC by Report Bug Copy Issue Report It seems like `getMedia()` must be provided by classes using this trait. How about adding it as abstract method to this trait? This check looks for methods that are used by a trait but not required by it. To illustrate, let’s look at the following code example trait Idable { public function equalIds(Idable $other) { return $this->getId() === $other->getId(); } } The trait `Idable` provides a method `equalsId` that in turn relies on the method `getId()`. If this method does not exist on a class mixing in this trait, the method will fail. Adding the `getId()` as an abstract method to the trait will make sure it is available. Loading history...
36			}
37
38			/**
39			* Get the porofile background.
40			*
41			* @return string
42			*/
43			public function getProfileBackgroundAttribute(): string
44			{
45			return UserUtility::getProfileBackground();
46			}
47			}
48

XetaIO / Xetaravel

Branch — master (a6481d)

UserEntity::getProfileBackgroundAttribute() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like