CommentController::create() - Code Metrics - Inspection of "Re-add scrutinizer" - XetaIO/Xetaravel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Branch — master (a6481d)

by Fèvre

created 2017-05-04 00:12 UTC

CommentController::create() A

↳ Parent: CommentController

Complexity

Conditions	3
Paths	2

Size

Total Lines	17
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	17
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	10
nc	2
nop	1

<?php
namespace Xetaravel\Http\Controllers\Blog;

use Illuminate\Http\RedirectResponse;
use Illuminate\Http\Request;
use Xetaravel\Http\Controllers\Controller;
use Xetaravel\Models\Article;
use Xetaravel\Models\Repositories\CommentRepository;
use Xetaravel\Models\Validators\CommentValidator;

class CommentController extends Controller
{
    /**
     * Create a comment for an article.
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function create(Request $request): RedirectResponse
    {
        // Check if the article exist and if its display.
        $article = Article::find($request->article_id);

        if (is_null($article) || $article->is_display == false) {
            return back()
                ->withInput()
                ->with('danger', 'This article doesn\'t exist or you can not reply to it !');
        }

        CommentValidator::create($request->all())->validate();
        CommentRepository::create($request->all(), auth()->user());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        return back()
            ->with('success', 'Your comment has been posted successfully !');
    }
}


1			<?php
2			namespace Xetaravel\Http\Controllers\Blog;
3
4			use Illuminate\Http\RedirectResponse;
5			use Illuminate\Http\Request;
6			use Xetaravel\Http\Controllers\Controller;
7			use Xetaravel\Models\Article;
8			use Xetaravel\Models\Repositories\CommentRepository;
9			use Xetaravel\Models\Validators\CommentValidator;
10
11			class CommentController extends Controller
12			{
13			/**
14			* Create a comment for an article.
15			*
16			* @return \Illuminate\Http\RedirectResponse
17			*/
18			public function create(Request $request): RedirectResponse
19			{
20			// Check if the article exist and if its display.
21			$article = Article::find($request->article_id);
22
23			if (is_null($article) \|\| $article->is_display == false) {
24			return back()
25			->withInput()
26			->with('danger', 'This article doesn\'t exist or you can not reply to it !');
27			}
28
29			CommentValidator::create($request->all())->validate();
30			CommentRepository::create($request->all(), auth()->user());
			0 ignored issues – show Bug introduced 2017-05-03 18:29 UTC by Report Bug Copy Issue Report The method `user` does only exist in `Illuminate\Contracts\Auth\Guard`, but not in `Illuminate\Contracts\Auth\Factory`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
31
32			return back()
33			->with('success', 'Your comment has been posted successfully !');
34			}
35			}
36

XetaIO / Xetaravel

Branch — master (a6481d)

CommentController::create() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like