Xetaravel\Http\Controllers\PageController

Complexity

Total Complexity

3

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	5

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	0	14	1
A	banished()	0	9	2

<?php
namespace Xetaravel\Http\Controllers;

use Xetaravel\Models\Article;
use Xetaravel\Models\Comment;
use Illuminate\Support\Facades\Auth;

class PageController extends Controller
{
    /**
     * Show the home page.
     *
     * @return \Illuminate\Http\Response

Should the return type not be \Illuminate\View\View|\Illuminate\Contracts\View\Factory?

     */
    public function index()
    {
        $articles = Article::with('category', 'user')
            ->latest()
            ->limit(6)
            ->get();

        $comments = Comment::with('article', 'user')
            ->latest()
            ->limit(4)
            ->get();

        return view('page.index', ['articles' => $articles, 'comments' => $comments]);
    }

    /**
     * Display the banished page.
     *
     * @return \Illuminate\Http\Response

Should the return type not be \Illuminate\Http\RedirectResponse|\Illuminate\View\View|\Illuminate\Contracts\View\Factory?

     */
    public function banished()
    {
        if (!Auth::user()->hasRole('banished')) {

It seems like you code against a concrete implementation and not the interface Illuminate\Contracts\Auth\Authenticatable as the method hasRole() does only exist in the following implementations of said interface: Xetaravel\Models\User.

            return redirect()
                ->route('page_index');
        }

        return view('page.banished');
    }
}