Xetaravel\Models\Presenters\ShopItemPresenter

Complexity

Total Complexity

3

Size/Duplication

Total Lines	33
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getItemIconAttribute()	0	3	1
A	parseMedia()	0	7	2

<?php

namespace Xetaravel\Models\Presenters;

trait ShopItemPresenter
{
    /**
     * The default banner used when there is no banner for the item.
     *
     * @var string
     */
    protected string $defaultIcon = '/images/shop/default_icon.svg';

    /**
     * Get the icon.
     *
     * @return string
     */
    public function getItemIconAttribute(): string
    {
        return $this->parseMedia('item.icon');
    }

    /**
     * Parse a media and return it if isset or return the default banner.
     *
     * @param string $type The type of the media to get.
     *
     * @return string
     */
    protected function parseMedia(string $type): string

The parameter $type is not used and could be removed.

    {
        if (isset($this->getMedia('item')[0])) {

It seems like getMedia() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            return $this->getMedia('item')[0]->getFullUrl();
        }

        return $this->defaultIcon;
    }
}