SecurityController::index() - Code Metrics - Inspection of "Add the Security Page in user account with the lis..." - XetaIO/Xetaravel - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — activity-logs ( 999e93...08c980 )

by Fèvre

created 2022-03-30 12:03 UTC

SecurityController::index() A

↳ Parent: SecurityController

Complexity

Conditions	2
Paths	2

Size

Total Lines	20
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	2
eloc	11
c	1
b	0
f	0
nc	2
nop	1
dl	0
loc	20
rs	9.9

<?php
namespace Xetaravel\Http\Controllers;

use Illuminate\Http\Request;
use Illuminate\Support\Facades\Auth;
use Illuminate\View\View;
use Propa\BrowscapPHP\Facades\Browscap;
use Xetaravel\Models\Session;

class SecurityController extends Controller
{
    /**
     * Constructor
     */
    public function __construct()
    {
        parent::__construct();

        $this->breadcrumbs->addCrumb('Security', route('users.security.index'));
    }

    /**
     * Show the security index page.
     *
     * @return \Illuminate\View\View
     */
    public function index(Request $request): View
    {
        $records = Session::expires()->where('user_id', Auth::id())->get();

        $sessions = [];

        foreach ($records as $record) {
            $infos = Browscap::getBrowser($record->user_agent);


            $record->infos = $infos;


            array_push($sessions, $record);
        }

        $sessionId = $request->session()->getId();

        return view('security.index', [
            'sessions' => $sessions,
            'sessionId' => $sessionId,
            'breadcrumbs' => $this->breadcrumbs
        ]);
    }
}


1			<?php
2			namespace Xetaravel\Http\Controllers;
3
4			use Illuminate\Http\Request;
5			use Illuminate\Support\Facades\Auth;
6			use Illuminate\View\View;
7			use Propa\BrowscapPHP\Facades\Browscap;
8			use Xetaravel\Models\Session;
9
10			class SecurityController extends Controller
11			{
12			/**
13			* Constructor
14			*/
15			public function __construct()
16			{
17			parent::__construct();
18
19			$this->breadcrumbs->addCrumb('Security', route('users.security.index'));
20			}
21
22			/**
23			* Show the security index page.
24			*
25			* @return \Illuminate\View\View
26			*/
27			public function index(Request $request): View
28			{
29			$records = Session::expires()->where('user_id', Auth::id())->get();
30
31			$sessions = [];
32
33			foreach ($records as $record) {
34			$infos = Browscap::getBrowser($record->user_agent);
			0 ignored issues – show Bug Best Practice introduced 2022-03-30 12:11 UTC by Report Bug Copy Issue Report The property `user_agent` does not exist on `Xetaravel\Models\Session`. Since you implemented `__get`, consider adding a @property annotation. Loading history...
35
36			$record->infos = $infos;
			0 ignored issues – show Bug Best Practice introduced 2022-03-30 12:11 UTC by Report Bug Copy Issue Report The property `infos` does not exist on `Xetaravel\Models\Session`. Since you implemented `__set`, consider adding a @property annotation. Loading history...
37
38			array_push($sessions, $record);
39			}
40
41			$sessionId = $request->session()->getId();
42
43			return view('security.index', [
44			'sessions' => $sessions,
45			'sessionId' => $sessionId,
46			'breadcrumbs' => $this->breadcrumbs
47			]);
48			}
49			}
50

XetaIO / Xetaravel

Push — activity-logs ( 999e93...08c980 )

SecurityController::index() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like