DiscussLogPresenter - Code Metrics - Inspection of "Discuss Forum" - XetaIO/Xetaravel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#34)

by Fèvre

created 2017-06-12 09:24 UTC

DiscussLogPresenter A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	55
Duplicated Lines	29.09 %

Coupling/Cohesion

Components	1
Dependencies	0

Importance

Changes

Metric	Value
wmc	9
lcom	1
cbo	0
dl	16
loc	55
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Duplication	Size	Complexity
B	getTypeAttribute()	0	19	5
A	getOldCategoryAttribute()	8	8	2
A	getNewCategoryAttribute()	8	8	2

How to fix Duplicated Code

<?php
namespace Xetaravel\Models\Presenters;

use Xetaravel\Events\Discuss\ThreadTitleWasChangedEvent;
use Xetaravel\Events\Discuss\ThreadCategoryWasChangedEvent;
use Xetaravel\Events\Discuss\ThreadWasLockedEvent;
use Xetaravel\Events\Discuss\ThreadWasPinnedEvent;
use Xetaravel\Models\DiscussCategory;

trait DiscussLogPresenter
{
    /**
     * Get the type related to the Event.
     *
     * @return string

     */
    public function getTypeAttribute()
    {
        switch ($this->event_type) {
class MyClass { }

$x = new MyClass();
$x->foo = true;
            case ThreadCategoryWasChangedEvent::class:
                return 'category';
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case ThreadTitleWasChangedEvent::class:
                return 'title';
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case ThreadWasLockedEvent::class:
                return 'locked';
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case ThreadWasPinnedEvent::class:
                return 'pinned';
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            default:
                return 'unknown';
        }
    }

    /**
     * Get the old category.
     *
     * @return \Xetaravel\Models\DiscussCategory
     */
    public function getOldCategoryAttribute()

    {
        if ($this->event_type !== ThreadCategoryWasChangedEvent::class) {
            return null;
        }

        return DiscussCategory::find($this->data['old']);
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Get the new category.
     *
     * @return \Xetaravel\Models\DiscussCategory
     */
    public function getNewCategoryAttribute()

    {
        if ($this->event_type !== ThreadCategoryWasChangedEvent::class) {
            return null;
        }

        return DiscussCategory::find($this->data['new']);
    }
}


1		<?php
2		namespace Xetaravel\Models\Presenters;
3
4		use Xetaravel\Events\Discuss\ThreadTitleWasChangedEvent;
5		use Xetaravel\Events\Discuss\ThreadCategoryWasChangedEvent;
6		use Xetaravel\Events\Discuss\ThreadWasLockedEvent;
7		use Xetaravel\Events\Discuss\ThreadWasPinnedEvent;
8		use Xetaravel\Models\DiscussCategory;
9
10		trait DiscussLogPresenter
11		{
12		/**
13		* Get the type related to the Event.
14		*
15		* @return string
		0 ignored issues – show Documentation introduced 2017-06-12 09:40 UTC by Report Bug Copy Issue Report Should the return type not be `string\|null`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
16		*/
17		public function getTypeAttribute()
18		{
19		switch ($this->event_type) {
		0 ignored issues – show Bug introduced 2017-06-12 09:40 UTC by Report Bug Copy Issue Report The property `event_type` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
20		case ThreadCategoryWasChangedEvent::class:
21		return 'category';
22		break;
		0 ignored issues – show Unused Code introduced 2017-06-12 09:40 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
23		case ThreadTitleWasChangedEvent::class:
24		return 'title';
25		break;
		0 ignored issues – show Unused Code introduced 2017-06-12 09:40 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
26		case ThreadWasLockedEvent::class:
27		return 'locked';
28		break;
		0 ignored issues – show Unused Code introduced 2017-06-12 09:40 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
29		case ThreadWasPinnedEvent::class:
30		return 'pinned';
31		break;
		0 ignored issues – show Unused Code introduced 2017-06-12 09:40 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
32		default:
33		return 'unknown';
34		}
35		}
36
37		/**
38		* Get the old category.
39		*
40		* @return \Xetaravel\Models\DiscussCategory
41		*/
42	View Code Duplication	public function getOldCategoryAttribute()
		0 ignored issues – show Duplication introduced 2017-06-12 09:40 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
43		{
44		if ($this->event_type !== ThreadCategoryWasChangedEvent::class) {
45		return null;
46		}
47
48		return DiscussCategory::find($this->data['old']);
		0 ignored issues – show Bug introduced 2017-06-12 09:40 UTC by Report Bug Copy Issue Report The property `data` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
49		}
50
51		/**
52		* Get the new category.
53		*
54		* @return \Xetaravel\Models\DiscussCategory
55		*/
56	View Code Duplication	public function getNewCategoryAttribute()
		0 ignored issues – show Duplication introduced 2017-06-12 09:40 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
57		{
58		if ($this->event_type !== ThreadCategoryWasChangedEvent::class) {
59		return null;
60		}
61
62		return DiscussCategory::find($this->data['new']);
63		}
64		}
65

XetaIO / Xetaravel

Pull Request — master (#34)

DiscussLogPresenter A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like