Xetaravel\Http\Controllers\Admin\Blog\ArticleController

Complexity

Total Complexity

11

Size/Duplication

Total Lines	134
Duplicated Lines	14.18 %

Coupling/Cohesion

Components	1
Dependencies	8

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	index()	9	9	1
A	showCreateForm()	10	10	1
A	create()	0	10	2
B	showUpdateForm()	0	25	2
A	update()	0	12	2
A	delete()	0	20	3

<?php
namespace Xetaravel\Http\Controllers\Admin\Blog;

use Illuminate\Http\RedirectResponse;
use Illuminate\Http\Request;
use Illuminate\View\View;
use Xetaravel\Http\Controllers\Admin\Controller;
use Xetaravel\Models\Article;
use Xetaravel\Models\Category;
use Xetaravel\Models\Repositories\ArticleRepository;
use Xetaravel\Models\Validators\ArticleValidator;

class ArticleController extends Controller
{
    /**
     * Show all articles.
     *
     * @return \Illuminate\View\View
     */
    public function index(): View

This method seems to be duplicated in your project.

    {
        $articles = Article::with('category', 'user')

The method paginate does only exist in Illuminate\Database\Eloquent\Builder, but not in Illuminate\Database\Eloquent\Model.

            ->paginate(config('xetaravel.pagination.blog.article_per_page'));

        $this->breadcrumbs->addCrumb('Manage Articles', route('admin.blog.article.index'));

The property breadcrumbs does not exist. Did you maybe forget to declare it?

        return view('Admin::Blog.article.index', ['articles' => $articles, 'breadcrumbs' => $this->breadcrumbs]);
    }

    /**
     * Show the article create form.
     *
     * @return \Illuminate\View\View
     */
    public function showCreateForm(): View

This method seems to be duplicated in your project.

    {
        $categories = Category::pluck('title', 'id');

        $breadcrumbs = $this->breadcrumbs

$breadcrumbs is not used, you could remove the assignment.

            ->addCrumb('Manage Articles', route('admin.blog.article.index'))
            ->addCrumb("Create", route('admin.blog.article.create'));

        return view('Admin::Blog.article.create', ['categories' => $categories, 'breadcrumbs' => $this->breadcrumbs]);
    }

    /**
     * Handle an article create request for the application.
     *
     * @param \Illuminate\Http\Request $request
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function create(Request $request): RedirectResponse
    {
        ArticleValidator::create($request->all())->validate();

        if (ArticleRepository::create($request->all())) {
            return redirect()
                ->route('admin.blog.article.index')
                ->with('success', 'Your article has been created successfully !');
        }
    }

    /**
     * Show the article update form.
     *
     * @param string $slug The slug of the article.
     * @param int $id The id of the article.
     *
     * @return \Illuminate\Http\RedirectResponse|\Illuminate\View\View

Should the return type not be RedirectResponse|View|\Illuminate\Contracts\View\Factory?

     */
    public function showUpdateForm(string $slug, int $id)

The parameter $slug is not used and could be removed.

    {
        $article = Article::with('category', 'user', 'comments')

The method where does only exist in Illuminate\Database\Eloquent\Builder, but not in Illuminate\Database\Eloquent\Model.

            ->where('id', $id)
            ->first();

        if (is_null($article)) {
            return redirect()
                ->route('admin.blog.article.index')
                ->with('danger', 'This article doesn\'t exist or has been deleted !');
        }
        $categories = Category::pluck('title', 'id');

        $breadcrumbs = $this->breadcrumbs
            ->addCrumb('Manage Articles', route('admin.blog.article.index'))
            ->addCrumb(
                "Update : " . e(str_limit($article->title, 30)),
                route(
                    'admin.blog.article.index',
                    ['slug' => $article->category->slug, 'id' => $article->category->id]
                )
            );

        return view('Admin::Blog.article.update', compact('article', 'breadcrumbs', 'categories'));
    }

    /**
     * Handle an article update request for the application.
     *
     * @param \Illuminate\Http\Request $request
     * @param int $id The id of the article.
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function update(Request $request, int $id): RedirectResponse
    {
        ArticleValidator::update($request->all(), $id)->validate();

        $article = Article::find($id);

        if (ArticleRepository::update($request->all(), $article)) {
            return redirect()
                ->route('admin.blog.article.index')
                ->with('success', 'Your article has been updated successfully !');
        }
    }

    /**
     * Handle the delete request for the article.
     *
     * @param int $id The id of the article to delete.
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function delete(int $id): RedirectResponse
    {
        $article = Article::find($id);

        if (is_null($article)) {
            return redirect()
                ->route('admin.blog.article.index')
                ->with('danger', 'This article doesn\'t exist or has already been deleted !');
        }

        if ($article->delete()) {
            return redirect()
                ->route('admin.blog.article.index')
                ->with('success', 'This article has been deleted successfully !');
        }

        return redirect()
            ->route('admin.blog.article.index')
            ->with('danger', 'An error occurred while deleting this article !');
    }
}