PostController::solved() - Code Metrics - Inspection of "Added Rubies" - XetaIO/Xetaravel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — issue-37 ( 44d7c4...b086ff )

by Fèvre

created 2018-03-27 17:08 UTC

PostController::solved() B

↳ Parent: PostController

Complexity

Conditions	3
Paths	3

Size

Total Lines	32
Code Lines	20

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	32
rs	8.8571
c	0
b	0
f	0
cc	3
eloc	20
nc	3
nop	1

<?php
namespace Xetaravel\Http\Controllers\Discuss;

use Carbon\Carbon;
use Illuminate\Http\RedirectResponse;
use Illuminate\Http\Request;
use Illuminate\Support\Facades\Auth;
use Xetaio\Mentions\Parser\MentionParser;
use Xetaravel\Events\Experiences\PostWasCreatedEvent;
use Xetaravel\Events\Experiences\PostWasSolvedEvent;
use Xetaravel\Events\Rubies\PostWasSolvedEvent as RubiesPostWasSolvedEvent;
use Xetaravel\Models\DiscussConversation;
use Xetaravel\Models\DiscussPost;
use Xetaravel\Models\Repositories\DiscussPostRepository;
use Xetaravel\Models\Repositories\DiscussUserRepository;
use Xetaravel\Models\User;
use Xetaravel\Models\Validators\DiscussPostValidator;

class PostController extends Controller
{
    /**
     * Create a post for a conversation.
     *
     * @param \Illuminate\Http\Request $request
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function create(Request $request): RedirectResponse
    {
        $conversation = DiscussConversation::findOrFail($request->conversation_id);
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        // Users that have the permission "manage.discuss" can bypass this rule. (Default to Administrator)
        if (DiscussPost::isFlooding('xetaravel.flood.discuss.post') && !Auth::user()->hasPermission('manage.discuss')) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            return back()
                ->withInput()
                ->with('danger', 'Wow, keep calm bro, and try to not flood !');
        }

        DiscussPostValidator::create($request->all())->validate();
        $post = DiscussPostRepository::create($request->all());
        $user = DiscussUserRepository::create($request->all());
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $parser = new MentionParser($post);
        $content = $parser->parse($post->content);

        $post->content = $content;
        $post->save();

        event(new PostWasCreatedEvent($post, Auth::user()));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        return redirect()
            ->route('discuss.post.show', ['id' => $post->getKey()])
            ->with('success', 'Your reply has been posted successfully !');
    }

    /**
     * Redirect an user to a conversation, page and post.
     *
     * @param \Illuminate\Http\Request $request
     * @param int $id The ID of the post.
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function show(Request $request, int $id): RedirectResponse

    {
        $post = DiscussPost::findOrFail($id);

        $postsBefore = DiscussPost::where([
            ['conversation_id', $post->conversation_id],
            ['created_at', '<', $post->created_at]
        ])->count();

        $postsPerPage = config('xetaravel.pagination.discuss.post_per_page');

        $page = floor($postsBefore / $postsPerPage) + 1;
        $page = ($page > 1) ? $page : 1;

        $request->session()->keep(['primary', 'danger', 'warning', 'success', 'info']);


        return redirect()
            ->route(
                'discuss.conversation.show',
                [
                    'slug' => $post->conversation->slug,
                    'id' => $post->conversation->id,
                    'page' => $page,
                    '#post-' . $post->getKey()
                ]
            );
    }

    /**
     * Handle a delete action for the post.
     *
     * @param \Illuminate\Http\Request $request
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param int $id
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function delete(int $id): RedirectResponse
    {
        $post = DiscussPost::findOrFail($id);

        $this->authorize('delete', $post);

        if ($post->conversation->first_post_id == $post->getKey()) {
            return redirect()
                ->route('discuss.post.show', ['id' => $post->getKey()])
                ->with('danger', 'You can not delete the first post of a discussion !');
        }

        if ($post->delete()) {
            return redirect()
                ->route(
                    'discuss.conversation.show',
                    ['id' => $post->conversation->getKey(), 'slug' => $post->conversation->slug]
                )
                ->with('success', 'This post has been deleted successfully !');
        }

        return redirect()
            ->route('discuss.post.show', ['id' => $post->getKey()])
            ->with('danger', 'An error occurred while deleting this post !');
    }

    /**
     * Mark as solved.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function solved(int $id): RedirectResponse
    {
        $post = DiscussPost::findOrFail($id);

        $this->authorize('solved', $post);

        if ($post->getKey() == $post->conversation->solved_post_id) {
            return back()
                ->with('danger', 'This post is already the solved post !');
        }

        if (!is_null($post->conversation->solved_post_id)) {
            return back()
                ->with('danger', 'This conversation has already a solved post !');
        }
        $conversation = DiscussConversation::findOrFail($post->conversation_id);

        $conversation->solved_post_id = $post->getKey();
        $conversation->is_solved = true;
        $conversation->save();

        $post->is_solved = true;
        $post->save();

        event(new PostWasSolvedEvent($post, Auth::user()));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        event(new RubiesPostWasSolvedEvent($post, Auth::user()));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        return redirect()
            ->route('discuss.conversation.show', ['slug' => $conversation->slug, 'id' => $conversation->getKey()])
            ->with('success', 'This reply as been marked as solved !');
    }

    /**
     * Handle an edit action for the post.
     *
     * @param Request $request
     * @param int $id The id of the post to edit.
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function edit(Request $request, int $id) : RedirectResponse
    {
        $post = DiscussPost::findOrFail($id);

        if (!Auth::user()->can('update', $post)) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            return back()
                ->with('danger', 'You\'re not authorized to edit this message.');
        }

        DiscussPostValidator::edit($request->all())->validate();

        $parser = new MentionParser($post);
        $content = $parser->parse($request->input('content'));


        $post->content = $content;
        $post->is_edited = true;
        $post->edit_count++;
        $post->edited_user_id = Auth::id();
        $post->edited_at = Carbon::now();
        $post->save();

        return redirect()
            ->route('discuss.post.show', ['id' => $id])
            ->with('success', 'Your post has been edited successfully !');
    }

    /**
     * Get the edit json template.
     *
     * @param int $id
     *
     * @return \Illuminate\Http\JsonResponse|\Illuminate\View\View

     */
    public function editTemplate(int $id)
    {
        $post = DiscussPost::find($id);

        if (!Auth::user()->can('update', $post) || !$post) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            return response()->json([
                'error' => true,
                'message' => 'You\'re not authorized to edit this message or this message has been deleted.'
            ]);
        }

        return response(
            view('Discuss::post.editTemplate', ['post' => $post]),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            200,
            ['Content-Type' => 'application/json']
        );
    }
}


Push — issue-37 ( 44d7c4...b086ff )

PostController::solved() B

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

1		<?php
2		namespace Xetaravel\Http\Controllers\Discuss;
3
4		use Carbon\Carbon;
5		use Illuminate\Http\RedirectResponse;
6		use Illuminate\Http\Request;
7		use Illuminate\Support\Facades\Auth;
8		use Xetaio\Mentions\Parser\MentionParser;
9		use Xetaravel\Events\Experiences\PostWasCreatedEvent;
10		use Xetaravel\Events\Experiences\PostWasSolvedEvent;
11		use Xetaravel\Events\Rubies\PostWasSolvedEvent as RubiesPostWasSolvedEvent;
12		use Xetaravel\Models\DiscussConversation;
13		use Xetaravel\Models\DiscussPost;
14		use Xetaravel\Models\Repositories\DiscussPostRepository;
15		use Xetaravel\Models\Repositories\DiscussUserRepository;
16		use Xetaravel\Models\User;
17		use Xetaravel\Models\Validators\DiscussPostValidator;
18
19		class PostController extends Controller
20		{
21		/**
22		* Create a post for a conversation.
23		*
24		* @param \Illuminate\Http\Request $request
25		*
26		* @return \Illuminate\Http\RedirectResponse
27		*/
28		public function create(Request $request): RedirectResponse
29		{
30		$conversation = DiscussConversation::findOrFail($request->conversation_id);
		0 ignored issues – show Unused Code introduced 2017-06-14 23:44 UTC by Report Bug Copy Issue Report `$conversation` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
31
32		// Users that have the permission "manage.discuss" can bypass this rule. (Default to Administrator)
33	View Code Duplication	if (DiscussPost::isFlooding('xetaravel.flood.discuss.post') && !Auth::user()->hasPermission('manage.discuss')) {
		0 ignored issues – show Bug introduced 2018-03-12 23:31 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Illuminate\Contracts\Auth\Authenticatable` as the method `hasPermission()` does only exist in the following implementations of said interface: `Xetaravel\Models\User`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history... Duplication introduced 2018-03-15 02:58 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
34		return back()
35		->withInput()
36		->with('danger', 'Wow, keep calm bro, and try to not flood !');
37		}
38
39		DiscussPostValidator::create($request->all())->validate();
40		$post = DiscussPostRepository::create($request->all());
41		$user = DiscussUserRepository::create($request->all());
		0 ignored issues – show Unused Code introduced 2017-06-14 23:44 UTC by Report Bug Copy Issue Report `$user` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
42
43		$parser = new MentionParser($post);
44		$content = $parser->parse($post->content);
45
46		$post->content = $content;
47		$post->save();
48
49		event(new PostWasCreatedEvent($post, Auth::user()));
		0 ignored issues – show Documentation introduced 2018-03-26 23:59 UTC by Report Bug Copy Issue Report `\Illuminate\Support\Facades\Auth::user()` is of type `object<Illuminate\Contra...h\Authenticatable>\|null`, but the function expects a `object<Xetaravel\Models\User>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
50
51		return redirect()
52		->route('discuss.post.show', ['id' => $post->getKey()])
53		->with('success', 'Your reply has been posted successfully !');
54		}
55
56		/**
57		* Redirect an user to a conversation, page and post.
58		*
59		* @param \Illuminate\Http\Request $request
60		* @param int $id The ID of the post.
61		*
62		* @return \Illuminate\Http\RedirectResponse
63		*/
64	View Code Duplication	public function show(Request $request, int $id): RedirectResponse
		0 ignored issues – show Duplication introduced 2018-03-11 13:12 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
65		{
66		$post = DiscussPost::findOrFail($id);
67
68		$postsBefore = DiscussPost::where([
69		['conversation_id', $post->conversation_id],
70		['created_at', '<', $post->created_at]
71		])->count();
72
73		$postsPerPage = config('xetaravel.pagination.discuss.post_per_page');
74
75		$page = floor($postsBefore / $postsPerPage) + 1;
76		$page = ($page > 1) ? $page : 1;
77
78		$request->session()->keep(['primary', 'danger', 'warning', 'success', 'info']);
		0 ignored issues – show Bug introduced 2017-06-14 23:44 UTC by Report Bug Copy Issue Report The method `keep()` does not seem to exist on `object<Symfony\Component...ssion\SessionInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
79
80		return redirect()
81		->route(
82		'discuss.conversation.show',
83		[
84		'slug' => $post->conversation->slug,
85		'id' => $post->conversation->id,
86		'page' => $page,
87		'#post-' . $post->getKey()
88		]
89		);
90		}
91
92		/**
93		* Handle a delete action for the post.
94		*
95		* @param \Illuminate\Http\Request $request
		0 ignored issues – show Bug introduced 2017-07-03 11:07 UTC by Report Bug Copy Issue Report There is no parameter named `$request`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
96		* @param int $id
97		*
98		* @return \Illuminate\Http\RedirectResponse
99		*/
100		public function delete(int $id): RedirectResponse
101		{
102		$post = DiscussPost::findOrFail($id);
103
104		$this->authorize('delete', $post);
105
106		if ($post->conversation->first_post_id == $post->getKey()) {
107		return redirect()
108		->route('discuss.post.show', ['id' => $post->getKey()])
109		->with('danger', 'You can not delete the first post of a discussion !');
110		}
111
112		if ($post->delete()) {
113		return redirect()
114		->route(
115		'discuss.conversation.show',
116		['id' => $post->conversation->getKey(), 'slug' => $post->conversation->slug]
117		)
118		->with('success', 'This post has been deleted successfully !');
119		}
120
121		return redirect()
122		->route('discuss.post.show', ['id' => $post->getKey()])
123		->with('danger', 'An error occurred while deleting this post !');
124		}
125
126		/**
127		* Mark as solved.
128		*
129		* @param int $id
130		*
131		* @return \Illuminate\Http\RedirectResponse
132		*/
133		public function solved(int $id): RedirectResponse
134		{
135		$post = DiscussPost::findOrFail($id);
136
137		$this->authorize('solved', $post);
138
139		if ($post->getKey() == $post->conversation->solved_post_id) {
140		return back()
141		->with('danger', 'This post is already the solved post !');
142		}
143
144		if (!is_null($post->conversation->solved_post_id)) {
145		return back()
146		->with('danger', 'This conversation has already a solved post !');
147		}
148		$conversation = DiscussConversation::findOrFail($post->conversation_id);
149
150		$conversation->solved_post_id = $post->getKey();
151		$conversation->is_solved = true;
152		$conversation->save();
153
154		$post->is_solved = true;
155		$post->save();
156
157		event(new PostWasSolvedEvent($post, Auth::user()));
		0 ignored issues – show Documentation introduced 2018-03-27 14:33 UTC by Report Bug Copy Issue Report `\Illuminate\Support\Facades\Auth::user()` is of type `object<Illuminate\Contra...h\Authenticatable>\|null`, but the function expects a `object<Xetaravel\Models\User>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
158
159		event(new RubiesPostWasSolvedEvent($post, Auth::user()));
		0 ignored issues – show Documentation introduced 2018-03-27 17:10 UTC by Report Bug Copy Issue Report `\Illuminate\Support\Facades\Auth::user()` is of type `object<Illuminate\Contra...h\Authenticatable>\|null`, but the function expects a `object<Xetaravel\Models\User>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
160
161		return redirect()
162		->route('discuss.conversation.show', ['slug' => $conversation->slug, 'id' => $conversation->getKey()])
163		->with('success', 'This reply as been marked as solved !');
164		}
165
166		/**
167		* Handle an edit action for the post.
168		*
169		* @param Request $request
170		* @param int $id The id of the post to edit.
171		*
172		* @return \Illuminate\Http\RedirectResponse
173		*/
174		public function edit(Request $request, int $id) : RedirectResponse
175		{
176		$post = DiscussPost::findOrFail($id);
177
178		if (!Auth::user()->can('update', $post)) {
		0 ignored issues – show Bug introduced 2017-07-03 11:07 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Illuminate\Contracts\Auth\Authenticatable` as the method `can()` does only exist in the following implementations of said interface: `Illuminate\Foundation\Auth\User`, `Tests\vendor\Models\User`, `Xetaravel\Models\User`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
179		return back()
180		->with('danger', 'You\'re not authorized to edit this message.');
181		}
182
183		DiscussPostValidator::edit($request->all())->validate();
184
185		$parser = new MentionParser($post);
186		$content = $parser->parse($request->input('content'));
		0 ignored issues – show Bug introduced 2018-03-13 16:26 UTC by Report Bug Copy Issue Report It seems like `$request->input('content')` targeting `Illuminate\Http\Concerns...ractsWithInput::input()` can also be of type `array`; however, `Xetaio\Mentions\Parser\MentionParser::parse()` does only seem to accept `null\|string`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
187
188		$post->content = $content;
189		$post->is_edited = true;
190		$post->edit_count++;
191		$post->edited_user_id = Auth::id();
192		$post->edited_at = Carbon::now();
193		$post->save();
194
195		return redirect()
196		->route('discuss.post.show', ['id' => $id])
197		->with('success', 'Your post has been edited successfully !');
198		}
199
200		/**
201		* Get the edit json template.
202		*
203		* @param int $id
204		*
205		* @return \Illuminate\Http\JsonResponse\|\Illuminate\View\View
		0 ignored issues – show Documentation introduced 2017-07-03 11:07 UTC by Report Bug Copy Issue Report Should the return type not be `\Symfony\Component\HttpFoundation\Response`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
206		*/
207		public function editTemplate(int $id)
208		{
209		$post = DiscussPost::find($id);
210
211		if (!Auth::user()->can('update', $post) \|\| !$post) {
		0 ignored issues – show Bug introduced 2017-07-03 11:07 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Illuminate\Contracts\Auth\Authenticatable` as the method `can()` does only exist in the following implementations of said interface: `Illuminate\Foundation\Auth\User`, `Tests\vendor\Models\User`, `Xetaravel\Models\User`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
212		return response()->json([
213		'error' => true,
214		'message' => 'You\'re not authorized to edit this message or this message has been deleted.'
215		]);
216		}
217
218		return response(
219		view('Discuss::post.editTemplate', ['post' => $post]),
		0 ignored issues – show Documentation introduced 2017-07-03 11:07 UTC by Report Bug Copy Issue Report `view('Discuss::post.edit...array('post' => $post))` is of type `object<Illuminate\View\V...Contracts\View\Factory>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
220		200,
221		['Content-Type' => 'application/json']
222		);
223		}
224		}
225

XetaIO / Xetaravel

Push — issue-37 ( 44d7c4...b086ff )

PostController::solved() B

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like