Xetaravel\Http\Controllers\Auth\SocialiteController

Complexity

Total Complexity

17

Size/Duplication

Total Lines	252
Duplicated Lines	3.57 %

Coupling/Cohesion

Components	1
Dependencies	15

Importance

Changes	1
Bugs	0	Features	0

9 Methods

Rating	Name	Duplication	Size	Complexity
A	showRegistrationForm()	0	4	1
A	register()	0	22	2
A	redirectToProvider()	0	6	1
B	handleProviderCallback()	0	37	6
A	login()	0	8	1
B	handleRegister()	0	36	3
A	createUser()	0	13	1
A	authenticated()	9	9	1
A	registered()	0	16	1

<?php
namespace Xetaravel\Http\Controllers\Auth;

use Exception;
use Illuminate\Auth\Events\Registered;
use Illuminate\Http\RedirectResponse;
use Illuminate\Http\Request;
use Illuminate\Foundation\Auth\RedirectsUsers;
use Illuminate\Support\Facades\Auth;
use Illuminate\Support\Str;
use Illuminate\View\View;
use Laravel\Socialite\Facades\Socialite;
use Laravel\Socialite\Two\User as ProviderUser;
use Symfony\Component\HttpFoundation\RedirectResponse as RedirectResponseSF;
use Xetaravel\Events\RegisterEvent;
use Xetaravel\Http\Controllers\Controller;
use Xetaravel\Models\User;
use Xetaravel\Models\Repositories\UserRepository;
use Xetaravel\Models\Role;
use Xetaravel\Models\Validators\UserValidator;

class SocialiteController extends Controller
{
    use RedirectsUsers;

    /**
     * Where to redirect users after login.
     *
     * @var string
     */
    protected $redirectTo = '/';

    /**
     * The driver used.
     *
     * @var string
     */
    protected $driver;

    /**
     * Show the registration form.
     *
     * @param \Illuminate\Http\Request $request The request object.
     * @param string $driver The driver used.
     *
     * @return \Illuminate\View\View
     */
    public function showRegistrationForm(Request $request, string $driver): View

The parameter $request is not used and could be removed.

The parameter $driver is not used and could be removed.

    {
        return view('Auth.socialite');
    }

    /**
     * Register an user that has been forced to modify his email or
     * username due to a conflit with the database.
     *
     * @param \Illuminate\Http\Request $request The request object.
     * @param string $driver The driver used.
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    public function register(Request $request, string $driver): RedirectResponse
    {
        $this->driver = $driver;
        $validator = UserValidator::createWithProvider($request->all());

        if ($validator->fails()) {
            return redirect()
                ->back()
                ->withErrors($validator)
                ->withInput($request->all());
        }
        $user = Socialite::driver($driver)->userFromToken($request->session()->get('socialite.token'));

        $user->nickname = $request->input('username');
        $user->email = $request->input('email');

        $user = $this->registered($user);

        $request->session()->forget('socialite');

The method forget() does not seem to exist on object<Symfony\Component\HttpFoundation\Session\SessionInterface>.

        return $this->login($request, $user);
    }

    /**
     * Redirect the user to the Provider authentication page.
     *
     * @param \Illuminate\Http\Request $request The request object.
     * @param string $driver The driver used.
     * @param string $type The type of callback. (Either `login` or `register`)
     *
     * @return \Symfony\Component\HttpFoundation\RedirectResponse
     */
    public function redirectToProvider(Request $request, string $driver, string $type): RedirectResponseSF

The parameter $request is not used and could be removed.

    {
        return Socialite::driver($driver)
                ->redirectUrl(route('auth.driver.type.callback', ['driver' => $driver, 'type' => $type]))
                ->redirect();
    }

    /**
     * Obtain the user information from the Provider and process to the
     * registration or login regarding to the type of callback.
     *
     * @param \Illuminate\Http\Request $request The request object.
     * @param string $driver The driver used.
     * @param string $type The type of callback. (Either `login` or `register`)
     *
     * @return \Illuminate\Http\Response

Should the return type not be RedirectResponse?

     */
    public function handleProviderCallback(Request $request, string $driver, string $type): RedirectResponse
    {
        $this->driver = $driver;

        try {
            $user = Socialite::driver($driver)->user();
        } catch (Exception $e) {
            $redirect = 'users.auth.login';

            if ($type == 'register') {
                $redirect = 'users.auth.register';
            }
            $driver = Str::title($driver);

            return redirect()
                ->route($redirect)
                ->with('danger', "An error occurred while getting your information from {$driver} !");
        }

        if ($type == 'register') {
            $user = $this->handleRegister($request, $user);

            if (!$user instanceof User) {
                return $user;
            }

            return $this->login($request, $user);
        }

        if (!$user = User::where($driver . '_id', $user->id)->first()) {
            return redirect()
                ->route('users.auth.login')
                ->with('danger', "This user is not registered, register it or try another login method.");
        }

        return $this->login($request, $user);
    }

    /**
     * Login the user and trigger the authenticated function.
     *
     * @param \Illuminate\Http\Request $request The request object.
     * @param \Xetaravel\Models\User $user The user to login.
     *
     * @return \Illuminate\Http\RedirectResponse
     */
    protected function login(Request $request, User $user): RedirectResponse
    {
        Auth::login($user, true);

        $this->authenticated($request, $user);

        return redirect()->intended($this->redirectPath());
    }

    /**
     * Handle the registration.
     *
     * @param \Illuminate\Http\Request $request The request object.
     * @param \Laravel\Socialite\Two\User $user The user to register.
     *
     * @return \Illuminate\Http\RedirectResponse|\Xetaravel\Models\User
     */
    protected function handleRegister(Request $request, ProviderUser $user)
    {
        $driver = $this->driver;

        if (User::where($driver . '_id', $user->id)->first()) {
            $driver = Str::title($driver);

            return redirect()
                ->route('users.auth.login')
                ->with('danger', "This {$driver} user is already registered !");
        }

        $validator = UserValidator::createWithProvider([
            'username' => $user->nickname,
            'email' => $user->email
        ]);

        if ($validator->fails()) {
            $request->session()->put('socialite', [

The method put() does not seem to exist on object<Symfony\Component\HttpFoundation\Session\SessionInterface>.

                'driver' => $driver,
                'token' => $user->token
            ]);

            return redirect()
                ->route('auth.driver.register', ['driver' => $driver])
                ->withErrors($validator)
                ->withInput([
                    'username' => $user->nickname,
                    'email' => $user->email
                ]);
        }

        $user = $this->registered($user);

        return $user;
    }

    /**
     * Create the user.
     *
     * @param \Laravel\Socialite\Two\User $user The user to create.
     *
     * @return \Xetaravel\Models\User
     */
    protected function createUser(ProviderUser $user)
    {
        return UserRepository::create(
            [
                'username' => $user->nickname,
                'email' => $user->email
            ],
            [
                $this->driver . '_id' => $user->id
            ],
            true
        );
    }

    /**
     * The user has been authenticated.
     *
     * @param \Illuminate\Http\Request $request The request object.
     * @param \Xetaravel\Models\User $user The user that has been logged in.
     *
     * @return void
     */
    protected function authenticated(Request $request, $user)

This method seems to be duplicated in your project.

    {
        event(new RegisterEvent($user));

        $request->session()->flash(

The method flash() does not seem to exist on object<Symfony\Component\HttpFoundation\Session\SessionInterface>.

            'success',
            'Welcome back <strong>' . e($user->username) . '</strong>! You\'re successfully connected !'
        );
    }

    /**
     * The user has been registered.
     *
     * @param \Laravel\Socialite\Two\User $user The user that has been registered.
     *
     * @return \Xetaravel\Models\User
     */
    protected function registered(ProviderUser $user): User
    {
        event(new Registered($user = $this->createUser($user)));

        $role = Role::where('slug', 'user')->first();
        $user->attachRole($role);

        $user->clearMediaCollection('avatar');
        $user->addMedia(resource_path('assets/images/avatar.png'))
            ->preservingOriginal()
            ->setName(substr(md5($user->username), 0, 10))
            ->setFileName(substr(md5($user->username), 0, 10) . '.png')
            ->toMediaCollection('avatar');

        return $user;
    }
}