Issues in TfaController.php (master) - Issues in master - XetaIO/Xeta - Measure and Improve Code Quality continuously with Scrutinizer

Issues (685)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Controller/TfaController.php (33 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace App\Controller;

use App\Event\Logs;
use Cake\Core\Configure;
use Cake\Event\Event;
use Endroid\QrCode\QrCode;
use RobThree\Auth\TwoFactorAuth;

class TfaController extends AppController
{
    /**
     * Display the index action.
     *
     * @return void
     */
    public function index()
    {
    }

    /**
     * Display an intro to the Two-factor Authentication.
     *
     * @return \Cake\Network\Response|void
     */
    public function intro()
    {
        $this->loadModel('Users');

        $user = $this->Users
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->find()
            ->where([
                'Users.id' => $this->Auth->user('id')
            ])
            ->select([
                'id',
                'two_factor_auth_enabled'
            ])
            ->first();

        if ($user->two_factor_auth_enabled == true) {

            $this->Flash->error(__('You have already set-up the Two-factor authentication.'));

            return $this->redirect(['controller' => 'users', 'action' => 'security']);
        }
    }

    /**
     * Configure the Two-factor Authentication.
     *
     * @return \Cake\Network\Response|void
     */
    public function configure()
    {
        $this->loadModel('Users');

        $user = $this->Users
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->find()
            ->contain([
                'UsersTwoFactorAuth'
            ])
            ->where([
                'Users.id' => $this->Auth->user('id')
            ])
            ->select([
                'Users.id',
                'Users.username',
                'Users.two_factor_auth_enabled',
                'UsersTwoFactorAuth.id',
                'UsersTwoFactorAuth.user_id',
                'UsersTwoFactorAuth.secret',
                'UsersTwoFactorAuth.username'
            ])
            ->first();

        if ($user->two_factor_auth_enabled == true) {

            $this->Flash->error(__('You have already set-up the Two-factor authentication.'));

            return $this->redirect(['controller' => 'users', 'action' => 'security']);
        }

        $tfa = new TwoFactorAuth('Xeta');

        if (!is_null($user->users_two_factor_auth)) {
            $secret = $user->users_two_factor_auth->secret;
        } else {
            $this->loadModel('UsersTwoFactorAuth');
            $secret = $tfa->createSecret();

            $data = [
                'user_id' => $this->Auth->user('id'),
                'secret' => $secret,
                'username' => $user->username
            ];

            $entity = $this->UsersTwoFactorAuth->newEntity($data);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $this->UsersTwoFactorAuth->save($entity);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }

        $imgSrc = $tfa->getQRCodeImageAsDataUri($user->username, $secret);
        $secretCode = chunk_split($secret, 4, ' ');

        $this->set(compact('imgSrc', 'secretCode'));
    }

    /**
     * Enable the Two-factor Authentication.
     *
     * @return \Cake\Network\Response|void
     */
    public function enable()
    {
        if (!$this->request->is('post')) {
            return $this->redirect(['action' => 'configure']);
        }

        $this->loadModel('UsersTwoFactorAuth');

        $userTfa = $this->UsersTwoFactorAuth
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->find()
            ->where([
                'UsersTwoFactorAuth.user_id' => $this->Auth->user('id')
            ])
            ->first();

        if (is_null($userTfa) || empty($userTfa->secret) || is_null($this->request->getData('code'))) {
            $this->Flash->error(__('Two-factor secret verification failed. Please verify your secret and try again.'));

            return $this->redirect(['action' => 'configure']);
        }

        $tfa = new TwoFactorAuth('Xeta');

        if ($tfa->verifyCode($userTfa->secret, $this->request->getData('code')) === true && $this->request->getData('code') != $userTfa->current_code) {
            $this->loadModel('Users');

            $user = $this->Users
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                ->find()
                ->where([
                    'Users.id' => $this->Auth->user('id')
                ])
                ->select([
                    'id',
                    'username',
                    'two_factor_auth_enabled'
                ])
                ->first();

            $user->two_factor_auth_enabled = true;
            $this->Users->save($user);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

            $data = [
                'session' => $this->request->clientIp() . $this->request->header('User-Agent') . gethostbyaddr($this->request->clientIp()),

                'current_code' => $this->request->getData('code'),
                'recovery_code' => $this->_generateNewRecoveryCode($userTfa->username)
            ];

            $this->UsersTwoFactorAuth->patchEntity($userTfa, $data);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $this->UsersTwoFactorAuth->save($userTfa);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

            //Logs Event.
            $this->eventManager()->attach(new Logs());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $event = new Event('Log.User', $this, [
                'user_id' => $user->id,
                'username' => $user->username,
                'user_ip' => $this->request->clientIp(),
                'user_agent' => $this->request->header('User-Agent'),

                'action' => '2FA.enabled'
            ]);
            $this->eventManager()->dispatch($event);

            $this->Flash->success(__('Two-factor authentication successfully enabled !'));

            $this->set(compact('user', 'userTfa'));
        } else {
            $this->Flash->error(__('Two-factor secret verification failed. Please verify your secret and try again.'));

            return $this->redirect(['action' => 'configure']);
        }
    }

    /**
     * Disable the Two-factor Authentication.
     *
     * @return \Cake\Network\Response
     */
    public function disable()
    {
        $this->loadModel('Users');

        $user = $this->Users
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->find()
            ->where([
                'Users.id' => $this->Auth->user('id')
            ])
            ->select([
                'id',
                'username',
                'two_factor_auth_enabled'
            ])
            ->first();

        if (is_null($user) || $user->two_factor_auth_enabled == false) {

            $this->Flash->error(__('The Two-factor authentication is not enabled !'));

            return $this->redirect(['controller' => 'users', 'action' => 'security']);
        }

        $user->two_factor_auth_enabled = false;
        $this->Users->save($user);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $this->loadModel('UsersTwoFactorAuth');

        $userTfa = $this->UsersTwoFactorAuth
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->find()
            ->where([
                'UsersTwoFactorAuth.user_id' => $this->Auth->user('id')
            ])
            ->first();

        $this->UsersTwoFactorAuth->delete($userTfa);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        //Logs Event.
        $this->eventManager()->attach(new Logs());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $event = new Event('Log.User', $this, [
            'user_id' => $user->id,
            'username' => $user->username,
            'user_ip' => $this->request->clientIp(),
            'user_agent' => $this->request->header('User-Agent'),

            'action' => '2FA.disabled'
        ]);
        $this->eventManager()->dispatch($event);

        $this->Flash->success(__('The Two-factor authentication has been disabled !'));

        return $this->redirect(['controller' => 'users', 'action' => 'security']);
    }

    /**
     * Display the recovery code and the status of the code.
     *
     * @return \Cake\Network\Response|void
     */
    public function recoveryCode()
    {
        $this->loadModel('Users');

        $user = $this->Users
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->find()
            ->contain([
                'UsersTwoFactorAuth'
            ])
            ->where([
                'Users.id' => $this->Auth->user('id')
            ])
            ->select([
                'Users.id',
                'Users.two_factor_auth_enabled',
                'UsersTwoFactorAuth.user_id',
                'UsersTwoFactorAuth.recovery_code',
                'UsersTwoFactorAuth.recovery_code_used'
            ])
            ->first();

        if (is_null($user) || $user->two_factor_auth_enabled == false) {

            $this->Flash->error(__('The Two-factor authentication is not enabled !'));

            return $this->redirect(['controller' => 'users', 'action' => 'security']);
        }

        $this->set(compact('user'));
    }

    /**
     * Generate a new recovery code.
     *
     * @return \Cake\Network\Response
     */
    public function generateRecoveryCode()
    {
        $this->loadModel('Users');
        $this->loadModel('UsersTwoFactorAuth');

        $user = $this->Users
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->find()
            ->where([
                'Users.id' => $this->Auth->user('id')
            ])
            ->select([
                'Users.id',
                'Users.username',
                'Users.two_factor_auth_enabled'
            ])
            ->first();

        if (is_null($user) || $user->two_factor_auth_enabled == false) {

            $this->Flash->error(__('The Two-factor authentication is not enabled !'));

            return $this->redirect(['controller' => 'users', 'action' => 'security']);
        }

        $tfa = $this->UsersTwoFactorAuth
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->find()
            ->where([
                'UsersTwoFactorAuth.user_id' => $this->Auth->user('id')
            ])
            ->select([
                'UsersTwoFactorAuth.id',
                'UsersTwoFactorAuth.user_id',
                'UsersTwoFactorAuth.username',
                'UsersTwoFactorAuth.recovery_code',
                'UsersTwoFactorAuth.recovery_code_used'
            ])
            ->first();

        $data = [
            'recovery_code' => $this->_generateNewRecoveryCode($tfa->username),
            'recovery_code_used' => false
        ];

        $this->UsersTwoFactorAuth->patchEntity($tfa, $data);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        if ($this->UsersTwoFactorAuth->save($tfa)) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            //Logs Event.
            $this->eventManager()->attach(new Logs());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $event = new Event('Log.User', $this, [
                'user_id' => $user->id,
                'username' => $user->username,
                'user_ip' => $this->request->clientIp(),
                'user_agent' => $this->request->header('User-Agent'),

                'action' => '2FA.recovery_code.regenerate'
            ]);
            $this->eventManager()->dispatch($event);

            $this->Flash->success(__('New two-factor recovery code successfully generated.'));

            return $this->redirect(['action' => 'recoveryCode']);
        } else {
            $this->Flash->error(__('Error to generate two-factor recovery code.'));

            return $this->redirect(['action' => 'recoveryCode']);
        }
    }

    /**
     * Function to generate a recovery code.
     *
     * Generate a code into this format :
     * XXXX-XXXX-XXXX-XXXX
     *
     * @param string $user The username of the user.
     *
     * @return string
     */
    protected function _generateNewRecoveryCode($user)
    {
        $code = md5(rand() . uniqid() . time() . $user);

        //Split the code into smaller chunks
        $code = chunk_split(substr($code, 0, 16), 4, '-');

        //Remove the last string added by chunk_split().
        $code = substr($code, 0, -1);

        return $code;
    }
}


XetaIO / Xeta

Issues (685)

Security Analysis no request data

src/Controller/TfaController.php (33 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like