XetaIO / Xeta

src/Controller/ContactController.php

<?php
namespace App\Controller;

use Cake\Core\Configure;
use Cake\Event\Event;
use Cake\Mailer\MailerAwareTrait;
use Cake\Validation\Validator;

class ContactController extends AppController
{
    use MailerAwareTrait;

    /**
     * Beforefilter.
     *
     * @param Event $event The beforeFilter event that was fired.
     *
     * @return void
     */
    public function beforeFilter(Event $event)
    {
        parent::beforeFilter($event);

        $this->Auth->allow(['index']);
    }

    /**
     * Contact page.
     *
     * @return \Cake\Network\Response|void
     */
    public function index()
    {
        $contact = [
            'schema' => [
                'name' => [
                    'type' => 'string',
                    'length' => 100
                ],
                'email' => [
                    'type' => 'email',
                    'length' => 100
                ],
                'subject' => [
                    'type' => 'string',
                    'length' => 255
                ],
                'message' => [
                    'type' => 'string'
                ]
            ],
            'required' => [
                'name' => 1,
                'email' => 1,
                'message' => 1
            ]
        ];

        if ($this->request->is('post')) {
            $validator = new Validator();
            $validator
                ->notEmpty('email', __('You need to put your E-mail.'))
                ->add('email', 'validFormat', [
                    'rule' => 'email',
                    'message' => __("You must specify a valid E-mail address.")
                ])
                ->notEmpty('name', __('You need to put your name.'))
                ->notEmpty('message', __("You need to give a message."))
                ->add('message', 'minLength', [
                    'rule' => ['minLength', 10],
                    'message' => __("Your message can not contain less than {0} characters.", 10)
                ]);

            $contact['errors'] = $validator->errors($this->request->getParsedBody());

It seems like $this->request->getParsedBody() targeting Cake\Http\ServerRequest::getParsedBody() can also be of type null or object; however, Cake\Validation\Validator::errors() does only seem to accept array, maybe add an additional type check?

            if (empty($contact['errors'])) {
                $viewVars = [
                    'ip' => $this->request->clientIp()
                ];

                $viewVars = array_merge($this->request->getParsedBody(), $viewVars);

                $this->getMailer('Contact')->send('contact', [$viewVars]);

                $this->Flash->success(__("Your message has been sent successfully, you will get a response shortly !"));

                return $this->redirect(['controller' => 'pages', 'action' => 'home']);
            }
        }

        $this->set(compact('contact'));
    }
}