Issues in BlogController.php (master) - Issues in master - XetaIO/Xeta - Measure and Improve Code Quality continuously with Scrutinizer

Issues (685)

Security Analysis no request data

Cross-Site Scripting
Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.
File Exposure
File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.
File Manipulation
File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.
Object Injection
Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.
Code Injection
Code Injection enables an attacker to execute arbitrary code on the server.
Response Splitting
Response Splitting can be used to send arbitrary responses.
File Inclusion
File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.
Command Injection
Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.
SQL Injection
SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.
XPath Injection
XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.
LDAP Injection
LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.
Header Injection
Other Vulnerability
This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.
Regex Injection
Regex Injection enables an attacker to execute arbitrary code in your PHP process.
XML Injection
XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.
Variable Injection
Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.
Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.
src/Controller/BlogController.php (55 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more
<?php
namespace App\Controller;

use App\Event\Badges;
use App\Event\Statistics;
use Cake\Core\Configure;
use Cake\Event\Event;
use Cake\Network\Exception\NotFoundException;
use Cake\Routing\Router;

class BlogController extends AppController
{

    /**
     * Initialization hook method.
     *
     * @return void
     */
    public function initialize()
    {
        parent::initialize();

        $this->loadComponent('RequestHandler');
    }

    /**
     * BeforeFilter handle.
     *
     * @param Event $event The beforeFilter event that was fired.
     *
     * @return void
     */
    public function beforeFilter(Event $event)
    {
        parent::beforeFilter($event);

        $this->Auth->allow(['index', 'category', 'article', 'go', 'archive', 'search']);
    }

    /**
     * Display all Articles.
     *
     * @return void
     */
    public function index()

    {
        $this->loadModel('BlogArticles');
        $this->paginate = [
            'maxLimit' => Configure::read('Blog.article_per_page')
        ];

        $articles = $this->BlogArticles
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->find()
            ->contain([
                'BlogCategories',
                'Users' => function ($q) {
                    return $q->find('short');
                },
                'Polls',
                'BlogAttachments'
            ])
            ->order([
                'BlogArticles.created' => 'desc'
            ])
            ->where([
                'BlogArticles.is_display' => 1
            ]);

        $articles = $this->paginate($articles);

        $this->set(compact('articles'));
    }

    /**
     * Display a specific category with all its articles.
     *
     * @return \Cake\Network\Response|void
     */
    public function category()
    {
        $this->loadModel('BlogCategories');

        $category = $this->BlogCategories
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->find()
            ->where([
                'BlogCategories.id' => $this->request->id
            ])
            ->contain([
                'BlogArticles'
            ])
            ->first();

        //Check if the category is found.
        if (empty($category)) {
            $this->Flash->error(__('This category doesn\'t exist or has been deleted.'));

            return $this->redirect(['action' => 'index']);
        }

        //Paginate all Articles.
        $this->loadModel('BlogArticles');
        $this->paginate = [
            'maxLimit' => Configure::read('Blog.article_per_page')
        ];

        $articles = $this->BlogArticles
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->find()
            ->contain([
                'Users' => function ($q) {
                    return $q->find('short');
                },
                'Polls',
                'BlogAttachments'
            ])
            ->where([
                'BlogArticles.category_id' => $category->id,
                'BlogArticles.is_display' => 1
            ])
            ->order([
                'BlogArticles.created' => 'desc'
            ]);

        $articles = $this->paginate($articles);

        $this->set(compact('category', 'articles'));
    }

    /**
     * Display a specific article.
     *
     * @return \Cake\Network\Response|void
     */
    public function article()
    {
        $this->loadModel('BlogArticles');

        $article = $this->BlogArticles
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->find()
            ->where([
                'BlogArticles.id' => $this->request->id,
                'BlogArticles.is_display' => 1
            ])
            ->contain([
                'BlogCategories',
                'BlogAttachments',
                'Users' => function ($q) {
                    return $q->find('full');
                },
                'Polls',
                'Polls.PollsAnswers',
                'Polls.PollsAnswers.Polls' => function ($q) {
                    return $q->select(['id', 'user_count']);
                },
                'Polls.PollsUsers'
            ])
            ->first();

        //Check if the article is found.
        if (is_null($article)) {
            $this->Flash->error(__('This article doesn\'t exist or has been deleted.'));

            return $this->redirect(['action' => 'index']);
        }

        $this->loadModel('BlogArticlesComments');

        //A comment has been posted.
        if ($this->request->is('post')) {
            //Check if the user is connected.
            if (!$this->Auth->user()) {
                $this->Flash->error(__('You must be connected to post a comment.'));

                return $this->redirect([
                    '_name' => 'blog-article',
                    'slug' => h($article->title),
                    'id' => $article->id
                ]);
            }

            $this->request = $this->request
                ->withData('article_id', $article->id)
                ->withData('user_id', $this->Auth->user('id'));

            $newComment = $this->BlogArticlesComments->newEntity($this->request->getParsedBody(), ['validate' => 'create']);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

            //Attach Event.
            $this->BlogArticlesComments->eventManager()->attach(new Badges($this));
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

            if ($insertComment = $this->BlogArticlesComments->save($newComment)) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $this->eventManager()->attach(new Statistics());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                $event = new Event('Model.BlogArticlesComments.new');
                $this->eventManager()->dispatch($event);

                $this->Flash->success(__('Your comment has been posted successfully !'));
                //Redirect the user to the last page of the article.
                $this->redirect([
                    'action' => 'go',
                    $insertComment->id
                ]);
            }
        }

        $this->loadModel('PollsUsers');
        $hasVoted = $this->PollsUsers
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->find()
            ->contain([
                'Polls' => function ($q) {
                    return $q->select(['id']);
                },
                'PollsAnswers'
            ])
            ->where([
                'PollsUsers.user_id' => $this->Auth->user('id'),
                'Polls.id' => $article->poll ? $article->poll->id : null
            ])
            ->first();

        //Paginate all comments related to the article.
        $this->paginate = [
            'maxLimit' => Configure::read('Blog.comment_per_page')
        ];

        $comments = $this->BlogArticlesComments
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->find()
            ->where([
                'BlogArticlesComments.article_id' => $article->id
            ])
            ->contain([
                'Users' => function ($q) {
                    return $q->find('medium');
                }
            ])
            ->order([
                'BlogArticlesComments.created' => 'asc'
            ]);

        $comments = $this->paginate($comments);

        //Select the like for the current auth user.
        $this->loadModel('BlogArticlesLikes');
        $like = $this->BlogArticlesLikes
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->find()
            ->where([
                'user_id' => ($this->Auth->user()) ? $this->Auth->user('id') : null,
                'article_id' => $article->id
            ])
            ->first();

        //Build the newEntity for the comment form.
        $formComments = $this->BlogArticlesComments->newEntity();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        //Search related articles
        $keywords = preg_split("/([\s,\W])+/", $article->title);

        $query = $this->BlogArticles->find();
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $query
            ->contain([
                'BlogCategories',
            ]);

        foreach ($keywords as $keyword) {
            $query->orWhere(function ($exp, $q) use ($keyword) {

                return $exp->like('BlogArticles.title', '%' . $keyword . '%');
            });
        }

        $articles = $query->andWhere([
            'BlogArticles.is_display' => 1,
            'BlogArticles.id !=' => $article->id
        ]);

        //Current user.
        $this->loadModel('Users');
        $currentUser = $this->Users
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->find()
            ->contain([
                'Groups' => function ($q) {
                    return $q->select(['id', 'is_staff']);
                }
            ])
            ->where([
                'Users.id' => $this->Auth->user('id')
            ])
            ->select(['id', 'group_id'])
            ->first();

        $this->set(compact('article', 'formComments', 'comments', 'like', 'articles', 'currentUser', 'hasVoted'));
    }

    /**
     * Quote a message.
     *
     * @param int $articleId Id of the article where is the message to quote.
     * @param int $commentId Id of the message to quote.
     *
     * @throws \Cake\Network\Exception\NotFoundException
     *
     * @return mixed
     */
    public function quote($articleId = null, $commentId = null)
    {
        if (!$this->request->is('ajax')) {
            throw new NotFoundException();
        }

        $this->loadModel('BlogArticlesComments');

        $comment = $this->BlogArticlesComments
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->find()
            ->where([
                'BlogArticlesComments.article_id' => $articleId,
                'BlogArticlesComments.id' => $commentId
            ])
            ->contain([
                'Users' => function ($q) {
                        return $q->find('short');
                }
            ])
            ->first();

        $json = [];

        if (!is_null($comment)) {
            $comment->toArray();

            $url = Router::url(['action' => 'go', $comment->id]);
            $text = __("has said :");

            //Build the quote.
            $json['comment'] = <<<EOT
<div>
     <div>
        <a href="{$url}">
            <strong>{$comment->user->full_name} {$text}</strong>
        </a>
    </div>
    <blockquote>
        $comment->content
    </blockquote>
</div><p>&nbsp;</p><p>&nbsp;</p>
EOT;

            $json['error'] = false;

            $this->set(compact('json'));
        } else {
            $json['comment'] = __("This comment doesn't exist.");
            $json['error'] = true;

            $this->set(compact('json'));
        }

        //Send response in JSON.
        $this->set('_serialize', 'json');
    }

    /**
     * Redirect an user to an article, page and comment.
     *
     * @param int $commentId Id of the comment.
     *
     * @return \Cake\Network\Response
     */
    public function go($commentId = null)

    {
        $this->loadModel('BlogArticlesComments');

        $comment = $this->BlogArticlesComments
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->find()
            ->contain([
                'BlogArticles'
            ])
            ->where([
                'BlogArticlesComments.id' => $commentId
            ])
            ->first();

        if (is_null($comment)) {
            $this->Flash->error(__("This comment doesn't exist or has been deleted."));

            return $this->redirect(['action' => 'index']);
        }

        $comment->toArray();

        //Count the number of message before this message.
        $messagesBefore = $this->BlogArticlesComments
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->find()
            ->where([
                'BlogArticlesComments.article_id' => $comment->article_id,
                'BlogArticlesComments.created <' => $comment->created
            ])
            ->count();

        //Get the number of messages per page.
        $messagesPerPage = Configure::read('Blog.comment_per_page');

        //Calculate the page.
        $page = floor($messagesBefore / $messagesPerPage) + 1;

        $page = ($page > 1) ? $page : 1;

        //Redirect the user.
        return $this->redirect([
            '_name' => 'blog-article',
            'slug' => $comment->blog_article->title,
            'id' => $comment->blog_article->id,
            '?' => ['page' => $page],
            '#' => 'comment-' . $commentId
        ]);
    }

    /**
     * Get all articles by a date formatted to "m-Y".
     *
     * @param string $date The date of the archive.
     *
     * @return void
     */
    public function archive($date = null)

    {
        $this->loadModel('BlogArticles');

        $this->paginate = [
            'maxLimit' => Configure::read('Blog.article_per_page')
        ];

        $archives = $this->BlogArticles
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->find()
            ->where([
                'DATE_FORMAT(BlogArticles.created,\'%m-%Y\')' => $date,
                'BlogArticles.is_display' => 1
            ])
            ->contain([
                'BlogCategories',
                'Users' => function ($q) {
                        return $q->find('short');
                },
                'Polls',
                'BlogAttachments'
            ])
            ->order([
                'BlogArticles.created' => 'desc'
            ]);

        $articles = $this->paginate($archives);

        $this->set(compact('articles', 'date'));
    }

    /**
     * Search articles.
     *
     * @return void
     */
    public function search()
    {
        $this->loadModel('BlogArticles');

        //Check the keyword to search. (For pagination)
        if (!empty($this->request->getData('search'))) {

            $keyword = $this->request->getData('search');
            $this->request->session()->write('Search.Blog.Keyword', $keyword);
        } else {
            if ($this->request->session()->read('Search.Blog.Keyword')) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
                $keyword = $this->request->session()->read('Search.Blog.Keyword');
            } else {
                $keyword = '';
            }
        }

        //Pagination
        $this->paginate = [
            'maxLimit' => Configure::read('Blog.article_per_page')
        ];

        $articles = $this->BlogArticles
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->find()
            ->contain([
                'Users' => function ($q) {
                    return $q->find('short');
                },
                'Polls',
                'BlogAttachments'
            ])
            ->where([
                'BlogArticles.is_display' => 1
            ])
            ->andWhere(function ($q) use ($keyword) {
                return $q
                    ->like('title', "%$keyword%");
            })
            ->order([
                'BlogArticles.created' => 'desc'
            ]);

        $articles = $this->paginate($articles);

        $this->set(compact('articles', 'keyword'));
    }

    /**
     * Like an article.
     *
     * @param int $articleId Id of the article to like.
     *
     * @throws \Cake\Network\Exception\NotFoundException When it's not an AJAX request.
     *
     * @return void
     */
    public function articleLike($articleId = null)
    {
        if (!$this->request->is('ajax')) {
            throw new NotFoundException();
        }

        //Check if the user hasn't already liked this article.
        $this->loadModel('BlogArticlesLikes');
        $checkLike = $this->BlogArticlesLikes
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->find()
            ->where([
                'BlogArticlesLikes.user_id' => $this->Auth->user('id'),
                'BlogArticlesLikes.article_id' => $articleId
            ])
            ->first();

        $json = [];

        if (!is_null($checkLike)) {

            $json['message'] = __('You already like this article !');
            $json['error'] = true;

            $this->set(compact('json'));

            $this->set('_serialize', 'json');

            return;
        }

        //Check if the article exist.
        $this->loadModel('BlogArticles');
        $checkArticle = $this->BlogArticles
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->find()
            ->where([
                'BlogArticles.id' => $articleId,
                'BlogArticles.is_display' => 1
            ])
            ->first();

        if (is_null($checkArticle)) {

            $json['message'] = __("This article doesn't exist !");
            $json['error'] = true;

            $this->set(compact('json'));
            $this->set('_serialize', 'json');

            return;
        }

        //Prepare data to be saved.
        $data = [];
        $data['BlogArticlesLikes']['user_id'] = $this->Auth->user('id');
        $data['BlogArticlesLikes']['article_id'] = $articleId;

        $like = $this->BlogArticlesLikes->newEntity($data);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        if ($this->BlogArticlesLikes->save($like)) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            //Update the Statistics
            $this->eventManager()->attach(new Statistics());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $event = new Event('Model.BlogArticlesLikes.new');
            $this->eventManager()->dispatch($event);

            $json['message'] = __('Thanks for {0} this article ! ', "<i class='fa fa-heart text-danger'></i>");
            $json['title'] = __('You {0} this article.', "<i class='fa fa-heart text-danger'></i>");
            $json['url'] = Router::url(
                [
                    'action' => 'articleUnlike',
                    $articleId
                ]
            );
            $json['error'] = false;
        } else {
            $json['message'] = __('An error occurred, please try again later.');
            $json['error'] = true;
        }

        $this->set(compact('json'));

        $this->set('_serialize', 'json');
    }

    /**
     * Unlike an article.
     *
     * @param int|null $articleId Id of the article to like.
     *
     * @throws \Cake\Network\Exception\NotFoundException When it's not an AJAX request.
     *
     * @return void
     */
    public function articleUnlike($articleId = null)
    {
        if (!$this->request->is('ajax')) {
            throw new NotFoundException();
        }

        //Check if the user like this article.
        $this->loadModel('BlogArticlesLikes');
        $like = $this->BlogArticlesLikes
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->find()
            ->contain([
                'BlogArticles'
            ])
            ->where([
                'BlogArticlesLikes.user_id' => $this->Auth->user('id'),
                'BlogArticlesLikes.article_id' => $articleId,
                'BlogArticles.is_display' => 1
            ])
            ->first();

        $json = [];

        if (is_null($like)) {

            $json['message'] = __("You don't like this article !");
            $json['error'] = true;

            $this->set(compact('json'));

            $this->set('_serialize', 'json');

            return;
        }

        if ($this->BlogArticlesLikes->delete($like)) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            //Update the Statistics
            $this->eventManager()->attach(new Statistics());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $event = new Event('Model.BlogArticlesLikes.new');
            $this->eventManager()->dispatch($event);

            $json['url'] = Router::url([
                                'action' => 'articleLike',
                                $articleId
                            ]);
            $json['title'] = __('Like {0}', "<i class='fa fa-heart text-danger'></i>");
            $json['error'] = false;
        } else {
            $json['message'] = __('An error occurred, please try again later.');
            $json['error'] = true;
        }

        $this->set(compact('json'));

        $this->set('_serialize', 'json');
    }

    /**
     * Delete a comment.
     *
     * @param int $id Id of the comment to delete.
     *
     * @return \Cake\Network\Response
     */
    public function deleteComment($id = null)
    {
        $this->loadModel('BlogArticlesComments');

        $comment = $this->BlogArticlesComments
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->find()
            ->contain([
                'BlogArticles'
            ])
            ->where([
                'BlogArticlesComments.id' => $id
            ])
            ->first();

        if (is_null($comment)) {
            $this->Flash->error(__("This comment doesn't exist or has been deleted !"));

            return $this->redirect($this->referer());

        }

        //Current user.
        $this->loadModel('Users');
        $currentUser = $this->Users
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->find()
            ->contain([
                'Groups' => function ($q) {
                    return $q->select(['id', 'is_staff']);
                }
            ])
            ->where([
                'Users.id' => $this->Auth->user('id')
            ])
            ->select(['id', 'group_id'])
            ->first();

        if ($comment->user_id != $this->Auth->user('id') && !$currentUser->group->is_staff) {
            $this->Flash->error(__("You don't have the authorization to delete this comment !"));

            return $this->redirect($this->referer());

        }

        if ($this->BlogArticlesComments->delete($comment)) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $this->eventManager()->attach(new Statistics());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $event = new Event('Model.BlogArticlesComments.new');
            $this->eventManager()->dispatch($event);

            $this->Flash->success(__("This comment has been deleted successfully !"));
        }

        return $this->redirect(['_name' => 'blog-article', 'slug' => $comment->blog_article->title, 'id' => $comment->blog_article->id, '?' => ['page' => $comment->blog_article->last_page]]);
    }

    /**
     * Get the form to edit a comment.
     *
     * @throws \Cake\Network\Exception\NotFoundException When it's not an AJAX request.
     *
     * @return void
     */
    public function getEditComment()
    {
        if (!$this->request->is('ajax')) {
            throw new NotFoundException();
        }

        $this->loadModel('BlogArticlesComments');
        $comment = $this->BlogArticlesComments
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->find()
            ->where([
                'BlogArticlesComments.id' => $this->request->getData('id')
            ])
            ->first();

        $json = [
            'error' => false,
            'errorMessage' => ''
        ];

        if (is_null($comment)) {

            $json['error'] = true;
            $json['errorMessage'] = __("This comment doesn't exist or has been deleted !");

            $this->set(compact('json'));

            return;
        }

        //Current user.
        $this->loadModel('Users');
        $currentUser = $this->Users
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->find()
            ->contain([
                'Groups' => function ($q) {
                    return $q->select(['id', 'is_staff']);
                }
            ])
            ->where([
                'Users.id' => $this->Auth->user('id')
            ])
            ->select(['id', 'group_id'])
            ->first();

        if ($comment->user_id != $this->Auth->user('id') && !$currentUser->group->is_staff) {
            $json['error'] = true;
            $json['errorMessage'] = __("You don't have the authorization to edit this comment !");

            $this->set(compact('json'));

            return;
        }

        $this->set(compact('json', 'comment'));
    }

    /**
     * Edit a comment.
     *
     * @param int $id Id of the comment.
     *
     * @throws \Cake\Network\Exception\NotFoundException When it's not a POST request.
     *
     * @return \Cake\Network\Response
     */
    public function editComment($id = null)
    {
        if (!$this->request->is('post')) {
            throw new NotFoundException();
        }

        $this->loadModel('BlogArticlesComments');

        $comment = $this->BlogArticlesComments
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->find()
            ->contain([
                'BlogArticles'
            ])
            ->where([
                'BlogArticlesComments.id' => $id
            ])
            ->first();

        if (is_null($comment)) {
            $this->Flash->error(__("This comment doesn't exist or has been deleted !"));

            return $this->redirect($this->referer());

        }

        //Current user.
        $this->loadModel('Users');
        $currentUser = $this->Users
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->find()
            ->contain([
                'Groups' => function ($q) {
                    return $q->select(['id', 'is_staff']);
                }
            ])
            ->where([
                'Users.id' => $this->Auth->user('id')
            ])
            ->select(['id', 'group_id'])
            ->first();

        if ($comment->user_id != $this->Auth->user('id') && !$currentUser->group->is_staff) {
            $this->Flash->error(__("You don't have the authorization to edit this comment !"));

            return $this->redirect($this->referer());

        }

        $this->BlogArticlesComments->patchEntity($comment, $this->request->getParsedBody());
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        if ($this->BlogArticlesComments->save($comment)) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $this->Flash->success(__("This comment has been edited successfully !"));
        }

        return $this->redirect(['action' => 'go', $comment->id]);
    }
}

XetaIO / Xeta

Issues (685)

Security Analysis no request data

src/Controller/BlogController.php (55 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like
