GroupsController - Code Metrics - Inspection of "Reverse the "Refactoring the Internationalization"" - XetaIO/Xeta - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — v3 ( 320a43...25ab4d )

by Fèvre

created 2016-11-02 09:54 UTC

GroupsController A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	44
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	5

Importance

Changes	2
Bugs	1	Features	0

Metric	Value
wmc	2
lcom	2
cbo	5
dl	0
loc	44
rs	10
c	2
b	1
f	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	beforeFilter()	0	6	1
A	view()	0	21	1

<?php
namespace App\Controller;

use Cake\Core\Configure;
use Cake\Event\Event;

class GroupsController extends AppController
{

    /**
     * BeforeFilter handle.
     *
     * @param Event $event The beforeFilter event that was fired.
     *
     * @return void
     */
    public function beforeFilter(Event $event)
    {
        parent::beforeFilter($event);

        $this->Auth->allow(['view']);
    }

    /**
     * Display members by a group.
     *
     * @return void
     */
    public function view()
    {
        $this->paginate = [
            'maxLimit' => Configure::read('Group.user_per_page')
        ];

        $this->Users = $this->loadModel('Users');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $users = $this->Users
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->find()
            ->contain([
                'Groups'
            ])
            ->where([
                'Groups.id' => $this->request->id
            ]);

        $users = $this->paginate($users);

        $this->set(compact('users'));
    }
}


1			<?php
2			namespace App\Controller;
3
4			use Cake\Core\Configure;
5			use Cake\Event\Event;
6
7			class GroupsController extends AppController
8			{
9
10			/**
11			* BeforeFilter handle.
12			*
13			* @param Event $event The beforeFilter event that was fired.
14			*
15			* @return void
16			*/
17			public function beforeFilter(Event $event)
18			{
19			parent::beforeFilter($event);
20
21			$this->Auth->allow(['view']);
22			}
23
24			/**
25			* Display members by a group.
26			*
27			* @return void
28			*/
29			public function view()
30			{
31			$this->paginate = [
32			'maxLimit' => Configure::read('Group.user_per_page')
33			];
34
35			$this->Users = $this->loadModel('Users');
			0 ignored issues – show Documentation introduced 2016-10-25 05:06 UTC by Report Bug Copy Issue Report The property `Users` does not exist on `object<App\Controller\GroupsController>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
36
37			$users = $this->Users
			0 ignored issues – show Documentation introduced 2016-10-25 05:06 UTC by Report Bug Copy Issue Report The property `Users` does not exist on `object<App\Controller\GroupsController>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
38			->find()
39			->contain([
40			'Groups'
41			])
42			->where([
43			'Groups.id' => $this->request->id
44			]);
45
46			$users = $this->paginate($users);
47
48			$this->set(compact('users'));
49			}
50			}
51

XetaIO / Xeta

Push — v3 ( 320a43...25ab4d )

GroupsController A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

Duplication Side-by-Side

Filter issues like