WhoopsErrorHandler::_displayError() - Code Metrics - Inspection of "Prepare the V3" - XetaIO/Xeta - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#178)

by Fèvre

created 2016-10-30 17:34 UTC

WhoopsErrorHandler::_displayError() A

↳ Parent: WhoopsErrorHandler

Complexity

Conditions	2
Paths	2

Size

Total Lines	10
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	10
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	7
nc	2
nop	2

<?php

namespace App\Error;

use Cake\Core\Configure;
use Cake\Error\ErrorHandler;
use Whoops\Handler\PrettyPageHandler;
use Whoops\Run;

class WhoopsErrorHandler extends ErrorHandler
{
    /**
     * The Whoops instance.
     *
     * @var \Whoops\Run
     */
    protected $_whoops;

    /**
     * Get the Whoops instance.
     *
     * @return \Whoops\Run The Whoops instance.
     */
    public function getWhoopsInstance()
    {
        if (empty($this->_whoops)) {
            $this->_whoops = new Run();
        }

        return $this->_whoops;
    }

    /**
     * Display an error.
     *
     * Only when debug > 2 will a formatted error be displayed.
     *
     * @param array $error An array of error data.
     * @param bool $debug Whether or not the app is in debug mode.
     *
     * @return void
     */
    protected function _displayError($error, $debug)
    {
        if ($debug) {
            $whoops = $this->getWhoopsInstance();
            $whoops->pushHandler(new PrettyPageHandler());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $whoops->handleError($error['level'], $error['description'], $error['file'], $error['line']);
        } else {
            parent::_displayError($error, $debug);
        }
    }

    /**
     * Displays an exception response body.
     *
     * @param \Exception $exception The exception to display
     *
     * @return void
     */
    protected function _displayException($exception)
    {
        if (Configure::read('debug')) {
            $whoops = $this->getWhoopsInstance();
            $whoops->pushHandler(new PrettyPageHandler());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $whoops->handleException($exception);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        } else {
            parent::_displayException($exception);
        }
    }
}


1			<?php
2
3			namespace App\Error;
4
5			use Cake\Core\Configure;
6			use Cake\Error\ErrorHandler;
7			use Whoops\Handler\PrettyPageHandler;
8			use Whoops\Run;
9
10			class WhoopsErrorHandler extends ErrorHandler
11			{
12			/**
13			* The Whoops instance.
14			*
15			* @var \Whoops\Run
16			*/
17			protected $_whoops;
18
19			/**
20			* Get the Whoops instance.
21			*
22			* @return \Whoops\Run The Whoops instance.
23			*/
24			public function getWhoopsInstance()
25			{
26			if (empty($this->_whoops)) {
27			$this->_whoops = new Run();
28			}
29
30			return $this->_whoops;
31			}
32
33			/**
34			* Display an error.
35			*
36			* Only when debug > 2 will a formatted error be displayed.
37			*
38			* @param array $error An array of error data.
39			* @param bool $debug Whether or not the app is in debug mode.
40			*
41			* @return void
42			*/
43			protected function _displayError($error, $debug)
44			{
45			if ($debug) {
46			$whoops = $this->getWhoopsInstance();
47			$whoops->pushHandler(new PrettyPageHandler());
			0 ignored issues – show Documentation introduced 2016-10-30 17:20 UTC by Report Bug Copy Issue Report `new \Whoops\Handler\PrettyPageHandler()` is of type `object<Whoops\Handler\PrettyPageHandler>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
48			$whoops->handleError($error['level'], $error['description'], $error['file'], $error['line']);
49			} else {
50			parent::_displayError($error, $debug);
51			}
52			}
53
54			/**
55			* Displays an exception response body.
56			*
57			* @param \Exception $exception The exception to display
58			*
59			* @return void
60			*/
61			protected function _displayException($exception)
62			{
63			if (Configure::read('debug')) {
64			$whoops = $this->getWhoopsInstance();
65			$whoops->pushHandler(new PrettyPageHandler());
			0 ignored issues – show Documentation introduced 2016-10-30 17:20 UTC by Report Bug Copy Issue Report `new \Whoops\Handler\PrettyPageHandler()` is of type `object<Whoops\Handler\PrettyPageHandler>`, but the function expects a `callable`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
66			$whoops->handleException($exception);
			0 ignored issues – show Documentation introduced 2016-10-30 17:20 UTC by Report Bug Copy Issue Report `$exception` is of type `object<Exception>`, but the function expects a `object<Throwable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
67			} else {
68			parent::_displayException($exception);
69			}
70			}
71			}
72

XetaIO / Xeta

Pull Request — master (#178)

WhoopsErrorHandler::_displayError() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like