Issues in PollsController.php - New Issues - Inspection of "Merge pull request #217 from XetaIO/update-homepag..." - XetaIO/Xeta - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d93525...41af6a )

by Fèvre

created 2017-04-19 22:10 UTC

src/Controller/PollsController.php (3 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace App\Controller;

use Cake\I18n\Time;
use Cake\Network\Exception\NotFoundException;

class PollsController extends AppController
{

    /**
     * An user vote to a poll.
     *
     * @return \Cake\Network\Exception\NotFoundException|\Cake\Network\Response
     */
    public function vote()
    {
        if (!$this->request->is('post') || is_null($this->request->getData('answer_id'))) {
            throw new NotFoundException();
        }

        $this->loadModel('PollsAnswers');
        $answer = $this->PollsAnswers
            ->find()
            ->contain([
                'Polls'
            ])
            ->where([
                'PollsAnswers.id' => $this->request->getData('answer_id'),
                'Polls.article_id' => $this->request->id
            ])
            ->first();

        if (is_null($answer)) {
            $this->Flash->error(__('This answer doesn\'t exist.'));

            return $this->redirect($this->referer());
        }

        if ($answer->poll->is_timed == true && $answer->poll->end_date < new Time()) {
            $this->Flash->error(__('This poll is expired, you can not vote anymore.'));

            return $this->redirect($this->referer());
        }

        $this->loadModel('PollsUsers');
        $hasVoted = $this->PollsUsers
            ->find()
            ->contain([
                'PollsAnswers'
            ])
            ->where([
                'PollsUsers.poll_id' => $answer->poll->id,
                'PollsUsers.user_id' => $this->Auth->user('id')
            ])
            ->first();

        if (!is_null($hasVoted)) {
            $this->Flash->error(__('You have already voted for this poll ! (You voted <strong>{0}</strong>).', h($hasVoted->polls_answer->response)));

            return $this->redirect($this->referer());

        }

        $this->request = $this->request
            ->withData('poll_id', $answer->poll->id)
            ->withData('user_id', $this->Auth->user('id'));
        $user = $this->PollsUsers->newEntity($this->request->getParsedBody());
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        if ($this->PollsUsers->save($user)) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $this->Flash->success(__('Your have successfully voted for this poll ! (You voted <strong>{0}</strong>).', h($answer->response)));

            return $this->redirect($this->referer());
        }

        $this->Flash->error(__('An error occured while saving the vote !'));

        return $this->redirect($this->referer());
    }
}


1			<?php
2			namespace App\Controller;
3
4			use Cake\I18n\Time;
5			use Cake\Network\Exception\NotFoundException;
6
7			class PollsController extends AppController
8			{
9
10			/**
11			* An user vote to a poll.
12			*
13			* @return \Cake\Network\Exception\NotFoundException\|\Cake\Network\Response
14			*/
15			public function vote()
16			{
17			if (!$this->request->is('post') \|\| is_null($this->request->getData('answer_id'))) {
18			throw new NotFoundException();
19			}
20
21			$this->loadModel('PollsAnswers');
22			$answer = $this->PollsAnswers
23			->find()
24			->contain([
25			'Polls'
26			])
27			->where([
28			'PollsAnswers.id' => $this->request->getData('answer_id'),
29			'Polls.article_id' => $this->request->id
30			])
31			->first();
32
33			if (is_null($answer)) {
34			$this->Flash->error(__('This answer doesn\'t exist.'));
35
36			return $this->redirect($this->referer());
37			}
38
39			if ($answer->poll->is_timed == true && $answer->poll->end_date < new Time()) {
40			$this->Flash->error(__('This poll is expired, you can not vote anymore.'));
41
42			return $this->redirect($this->referer());
43			}
44
45			$this->loadModel('PollsUsers');
46			$hasVoted = $this->PollsUsers
47			->find()
48			->contain([
49			'PollsAnswers'
50			])
51			->where([
52			'PollsUsers.poll_id' => $answer->poll->id,
53			'PollsUsers.user_id' => $this->Auth->user('id')
54			])
55			->first();
56
57			if (!is_null($hasVoted)) {
58			$this->Flash->error(__('You have already voted for this poll ! (You voted <strong>{0}</strong>).', h($hasVoted->polls_answer->response)));
59
60			return $this->redirect($this->referer());
			0 ignored issues – show Bug introduced 2017-04-19 21:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$this->referer()` targeting `Cake\Controller\Controller::referer()` can also be of type `object<Cake\Http\ServerRequest>`; however, `Cake\Controller\Controller::redirect()` does only seem to accept `string\|array`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
61			}
62
63			$this->request = $this->request
64			->withData('poll_id', $answer->poll->id)
65			->withData('user_id', $this->Auth->user('id'));
66			$user = $this->PollsUsers->newEntity($this->request->getParsedBody());
			0 ignored issues – show Documentation introduced 2017-04-19 21:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `PollsUsers` does not exist on `object<App\Controller\PollsController>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
67
68			if ($this->PollsUsers->save($user)) {
			0 ignored issues – show Documentation introduced 2017-04-19 21:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `PollsUsers` does not exist on `object<App\Controller\PollsController>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
69			$this->Flash->success(__('Your have successfully voted for this poll ! (You voted <strong>{0}</strong>).', h($answer->response)));
70
71			return $this->redirect($this->referer());
72			}
73
74			$this->Flash->error(__('An error occured while saving the vote !'));
75
76			return $this->redirect($this->referer());
77			}
78			}
79

XetaIO / Xeta

Push — master ( d93525...41af6a )

src/Controller/PollsController.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like