Issues in SettingsController.php - All Issues - Inspection of "Merge pull request #217 from XetaIO/update-homepag..." - XetaIO/Xeta - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d93525...41af6a )

by Fèvre

created 2017-04-19 22:10 UTC

src/Controller/Admin/SettingsController.php (14 issues)

Labels

Severity

Informational 14

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace App\Controller\Admin;

use App\Controller\AppController;
use Cake\Cache\Cache;
use Cake\Core\Configure;
use Cake\Event\Event;
use Cake\Network\Exception\NotFoundException;

class SettingsController extends AppController
{

    /**
     * Display all settings.
     *
     * @return void
     */
    public function index()

    {
        $this->paginate = [
            'maxLimit' => 20
        ];

        $settings = $this->Settings
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->find()
            ->contain([
                'LastUpdatedUser' => function ($q) {
                    return $q->find('medium');
                }
            ])
            ->order([
                'Settings.name' => 'ASC'
            ]);

        $settings = $this->paginate($settings);

        $this->set(compact('settings'));
    }

    /**
     * Create a setting.
     *
     * @return \Cake\Network\Response|void
     */
    public function create()
    {
        $setting = $this->Settings->newEntity($this->request->getParsedBody());
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        if ($this->request->is('post')) {
            $setting->last_updated_user_id = $this->Auth->user('id');

            if ($this->Settings->save($setting)) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                Cache::delete('settings', 'database');
                $this->Flash->success(__d('admin', 'This setting has been created successfully !'));

                return $this->redirect(['action' => 'index']);
            }
        }

        $this->set(compact('setting'));
    }

    /**
     * Edit a setting.
     *
     * @return \Cake\Network\Response|void
     */
    public function edit()
    {
        $setting = $this->Settings
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->find()
            ->where([
                'Settings.id' => $this->request->id
            ])
            ->first();

        if (is_null($setting)) {

            $this->Flash->error(__d('admin', 'This setting doesn\'t exist or has been deleted.'));

            return $this->redirect(['action' => 'index']);
        }

        if ($this->request->is(['post', 'put'])) {
            $this->Settings->patchEntity($setting, $this->request->getParsedBody());
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

            $setting->last_updated_user_id = $this->Auth->user('id');

            if ($this->Settings->save($setting)) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                Cache::delete('settings', 'database');
                $this->Flash->success(__d('admin', 'This setting has been edited successfully !'));

                return $this->redirect(['action' => 'index']);
            }
        }

        $this->set(compact('setting'));
    }

    /**
     * Delete a setting.
     *
     * @return \Cake\Network\Response|void
     */
    public function delete()
    {
        $setting = $this->Settings
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->find()
            ->where([
                'Settings.id' => $this->request->id
            ])
            ->first();

        if (is_null($setting)) {

            $this->Flash->error(__d('admin', 'This setting doesn\'t exist or has been deleted.'));

            return $this->redirect(['action' => 'index']);
        }

        if ($this->Settings->delete($setting)) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $this->Flash->success(__d('admin', 'This setting has been deleted successfully !'));

            return $this->redirect(['action' => 'index']);
        }

        return $this->redirect(['action' => 'index']);
    }
}


1		<?php
2		namespace App\Controller\Admin;
3
4		use App\Controller\AppController;
5		use Cake\Cache\Cache;
6		use Cake\Core\Configure;
7		use Cake\Event\Event;
8		use Cake\Network\Exception\NotFoundException;
9
10		class SettingsController extends AppController
11		{
12
13		/**
14		* Display all settings.
15		*
16		* @return void
17		*/
18	View Code Duplication	public function index()
		0 ignored issues – show Duplication introduced 2016-11-04 08:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
19		{
20		$this->paginate = [
21		'maxLimit' => 20
22		];
23
24		$settings = $this->Settings
		0 ignored issues – show Documentation introduced 2016-11-04 08:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `Settings` does not exist on `object<App\Controller\Admin\SettingsController>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
25		->find()
26		->contain([
27		'LastUpdatedUser' => function ($q) {
28		return $q->find('medium');
29		}
30		])
31		->order([
32		'Settings.name' => 'ASC'
33		]);
34
35		$settings = $this->paginate($settings);
36
37		$this->set(compact('settings'));
38		}
39
40		/**
41		* Create a setting.
42		*
43		* @return \Cake\Network\Response\|void
44		*/
45		public function create()
46		{
47		$setting = $this->Settings->newEntity($this->request->getParsedBody());
		0 ignored issues – show Documentation introduced 2016-11-04 08:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `Settings` does not exist on `object<App\Controller\Admin\SettingsController>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
48
49		if ($this->request->is('post')) {
50		$setting->last_updated_user_id = $this->Auth->user('id');
51
52	View Code Duplication	if ($this->Settings->save($setting)) {
		0 ignored issues – show Documentation introduced 2016-11-04 08:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `Settings` does not exist on `object<App\Controller\Admin\SettingsController>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Duplication introduced 2016-11-04 08:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
53		Cache::delete('settings', 'database');
54		$this->Flash->success(__d('admin', 'This setting has been created successfully !'));
55
56		return $this->redirect(['action' => 'index']);
57		}
58		}
59
60		$this->set(compact('setting'));
61		}
62
63		/**
64		* Edit a setting.
65		*
66		* @return \Cake\Network\Response\|void
67		*/
68		public function edit()
69		{
70		$setting = $this->Settings
		0 ignored issues – show Documentation introduced 2016-11-04 08:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `Settings` does not exist on `object<App\Controller\Admin\SettingsController>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
71		->find()
72		->where([
73		'Settings.id' => $this->request->id
74		])
75		->first();
76
77	View Code Duplication	if (is_null($setting)) {
		0 ignored issues – show Duplication introduced 2016-11-04 08:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
78		$this->Flash->error(__d('admin', 'This setting doesn\'t exist or has been deleted.'));
79
80		return $this->redirect(['action' => 'index']);
81		}
82
83		if ($this->request->is(['post', 'put'])) {
84		$this->Settings->patchEntity($setting, $this->request->getParsedBody());
		0 ignored issues – show Documentation introduced 2016-11-04 08:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `Settings` does not exist on `object<App\Controller\Admin\SettingsController>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
85
86		$setting->last_updated_user_id = $this->Auth->user('id');
87
88	View Code Duplication	if ($this->Settings->save($setting)) {
		0 ignored issues – show Documentation introduced 2016-11-04 08:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `Settings` does not exist on `object<App\Controller\Admin\SettingsController>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Duplication introduced 2016-11-04 08:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
89		Cache::delete('settings', 'database');
90		$this->Flash->success(__d('admin', 'This setting has been edited successfully !'));
91
92		return $this->redirect(['action' => 'index']);
93		}
94		}
95
96		$this->set(compact('setting'));
97		}
98
99		/**
100		* Delete a setting.
101		*
102		* @return \Cake\Network\Response\|void
103		*/
104		public function delete()
105		{
106		$setting = $this->Settings
		0 ignored issues – show Documentation introduced 2016-11-04 08:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `Settings` does not exist on `object<App\Controller\Admin\SettingsController>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
107		->find()
108		->where([
109		'Settings.id' => $this->request->id
110		])
111		->first();
112
113	View Code Duplication	if (is_null($setting)) {
		0 ignored issues – show Duplication introduced 2016-11-04 08:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
114		$this->Flash->error(__d('admin', 'This setting doesn\'t exist or has been deleted.'));
115
116		return $this->redirect(['action' => 'index']);
117		}
118
119	View Code Duplication	if ($this->Settings->delete($setting)) {
		0 ignored issues – show Documentation introduced 2016-11-04 08:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `Settings` does not exist on `object<App\Controller\Admin\SettingsController>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Duplication introduced 2016-11-04 08:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
120		$this->Flash->success(__d('admin', 'This setting has been deleted successfully !'));
121
122		return $this->redirect(['action' => 'index']);
123		}
124
125		return $this->redirect(['action' => 'index']);
126		}
127		}
128

XetaIO / Xeta

Push — master ( d93525...41af6a )

src/Controller/Admin/SettingsController.php (14 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like