ContactController::index() - Code Metrics - Inspection of "Refactoring Emails to use Mailer" - XetaIO/Xeta - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — v3 ( 25ab4d...910cb0 )

by Fèvre

created 2016-11-02 13:35 UTC

ContactController::index() A

↳ Parent: ContactController

Complexity

Conditions	3
Paths	3

Size

Total Lines	61
Code Lines	39

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	61
rs	9.5147
cc	3
eloc	39
nc	3
nop	0

How to fix Long Method

<?php
namespace App\Controller;

use Cake\Core\Configure;
use Cake\Event\Event;
use Cake\Mailer\MailerAwareTrait;
use Cake\Validation\Validator;

class ContactController extends AppController
{
    use MailerAwareTrait;

    /**
     * Beforefilter.
     *
     * @param Event $event The beforeFilter event that was fired.
     *
     * @return void
     */
    public function beforeFilter(Event $event)
    {
        parent::beforeFilter($event);

        $this->Auth->allow(['index']);
    }

    /**
     * Contact page.
     *
     * @return \Cake\Network\Response|void
     */
    public function index()
    {
        $contact = [
            'schema' => [
                'name' => [
                    'type' => 'string',
                    'length' => 100
                ],
                'email' => [
                    'type' => 'email',
                    'length' => 100
                ],
                'subject' => [
                    'type' => 'string',
                    'length' => 255
                ],
                'message' => [
                    'type' => 'string'
                ]
            ],
            'required' => [
                'name' => 1,
                'email' => 1,
                'message' => 1
            ]
        ];

        if ($this->request->is('post')) {
            $validator = new Validator();
            $validator
                ->notEmpty('email', __('You need to put your E-mail.'))
                ->add('email', 'validFormat', [
                    'rule' => 'email',
                    'message' => __("You must specify a valid E-mail address.")
                ])
                ->notEmpty('name', __('You need to put your name.'))
                ->notEmpty('message', __("You need to give a message."))
                ->add('message', 'minLength', [
                    'rule' => ['minLength', 10],
                    'message' => __("Your message can not contain less than {0} characters.", 10)
                ]);

            $contact['errors'] = $validator->errors($this->request->data());

            if (empty($contact['errors'])) {
                $viewVars = [
                    'ip' => $this->request->clientIp()
                ];

                $viewVars = array_merge($this->request->data(), $viewVars);

                $this->getMailer('Contact')->send('contact', [$viewVars]);

                $this->Flash->success(__("Your message has been sent successfully, you will get a response shortly !"));

                return $this->redirect(['controller' => 'pages', 'action' => 'home']);
            }
        }

        $this->set(compact('contact'));
    }
}


1			<?php
2			namespace App\Controller;
3
4			use Cake\Core\Configure;
5			use Cake\Event\Event;
6			use Cake\Mailer\MailerAwareTrait;
7			use Cake\Validation\Validator;
8
9			class ContactController extends AppController
10			{
11			use MailerAwareTrait;
12
13			/**
14			* Beforefilter.
15			*
16			* @param Event $event The beforeFilter event that was fired.
17			*
18			* @return void
19			*/
20			public function beforeFilter(Event $event)
21			{
22			parent::beforeFilter($event);
23
24			$this->Auth->allow(['index']);
25			}
26
27			/**
28			* Contact page.
29			*
30			* @return \Cake\Network\Response\|void
31			*/
32			public function index()
33			{
34			$contact = [
35			'schema' => [
36			'name' => [
37			'type' => 'string',
38			'length' => 100
39			],
40			'email' => [
41			'type' => 'email',
42			'length' => 100
43			],
44			'subject' => [
45			'type' => 'string',
46			'length' => 255
47			],
48			'message' => [
49			'type' => 'string'
50			]
51			],
52			'required' => [
53			'name' => 1,
54			'email' => 1,
55			'message' => 1
56			]
57			];
58
59			if ($this->request->is('post')) {
60			$validator = new Validator();
61			$validator
62			->notEmpty('email', __('You need to put your E-mail.'))
63			->add('email', 'validFormat', [
64			'rule' => 'email',
65			'message' => __("You must specify a valid E-mail address.")
66			])
67			->notEmpty('name', __('You need to put your name.'))
68			->notEmpty('message', __("You need to give a message."))
69			->add('message', 'minLength', [
70			'rule' => ['minLength', 10],
71			'message' => __("Your message can not contain less than {0} characters.", 10)
72			]);
73
74			$contact['errors'] = $validator->errors($this->request->data());
75
76			if (empty($contact['errors'])) {
77			$viewVars = [
78			'ip' => $this->request->clientIp()
79			];
80
81			$viewVars = array_merge($this->request->data(), $viewVars);
82
83			$this->getMailer('Contact')->send('contact', [$viewVars]);
84
85			$this->Flash->success(__("Your message has been sent successfully, you will get a response shortly !"));
86
87			return $this->redirect(['controller' => 'pages', 'action' => 'home']);
88			}
89			}
90
91			$this->set(compact('contact'));
92			}
93			}
94

XetaIO / Xeta

Push — v3 ( 25ab4d...910cb0 )

ContactController::index() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like