Users::usersLoginFailed() - Code Metrics - Inspection of "Prepare the V3" - XetaIO/Xeta - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#178)

by Fèvre

created 2016-11-02 13:35 UTC

Users::usersLoginFailed() B

↳ Parent: Users

Complexity

Conditions	3
Paths	2

Size

Total Lines	24
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	24
rs	8.9713
cc	3
eloc	15
nc	2
nop	1

<?php
namespace App\Event;

use Cake\Event\Event;
use Cake\Event\EventListenerInterface;
use Cake\Mailer\MailerAwareTrait;
use Cake\ORM\TableRegistry;

class Users implements EventListenerInterface
{
    use MailerAwareTrait;

    /**
     * ImplementedEvents method.
     *
     * @return array
     */
    public function implementedEvents()
    {
        return [
            'Users.login.failed' => 'usersLoginFailed'
        ];
    }

    /**
     * An user failed to login.
     *
     * @param Event $event The event that was fired.
     *
     * @return bool
     */
    public function usersLoginFailed(Event $event)
    {
        //Email.
        $this->Groups = TableRegistry::get('Groups');
class MyClass { }

$x = new MyClass();
$x->foo = true;
        $group = $this->Groups
            ->find()
            ->where(['id' => $event->data['group_id']])
            ->first();

        if (is_null($group) || (bool)$group->is_staff === false) {
            return true;
        }

        $viewVars = [
            'user_ip' => $event->data['user_ip'],
            'username' => $event->data['username'],
            'user_agent' => $event->data['user_agent'],
            'email' => $event->data['user_email']
        ];

        $this->getMailer('User')->send('login', [$viewVars]);

        return true;
    }
}


1			<?php
2			namespace App\Event;
3
4			use Cake\Event\Event;
5			use Cake\Event\EventListenerInterface;
6			use Cake\Mailer\MailerAwareTrait;
7			use Cake\ORM\TableRegistry;
8
9			class Users implements EventListenerInterface
10			{
11			use MailerAwareTrait;
12
13			/**
14			* ImplementedEvents method.
15			*
16			* @return array
17			*/
18			public function implementedEvents()
19			{
20			return [
21			'Users.login.failed' => 'usersLoginFailed'
22			];
23			}
24
25			/**
26			* An user failed to login.
27			*
28			* @param Event $event The event that was fired.
29			*
30			* @return bool
31			*/
32			public function usersLoginFailed(Event $event)
33			{
34			//Email.
35			$this->Groups = TableRegistry::get('Groups');
			0 ignored issues – show Bug introduced 2016-11-02 13:39 UTC by Report Bug Copy Issue Report The property `Groups` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
36			$group = $this->Groups
37			->find()
38			->where(['id' => $event->data['group_id']])
39			->first();
40
41			if (is_null($group) \|\| (bool)$group->is_staff === false) {
42			return true;
43			}
44
45			$viewVars = [
46			'user_ip' => $event->data['user_ip'],
47			'username' => $event->data['username'],
48			'user_agent' => $event->data['user_agent'],
49			'email' => $event->data['user_email']
50			];
51
52			$this->getMailer('User')->send('login', [$viewVars]);
53
54			return true;
55			}
56			}
57

XetaIO / Xeta

Pull Request — master (#178)

Users::usersLoginFailed() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like