MaintenanceComponent::handle() - Code Metrics - Inspection of "Add a Maintenance shell" - XetaIO/Xeta - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#207)

by Fèvre

created 2016-12-12 01:17 UTC

MaintenanceComponent::handle() C

↳ Parent: MaintenanceComponent

Complexity

Conditions	7
Paths	6

Size

Total Lines	46
Code Lines	30

Duplication

Lines	18
Ratio	39.13 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	18
loc	46
rs	6.7272
cc	7
eloc	30
nc	6
nop	0

<?php
namespace App\Controller\Component;

use Cake\Controller\Component;
use Cake\Core\Configure;
use Cake\ORM\TableRegistry;

class MaintenanceComponent extends Component
{
    /**
     * Controller object
     *
     * @var \Cake\Controller\Controller
     */
    protected $_controller;

    /**
     * The allowed routes.
     *
     * @var array
     */
    protected $_allowedRoutes = [
        'Pages.maintenance',
        'Users.login',
        'Users.logout'
    ];

    /**
     * Initialize properties.
     *
     * @param array $config The config data.
     *
     * @return void
     */
    public function initialize(array $config)
    {
        $this->_controller = $this->_registry->getController();
    }

    /**
     * Handle the maintenance mode.
     *
     * @return false|void
     */
    public function handle()
    {
        if (Configure::read('Site.maintenance') !== true) {
            return false;
        }

        $controller = $this->request->params['controller'];
        $action = $this->request->params['action'];

        if ($this->_controller->Auth->user()) {
            $this->Users = TableRegistry::get('Users');
class MyClass { }

$x = new MyClass();
$x->foo = true;
            $user = $this->Users
                ->find()
                ->contain([
                    'Groups' => function ($q) {
                        return $q->select(['id', 'is_staff']);
                    }
                ])
                ->where([
                    'Users.id' => $this->_controller->Auth->user('id')
                ])
                ->first();

            if (!is_null($user) && $user->group->is_staff == true) {
                //To prevent multiple flash messages.
                $this->_controller->Flash->config(['clear' => true]);
                $this->_controller->Flash->error(__("Hello {0}, The website is under maintenance, only you and the staff groups have the access !", h($user->full_name)));
            } else {

                if (!in_array($controller . '.' . $action, $this->_allowedRoutes)) {
                    $this->_controller->redirect([
                        'controller' => 'pages',
                        'action' => 'maintenance',
                        'prefix' => false
                    ]);
                }
            }
        } else {

            if (!in_array($controller . '.' . $action, $this->_allowedRoutes)) {
                $this->_controller->redirect([
                    'controller' => 'pages',
                    'action' => 'maintenance',
                    'prefix' => false
                ]);
            }
        }
    }
}


1		<?php
2		namespace App\Controller\Component;
3
4		use Cake\Controller\Component;
5		use Cake\Core\Configure;
6		use Cake\ORM\TableRegistry;
7
8		class MaintenanceComponent extends Component
9		{
10		/**
11		* Controller object
12		*
13		* @var \Cake\Controller\Controller
14		*/
15		protected $_controller;
16
17		/**
18		* The allowed routes.
19		*
20		* @var array
21		*/
22		protected $_allowedRoutes = [
23		'Pages.maintenance',
24		'Users.login',
25		'Users.logout'
26		];
27
28		/**
29		* Initialize properties.
30		*
31		* @param array $config The config data.
32		*
33		* @return void
34		*/
35		public function initialize(array $config)
36		{
37		$this->_controller = $this->_registry->getController();
38		}
39
40		/**
41		* Handle the maintenance mode.
42		*
43		* @return false\|void
44		*/
45		public function handle()
46		{
47		if (Configure::read('Site.maintenance') !== true) {
48		return false;
49		}
50
51		$controller = $this->request->params['controller'];
52		$action = $this->request->params['action'];
53
54		if ($this->_controller->Auth->user()) {
55		$this->Users = TableRegistry::get('Users');
		0 ignored issues – show Bug introduced 2016-12-12 01:28 UTC by Report Bug Copy Issue Report The property `Users` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
56		$user = $this->Users
57		->find()
58		->contain([
59		'Groups' => function ($q) {
60		return $q->select(['id', 'is_staff']);
61		}
62		])
63		->where([
64		'Users.id' => $this->_controller->Auth->user('id')
65		])
66		->first();
67
68		if (!is_null($user) && $user->group->is_staff == true) {
69		//To prevent multiple flash messages.
70		$this->_controller->Flash->config(['clear' => true]);
71		$this->_controller->Flash->error(__("Hello {0}, The website is under maintenance, only you and the staff groups have the access !", h($user->full_name)));
72	View Code Duplication	} else {
		0 ignored issues – show Duplication introduced 2016-12-12 01:28 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
73		if (!in_array($controller . '.' . $action, $this->_allowedRoutes)) {
74		$this->_controller->redirect([
75		'controller' => 'pages',
76		'action' => 'maintenance',
77		'prefix' => false
78		]);
79		}
80		}
81	View Code Duplication	} else {
		0 ignored issues – show Duplication introduced 2016-12-12 01:28 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
82		if (!in_array($controller . '.' . $action, $this->_allowedRoutes)) {
83		$this->_controller->redirect([
84		'controller' => 'pages',
85		'action' => 'maintenance',
86		'prefix' => false
87		]);
88		}
89		}
90		}
91		}
92

XetaIO / Xeta

Pull Request — master (#207)

MaintenanceComponent::handle() C

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like