TwoFactorAuthComponent::isAuthorized() - Code Metrics - Inspection of "Merge pull request #194 from Xety/feature-184" - XetaIO/Xeta - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( a505a0...5d1dca )

by Fèvre

created 2016-11-06 15:03 UTC

TwoFactorAuthComponent::isAuthorized() A

↳ Parent: TwoFactorAuthComponent

Complexity

Conditions	2
Paths	2

Size

Total Lines	19
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
c	0
b	0
f	0
dl	0
loc	19
rs	9.4285
cc	2
eloc	11
nc	2
nop	1

<?php
namespace App\Controller\Component;

use Cake\Controller\Component;
use Cake\ORM\TableRegistry;

class TwoFactorAuthComponent extends Component
{
    /**
     * Check if the current user session is the same as the saved session.
     *
     * @param int $user The user id.
     *
     * @return bool
     */
    public function isAuthorized($user)
    {
        $session = $this->request->clientIp() . $this->request->header('User-Agent') . gethostbyaddr($this->request->clientIp());

        $this->UsersTwoFactorAuth = TableRegistry::get('UsersTwoFactorAuth');
class MyClass { }

$x = new MyClass();
$x->foo = true;

        $tfa = $this->UsersTwoFactorAuth
            ->find()
            ->where([
                'user_id' => $user
            ])
            ->first();

        if (is_null($tfa)) {
            return false;
        }

        return $tfa->session === $session;
    }
}


1			<?php
2			namespace App\Controller\Component;
3
4			use Cake\Controller\Component;
5			use Cake\ORM\TableRegistry;
6
7			class TwoFactorAuthComponent extends Component
8			{
9			/**
10			* Check if the current user session is the same as the saved session.
11			*
12			* @param int $user The user id.
13			*
14			* @return bool
15			*/
16			public function isAuthorized($user)
17			{
18			$session = $this->request->clientIp() . $this->request->header('User-Agent') . gethostbyaddr($this->request->clientIp());
19
20			$this->UsersTwoFactorAuth = TableRegistry::get('UsersTwoFactorAuth');
			0 ignored issues – show Bug introduced 2016-11-05 09:03 UTC by Report Bug Copy Issue Report The property `UsersTwoFactorAuth` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
21
22			$tfa = $this->UsersTwoFactorAuth
23			->find()
24			->where([
25			'user_id' => $user
26			])
27			->first();
28
29			if (is_null($tfa)) {
30			return false;
31			}
32
33			return $tfa->session === $session;
34			}
35			}
36

XetaIO / Xeta

Push — master ( a505a0...5d1dca )

TwoFactorAuthComponent::isAuthorized() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like