AclAuthComponent::allow() - Code Metrics - XetaIO/Xeta - Measure and Improve Code Quality continuously with Scrutinizer

AclAuthComponent::allow() B
last analyzed 2017-04-25 20:37 UTC

↳ Parent: AclAuthComponent

Complexity

Conditions	5
Paths	3

Size

Total Lines	18
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	18
rs	8.8571
c	0
b	0
f	0
cc	5
eloc	11
nc	3
nop	1

<?php
namespace App\Controller\Component;

use Cake\Controller\Component\AuthComponent;
use Cake\Utility\Inflector;

class AclAuthComponent extends AuthComponent
{

    /**
     * Takes a list of actions in the current controller for which authentication is not required, or
     * no parameters to allow all actions.
     *
     * You can use allow with either an array or a simple string.
     *
     * `$this->Auth->allow('view');`
     * `$this->Auth->allow(['edit', 'add']);`
     * `$this->Auth->allow();` to allow all actions
     *
     * @param string|array $actions Controller action name or array of actions.
     *
     * @return void
     */
    public function allow($actions = null)
    {
        if ($actions === null) {
            $controller = $this->_registry->getController();
            $this->allowedActions = get_class_methods($controller);

            return;
        }

        $controller = Inflector::camelize($this->request['controller']);
        $action = Inflector::underscore($this->request['action']);
        if (!$this->session->read('Auth.User') ||
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            (isset($this->config('allowedActionsForBanned')[$controller]) &&

            in_array($action, array_map('strtolower', $this->config('allowedActionsForBanned')[$controller])))

        ) {
            $this->allowedActions = array_merge($this->allowedActions, (array)$actions);
        }
    }
}


1			<?php
2			namespace App\Controller\Component;
3
4			use Cake\Controller\Component\AuthComponent;
5			use Cake\Utility\Inflector;
6
7			class AclAuthComponent extends AuthComponent
8			{
9
10			/**
11			* Takes a list of actions in the current controller for which authentication is not required, or
12			* no parameters to allow all actions.
13			*
14			* You can use allow with either an array or a simple string.
15			*
16			* `$this->Auth->allow('view');`
17			* `$this->Auth->allow(['edit', 'add']);`
18			* `$this->Auth->allow();` to allow all actions
19			*
20			* @param string\|array $actions Controller action name or array of actions.
21			*
22			* @return void
23			*/
24			public function allow($actions = null)
25			{
26			if ($actions === null) {
27			$controller = $this->_registry->getController();
28			$this->allowedActions = get_class_methods($controller);
29
30			return;
31			}
32
33			$controller = Inflector::camelize($this->request['controller']);
34			$action = Inflector::underscore($this->request['action']);
35			if (!$this->session->read('Auth.User') \|\|
			0 ignored issues – show Bug Best Practice introduced 2016-10-25 05:06 UTC by Report Bug Copy Issue Report The expression `$this->session->read('Auth.User')` of type `string\|null` is loosely compared to `false`; this is ambiguous if the string can be empty. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history... Deprecated Code introduced 2016-10-25 05:06 UTC by Report Bug Copy Issue Report The property `Cake\Controller\Component\AuthComponent::$session` has been deprecated with message: 3.1.0 Will be removed in 4.0 This property has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the property will be removed from the class and what other property to use instead. Loading history...
36			(isset($this->config('allowedActionsForBanned')[$controller]) &&
			0 ignored issues – show Deprecated Code introduced 2017-04-16 13:53 UTC by Report Bug Copy Issue Report The method `Cake\Core\InstanceConfigTrait::config()` has been deprecated with message: 3.4.0 use setConfig()/getConfig() instead. This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
37			in_array($action, array_map('strtolower', $this->config('allowedActionsForBanned')[$controller])))
			0 ignored issues – show Deprecated Code introduced 2017-04-16 13:53 UTC by Report Bug Copy Issue Report The method `Cake\Core\InstanceConfigTrait::config()` has been deprecated with message: 3.4.0 use setConfig()/getConfig() instead. This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
38			) {
39			$this->allowedActions = array_merge($this->allowedActions, (array)$actions);
40			}
41			}
42			}
43

XetaIO / Xeta

AclAuthComponent::allow() B last analyzed 2017-04-25 20:37 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

AclAuthComponent::allow() B
last analyzed 2017-04-25 20:37 UTC