AttachmentsController::edit() - Code Metrics - XetaIO/Xeta - Measure and Improve Code Quality continuously with Scrutinizer

AttachmentsController::edit() B
last analyzed 2017-04-25 20:37 UTC

↳ Parent: AttachmentsController

Complexity

Conditions	6
Paths	5

Size

Total Lines	66
Code Lines	39

Duplication

Lines	24
Ratio	36.36 %

Importance

Changes

Metric	Value
dl	24
loc	66
rs	8.6045
c	0
b	0
f	0
cc	6
eloc	39
nc	5
nop	0

How to fix Long Method

<?php
namespace App\Controller\Admin;

use App\Controller\AppController;
use Cake\Filesystem\File;
use Cake\Routing\Router;

class AttachmentsController extends AppController
{

    /**
     * Display all attachments.
     *
     * @return \Cake\Network\Response
     */
    public function index()
    {
        $this->loadModel('BlogAttachments');

        $this->paginate = [
            'maxLimit' => 15
        ];

        $attachments = $this->BlogAttachments
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->find()
            ->contain([
                'BlogArticles' => function ($q) {
                    return $q->select([
                        'id',
                        'title'
                    ]);
                },
                'Users' => function ($q) {
                    return $q->find('short');
                }
            ])
            ->order([
                'BlogArticles.created' => 'desc'
            ]);

        $attachments = $this->paginate($attachments);
        $this->set(compact('attachments'));
    }

    /**
     * Add an attachment to an article.
     *
     * @return \Cake\Network\Response|void
     */
    public function add()
    {
        $this->loadModel('BlogAttachments');
        $this->loadModel('BlogArticles');
        $attachment = $this->BlogAttachments->newEntity($this->request->getParsedBody());
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        if ($this->request->is('post')) {
            $article = $this->BlogArticles
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                ->find()
                ->contain([
                    'BlogAttachments'
                ])
                ->where([
                    'BlogArticles.id' => $this->request->getData('article_id')
                ])
                ->first();

            //Check if the article has already an attachment
            if (!is_null($article->blog_attachment)) {

                $this->Flash->error(
                    __d(
                        'admin',
                        'This article has already an attachment, you can edit it <a href="{0}" class="btn btn-sm btn-danger">here</a>.',
                        Router::url(['_name' => 'attachments-edit', 'id' => $article->blog_attachment->id])
                    )
                );

                return $this->redirect(['action' => 'index']);
            }

            $attachment->user_id = $this->Auth->user('id');
            $attachment->accessible('url_file', true);

            if ($newAttachment = $this->BlogAttachments->save($attachment)) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $file = new File(WWW_ROOT . $newAttachment->url);

                $newAttachment->name = $file->name;
                $newAttachment->extension = '.' . $file->info()['extension'];
                $newAttachment->size = $file->info()['filesize'];

                $this->BlogAttachments->save($newAttachment);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

                $this->Flash->success(__d('admin', 'Your attachment has been created successfully !'));

                return $this->redirect(['action' => 'index']);
            }
        }

        $articles = $this->BlogAttachments->BlogArticles->find('list');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->set(compact('attachment', 'articles'));
    }

    /**
     * Edit an attachment.
     *
     * @return \Cake\Network\Response|void
     */
    public function edit()
    {
        $this->loadModel('BlogAttachments');
        $this->loadModel('BlogArticles');

        $attachment = $this->BlogAttachments
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->find()
            ->where([
                'id' => $this->request->getAttribute('params')['id']
            ])
            ->first();

        //Check if the attachment is found.
        if (empty($attachment)) {
            $this->Flash->error(__d('admin', 'This attachment doesn\'t exist or has been deleted.'));

            return $this->redirect(['action' => 'index']);
        }

        if ($this->request->is(['put', 'post'])) {
            $this->BlogAttachments->patchEntity($attachment, $this->request->getParsedBody());
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

            //Check if the article has already an attachment
            $article = $this->BlogArticles
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                ->find()
                ->contain([
                    'BlogAttachments'
                ])
                ->where([
                    'BlogArticles.id' => $this->request->getData('article_id')
                ])
                ->first();

            if (!is_null($article->blog_attachment) && $article->blog_attachment->id != $this->request->id) {

                $this->Flash->error(
                    __d(
                        'admin',
                        'This article has already an attachment, you can edit it <a href="{0}" class="btn btn-sm btn-danger">here</a>.',
                        Router::url(['_name' => 'attachments-edit', 'id' => $article->blog_attachment->id])
                    )
                );

                return $this->redirect(['action' => 'index']);
            }

            $attachment->user_id = $this->Auth->user('id');
            $attachment->accessible('url_file', true);

            if ($editedAttachment = $this->BlogAttachments->save($attachment)) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $file = new File(WWW_ROOT . $editedAttachment->url);

                $editedAttachment->name = $file->name;
                $editedAttachment->extension = '.' . $file->info()['extension'];
                $editedAttachment->size = $file->info()['filesize'];

                $this->BlogAttachments->save($editedAttachment);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

                $this->Flash->success(__d('admin', 'Your attachment has been edited successfully !'));

                return $this->redirect(['action' => 'index']);
            }
        }

        $articles = $this->BlogAttachments->BlogArticles->find('list');
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->set(compact('attachment', 'articles'));
    }

    /**
     * Delete an Attachment.
     *
     * @return \Cake\Network\Response
     */
    public function delete()
    {
        $this->loadModel('BlogAttachments');

        $attachment = $this->BlogAttachments
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            ->find()
            ->where([
                'id' => $this->request->getAttribute('params')['id']
            ])
            ->first();

        //Check if the attachment is found.
        if (empty($attachment)) {
            $this->Flash->error(__d('admin', 'This attachment doesn\'t exist or has been deleted.'));

            return $this->redirect(['action' => 'index']);
        }

        if ($this->BlogAttachments->delete($attachment)) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $this->Flash->success(__d('admin', 'This attachment has been deleted successfully !'));

            return $this->redirect(['action' => 'index']);
        }

        $this->Flash->error(__d('admin', 'Unable to delete this attachment.'));

        return $this->redirect(['action' => 'index']);
    }
}


1			<?php
2			namespace App\Controller\Admin;
3
4			use App\Controller\AppController;
5			use Cake\Filesystem\File;
6			use Cake\Routing\Router;
7
8			class AttachmentsController extends AppController
9			{
10
11			/**
12			* Display all attachments.
13			*
14			* @return \Cake\Network\Response
15			*/
16			public function index()
17			{
18			$this->loadModel('BlogAttachments');
19
20			$this->paginate = [
21			'maxLimit' => 15
22			];
23
24			$attachments = $this->BlogAttachments
			0 ignored issues – show Documentation introduced 2016-10-25 05:06 UTC by Report Bug Copy Issue Report The property `BlogAttachments` does not exist on `object<App\Controller\Ad...\AttachmentsController>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
25			->find()
26			->contain([
27			'BlogArticles' => function ($q) {
28			return $q->select([
29			'id',
30			'title'
31			]);
32			},
33			'Users' => function ($q) {
34			return $q->find('short');
35			}
36			])
37			->order([
38			'BlogArticles.created' => 'desc'
39			]);

XetaIO / Xeta

AttachmentsController::edit() B last analyzed 2017-04-25 20:37 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

AttachmentsController::edit() B
last analyzed 2017-04-25 20:37 UTC