AttributesCompiler - Code Metrics - Inspection of "Added integration with Markdown" - XaBerr/JATE - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9ad54b...895d73 )

by Federico

created 2016-08-26 18:08 UTC

AttributesCompiler B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	192
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
c	1
b	0
f	1
dl	0
loc	192
rs	8.3999
wmc	46
lcom	1
cbo	1

13 Methods

Rating	Name	Size	Complexity
A	getAttributeDisplayCode()	14	3
A	getBooleanAttributeDisplayCode()	7	2
A	getValueStatement()	6	2
B	getAndAttributeCode()	32	6
A	getClassAttribute()	8	3
A	getValueCode()	10	2
B	getAttributeValue()	18	6
A	escapeValueIfNeeded()	6	4
B	compileAttributeValue()	13	7
B	getAttributeCode()	23	6
A	getClassesCode()	11	1
A	getClassesDisplayCode()	12	2
A	compileAttributes()	14	2

How to fix Complexity

<?php

namespace Jade\Compiler;

abstract class AttributesCompiler extends CompilerFacade
{
    protected function getAttributeDisplayCode($key, $value, $valueCheck)
    {
        if ($key === 'style') {
            $value = preg_replace('/::get(Escaped|Unescaped)Value/', '::get$1Style', $value, 1);
        }

        return is_null($valueCheck)
            ? ' ' . $key . '=' . $this->quote . $value . $this->quote
class MyClass { }

$x = new MyClass();
$x->foo = true;
            : $this->createCode('if (true === ($__value = %1$s)) { ', $valueCheck)
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                . $this->getBooleanAttributeDisplayCode($key)
                . $this->createCode('} else if (\\Jade\\Compiler::isDisplayable($__value)) { ')
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                . ' ' . $key . '=' . $this->quote . $value . $this->quote
                . $this->createCode('}');
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }

    protected function getBooleanAttributeDisplayCode($key)
    {
        return ' ' . $key . ($this->terse
class MyClass { }

$x = new MyClass();
$x->foo = true;
            ? ''
            : '=' . $this->quote . $key . $this->quote
        );
    }

    protected function getValueStatement($statements)
    {
        return is_string($statements[0])
            ? $statements[0]
            : $statements[0][0];
    }

    protected function getAndAttributeCode($attr, &$classes, &$classesCheck)
    {
        $addClasses = '""';
        if (count($classes) || count($classesCheck)) {
            foreach ($classes as &$value) {
                $value = var_export($value, true);
            }
            foreach ($classesCheck as $value) {
                $statements = $this->createStatements($value);
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                $classes[] = $statements[0][0];
            }
            $addClasses = '" " . implode(" ", array(' . implode(', ', $classes) . '))';
            $classes = array();
            $classesCheck = array();
        }
        $value = empty($attr['value']) ? 'attributes' : $attr['value'];
        $statements = $this->createStatements($value);
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        return $this->createCode(
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            '$__attributes = ' . $this->getValueStatement($statements) . ';' .
            'if (is_array($__attributes)) { ' .
                '$__attributes["class"] = trim(' .
                    '$__classes = (empty($__classes) ? "" : $__classes . " ") . ' .
                    '(isset($__attributes["class"]) ? (is_array($__attributes["class"]) ? implode(" ", $__attributes["class"]) : $__attributes["class"]) : "") . ' .
                    $addClasses .
                '); ' .
                'if (empty($__attributes["class"])) { ' .
                    'unset($__attributes["class"]); ' .
                '} ' .
            '} ' .
            '\\Jade\\Compiler::displayAttributes($__attributes, ' . var_export($this->quote, true) . ', ' . var_export($this->terse, true) . ');');
    }

    protected function getClassAttribute($value, &$classesCheck)
    {
        $statements = $this->createStatements($value);
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
        $value = is_array($statements[0]) ? $statements[0][0] : $statements[0];
        $classesCheck[] = '(is_array($_a = ' . $value . ') ? implode(" ", $_a) : $_a)';

        return $this->keepNullAttributes ? '' : 'null';
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    protected function getValueCode($escaped, $value, &$valueCheck)
    {
        if ($this->keepNullAttributes) {
            return $this->escapeIfNeeded($escaped, $value);
        }

        $valueCheck = $value;

        return $this->escapeIfNeeded($escaped, '$__value');
    }

    protected function getAttributeValue($escaped, $key, $value, &$classesCheck, &$valueCheck)
    {
        if ($this->isConstant($value)) {
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $value = trim($value, ' \'"');

            return $value === 'undefined' ? 'null' : $value;
        }

        $json = static::parseValue($value);

        if ($key === 'class') {
            return $json !== null && is_array($json)
                ? implode(' ', $json)
                : $this->getClassAttribute($value, $classesCheck);
        }

        return $this->getValueCode($escaped, $value, $valueCheck);
    }

    protected function escapeValueIfNeeded($value, $escaped, $valueCheck)
    {
        return is_null($valueCheck) && $escaped && !$this->keepNullAttributes
            ? $this->escapeValue($value)
            : $value;
    }

    protected function compileAttributeValue($key, $value, $attr, $valueCheck)
    {
        return $value === true || $attr['value'] === true
            ? $this->getBooleanAttributeDisplayCode($key)
            : ($value !== false && $attr['value'] !== false && $value !== 'null' && $value !== 'undefined'
                ? $this->getAttributeDisplayCode(
                    $key,
                    $this->escapeValueIfNeeded($value, $attr['escaped'], $valueCheck),
                    $valueCheck
                )
                : ''
            );
    }

    protected function getAttributeCode($attr, &$classes, &$classesCheck)
    {
        $key = trim($attr['name']);

        if ($key === '&attributes') {
            return $this->getAndAttributeCode($attr, $classes, $classesCheck);
        }

        $valueCheck = null;
        $value = trim($attr['value']);

        $value = $this->getAttributeValue($attr['escaped'], $key, $value, $classesCheck, $valueCheck);

        if ($key === 'class') {
            if ($value !== 'false' && $value !== 'null' && $value !== 'undefined') {
                array_push($classes, $value);
            }

            return '';
        }

        return $this->compileAttributeValue($key, $value, $attr, $valueCheck);
    }

    protected function getClassesCode(&$classes, &$classesCheck)
    {
        return trim($this->createCode(
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            '$__classes = implode(" ", ' .
                'array_unique(explode(" ", (empty($__classes) ? "" : $__classes) . ' .
                    var_export(implode(' ', $classes), true) . ' . ' .
                    'implode(" ", array(' . implode(', ', $classesCheck) . ')) ' .
                ')) ' .
            ');'
        ));
    }

    protected function getClassesDisplayCode()
    {
        return trim($this->createCode(
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            'if (!empty($__classes)) { ' .
                '?> ' . (isset($this->options['classAttribute'])
class MyClass { }

$x = new MyClass();
$x->foo = true;
                    ? $this->options['classAttribute']
                    : 'class'
                ) . '=' . $this->quote . '<?php echo $__classes; ?>' . $this->quote . '<?php ' .
            '} ' .
            'unset($__classes); '
        ));
    }

    /**
     * @param array $attributes
     */
    protected function compileAttributes($attributes)
    {
        $items = '';
        $classes = array();
        $classesCheck = array();

        foreach ($attributes as $attr) {
            $items .= $this->getAttributeCode($attr, $classes, $classesCheck);
        }

        $items .= $this->getClassesCode($classes, $classesCheck);

        $this->buffer($items, false);
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
    }
}


Push — master ( 9ad54b...895d73 )

AttributesCompiler B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

13 Methods

How to fix Complexity

Complex Class

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			namespace Jade\Compiler;
4
5			abstract class AttributesCompiler extends CompilerFacade
6			{
7			protected function getAttributeDisplayCode($key, $value, $valueCheck)
8			{
9			if ($key === 'style') {
10			$value = preg_replace('/::get(Escaped\|Unescaped)Value/', '::get$1Style', $value, 1);
11			}
12
13			return is_null($valueCheck)
14			? ' ' . $key . '=' . $this->quote . $value . $this->quote
			0 ignored issues – show Bug introduced 2016-08-26 18:11 UTC by Report Bug Copy Issue Report The property `quote` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
15			: $this->createCode('if (true === ($__value = %1$s)) { ', $valueCheck)
			0 ignored issues – show Bug introduced 2016-08-26 18:11 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Jade\Compiler\AttributesCompiler` as the method `createCode()` does only exist in the following sub-classes of `Jade\Compiler\AttributesCompiler`: `Jade\Compiler`, `Pug\Compiler`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
16			. $this->getBooleanAttributeDisplayCode($key)
17			. $this->createCode('} else if (\\Jade\\Compiler::isDisplayable($__value)) { ')
			0 ignored issues – show Bug introduced 2016-08-26 18:11 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Jade\Compiler\AttributesCompiler` as the method `createCode()` does only exist in the following sub-classes of `Jade\Compiler\AttributesCompiler`: `Jade\Compiler`, `Pug\Compiler`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
18			. ' ' . $key . '=' . $this->quote . $value . $this->quote
19			. $this->createCode('}');
			0 ignored issues – show Bug introduced 2016-08-26 18:11 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `Jade\Compiler\AttributesCompiler` as the method `createCode()` does only exist in the following sub-classes of `Jade\Compiler\AttributesCompiler`: `Jade\Compiler`, `Pug\Compiler`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
20			}
21
22			protected function getBooleanAttributeDisplayCode($key)
23			{
24			return ' ' . $key . ($this->terse
			0 ignored issues – show Bug introduced 2016-08-26 18:11 UTC by Report Bug Copy Issue Report The property `terse` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
25			? ''
26			: '=' . $this->quote . $key . $this->quote
27			);
28			}
29
30			protected function getValueStatement($statements)
31			{
32			return is_string($statements[0])
33			? $statements[0]
34			: $statements[0][0];
35			}

XaBerr / JATE

Push — master ( 9ad54b...895d73 )

AttributesCompiler B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

13 Methods

How to fix Complexity

Complex Class

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like