Inspection of "New organization for applications" - XaBerr/JATE - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Branch — master (a25af9)

by Federico

created 2016-04-15 09:46 UTC

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -1,7 +1,7 @@
 block discarded – undo
 <?php
 	require_once("jate.php");
 	$connection = null;
-	if($jConfig->connection["enable"])
+	if ($jConfig->connection["enable"])
 		$connection = new Connection(
 				$jConfig->connection["server"]
 			, $jConfig->connection["database"]

Please login to merge, or discard this patch.

examples/01essential/index.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -1,6 +1,6 @@
 block discarded – undo
 <?php
 	require_once("main.php");
-	if(!isset($_GET["page"])) $_GET["page"] = "home";
+	if (!isset($_GET["page"])) $_GET["page"] = "home";
 	$webApp->fetchPage($_GET["page"]);
 	$webApp->draw();
 ?>

Please login to merge, or discard this patch.

examples/01essential/status.php 1 patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -22,17 +22,17 @@  discard block
 block discarded – undo
 					$percent;
 					foreach (getGitLog() as $i) {
 						$cont++;
-						if($cont % $nPerCol == 1)
+						if ($cont % $nPerCol == 1)
 							echo '<div class="row">';
-						if(isset($i["tag"])) {
-							$percent = explode(".",$i["tag"]);
+						if (isset($i["tag"])) {
+							$percent = explode(".", $i["tag"]);
 							$percent = 100 * intval($percent[0]) + 10 * intval($percent[1]) + intval($percent[2]);
 						}
 					?>
 						<div class="col-lg-<?=$dim?>">
 							<div class="well well-sm miniblock">
 								<div class="autor"><b>Autor:</b> <?=$i["author"]?><br></div>
-								<div class="tag"><b>Tag:</b> <?php if(isset($i["tag"])) echo $i["tag"]?><br></div>
+								<div class="tag"><b>Tag:</b> <?php if (isset($i["tag"])) echo $i["tag"]?><br></div>
 								<div class="date"><b>Date:</b> <?=$i["date"]?><br></div>
 								<div class="message"><b>Message:</b> <?=$i["message"]?><br></div>
 								<div class="progress">
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
 							</div>
 						</div>
 					<?php
-					if($cont % $nPerCol == 0)
+					if ($cont % $nPerCol == 0)
 						echo '</div>';
 					} ?>
 				</div>

Please login to merge, or discard this patch.

examples/01essential/jate.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -1,5 +1,5 @@  discard block
 block discarded – undo
 <?php
-	if(!isset($GLOBALS["JATEPath"]))
+	if (!isset($GLOBALS["JATEPath"]))
 		$GLOBALS["JATEPath"] = [];
 	$commonLocations = array(
 		"bower_components/JATE/dist/",
@@ -7,7 +7,7 @@  discard block
 block discarded – undo
 		"../../dist/"
 	);
 	foreach ($commonLocations as $i)
-		if(file_exists($i."jate/coreEngine.php")) {
+		if (file_exists($i."jate/coreEngine.php")) {
 			array_push($GLOBALS["JATEPath"], $i);
 			require_once($i."jate/coreEngine.php");
 			break;

Please login to merge, or discard this patch.

examples/05database/pages/Home.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -5,7 +5,7 @@
 block discarded – undo
 			$this->data["content"] = $this->makePage();
 		}
 		public function makePage() {
-			$result = c_query("SELECT name FROM test","Error 01");
+			$result = c_query("SELECT name FROM test", "Error 01");
 			$output = $result[0]["name"];
 			jBlock();
 			?>

Please login to merge, or discard this patch.

examples/05database/main.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -1,7 +1,7 @@
 block discarded – undo
 <?php
 	require_once("jate.php");
 	$connection = null;
-	if($jConfig->connection["enable"])
+	if ($jConfig->connection["enable"])
 		$connection = new Connection(
 				$jConfig->connection["server"]
 			, $jConfig->connection["database"]

Please login to merge, or discard this patch.

examples/05database/index.php 1 patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

@@ -1,6 +1,6 @@
 block discarded – undo
 <?php
 	require_once("main.php");
-	if(!isset($_GET["page"])) $_GET["page"] = "home";
+	if (!isset($_GET["page"])) $_GET["page"] = "home";
 	$webApp->fetchPage($_GET["page"]);
 	$webApp->draw();
 ?>

Please login to merge, or discard this patch.

examples/05database/status.php 1 patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

@@ -22,17 +22,17 @@  discard block
 block discarded – undo
 					$percent;
 					foreach (getGitLog() as $i) {
 						$cont++;
-						if($cont % $nPerCol == 1)
+						if ($cont % $nPerCol == 1)
 							echo '<div class="row">';
-						if(isset($i["tag"])) {
-							$percent = explode(".",$i["tag"]);
+						if (isset($i["tag"])) {
+							$percent = explode(".", $i["tag"]);
 							$percent = 100 * intval($percent[0]) + 10 * intval($percent[1]) + intval($percent[2]);
 						}
 					?>
 						<div class="col-lg-<?=$dim?>">
 							<div class="well well-sm miniblock">
 								<div class="autor"><b>Autor:</b> <?=$i["author"]?><br></div>
-								<div class="tag"><b>Tag:</b> <?php if(isset($i["tag"])) echo $i["tag"]?><br></div>
+								<div class="tag"><b>Tag:</b> <?php if (isset($i["tag"])) echo $i["tag"]?><br></div>
 								<div class="date"><b>Date:</b> <?=$i["date"]?><br></div>
 								<div class="message"><b>Message:</b> <?=$i["message"]?><br></div>
 								<div class="progress">
@@ -44,7 +44,7 @@  discard block
 block discarded – undo
 							</div>
 						</div>
 					<?php
-					if($cont % $nPerCol == 0)
+					if ($cont % $nPerCol == 0)
 						echo '</div>';
 					} ?>
 				</div>

Please login to merge, or discard this patch.

examples/05database/jate.php 1 patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

@@ -1,5 +1,5 @@  discard block
 block discarded – undo
 <?php
-	if(!isset($GLOBALS["JATEPath"]))
+	if (!isset($GLOBALS["JATEPath"]))
 		$GLOBALS["JATEPath"] = [];
 	$commonLocations = array(
 		"bower_components/JATE/dist/",
@@ -7,7 +7,7 @@  discard block
 block discarded – undo
 		"../../dist/"
 	);
 	foreach ($commonLocations as $i)
-		if(file_exists($i."jate/coreEngine.php")) {
+		if (file_exists($i."jate/coreEngine.php")) {
 			array_push($GLOBALS["JATEPath"], $i);
 			require_once($i."jate/coreEngine.php");
 			break;

Please login to merge, or discard this patch.

		@@ -1,7 +1,7 @@
		block discarded – undo
1	1	<?php
2	2	require_once("jate.php");
3	3	$connection = null;
4		- if($jConfig->connection["enable"])
	4	+ if ($jConfig->connection["enable"])
5	5	$connection = new Connection(
6	6	$jConfig->connection["server"]
7	7	, $jConfig->connection["database"]

		@@ -1,6 +1,6 @@
		block discarded – undo
1	1	<?php
2	2	require_once("main.php");
3		- if(!isset($_GET["page"])) $_GET["page"] = "home";
	3	+ if (!isset($_GET["page"])) $_GET["page"] = "home";
4	4	$webApp->fetchPage($_GET["page"]);
5	5	$webApp->draw();
6	6	?>

		@@ -22,17 +22,17 @@ discard block
		block discarded – undo
22	22	$percent;
23	23	foreach (getGitLog() as $i) {
24	24	$cont++;
25		- if($cont % $nPerCol == 1)
	25	+ if ($cont % $nPerCol == 1)
26	26	echo '<div class="row">';
27		- if(isset($i["tag"])) {
28		- $percent = explode(".",$i["tag"]);
	27	+ if (isset($i["tag"])) {
	28	+ $percent = explode(".", $i["tag"]);
29	29	$percent = 100 * intval($percent[0]) + 10 * intval($percent[1]) + intval($percent[2]);
30	30	}
31	31	?>
32	32	<div class="col-lg-<?=$dim?>">
33	33	<div class="well well-sm miniblock">
34	34	<div class="autor"><b>Autor:</b> <?=$i["author"]?><br></div>
35		- <div class="tag"><b>Tag:</b> <?php if(isset($i["tag"])) echo $i["tag"]?><br></div>
	35	+ <div class="tag"><b>Tag:</b> <?php if (isset($i["tag"])) echo $i["tag"]?><br></div>
36	36	<div class="date"><b>Date:</b> <?=$i["date"]?><br></div>
37	37	<div class="message"><b>Message:</b> <?=$i["message"]?><br></div>
38	38	<div class="progress">
		@@ -44,7 +44,7 @@ discard block
		block discarded – undo
44	44	</div>
45	45	</div>
46	46	<?php
47		- if($cont % $nPerCol == 0)
	47	+ if ($cont % $nPerCol == 0)
48	48	echo '</div>';
49	49	} ?>
50	50	</div>

		@@ -1,5 +1,5 @@ discard block
		block discarded – undo
1	1	<?php
2		- if(!isset($GLOBALS["JATEPath"]))
	2	+ if (!isset($GLOBALS["JATEPath"]))
3	3	$GLOBALS["JATEPath"] = [];
4	4	$commonLocations = array(
5	5	"bower_components/JATE/dist/",
		@@ -7,7 +7,7 @@ discard block
		block discarded – undo
7	7	"../../dist/"
8	8	);
9	9	foreach ($commonLocations as $i)
10		- if(file_exists($i."jate/coreEngine.php")) {
	10	+ if (file_exists($i."jate/coreEngine.php")) {
11	11	array_push($GLOBALS["JATEPath"], $i);
12	12	require_once($i."jate/coreEngine.php");
13	13	break;

		@@ -5,7 +5,7 @@
		block discarded – undo
5	5	$this->data["content"] = $this->makePage();
6	6	}
7	7	public function makePage() {
8		- $result = c_query("SELECT name FROM test","Error 01");
	8	+ $result = c_query("SELECT name FROM test", "Error 01");
9	9	$output = $result[0]["name"];
10	10	jBlock();
11	11	?>

XaBerr / JATE

Branch — master (a25af9)

Category

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +1 added lines, -1 removed lines patch added patch discarded remove patch

Spacing +5 added lines, -5 removed lines patch added patch discarded remove patch

Spacing +2 added lines, -2 removed lines patch added patch discarded remove patch