View GitHub Repository JATE

Schedule Inspection
Subscribe
Completed
Push — master ( 1480bb...23bea2 )
by Federico
03:32
created

Page01   A

↳ Parent: Project

Complexity

Total Complexity 2

Size/Duplication

Total Lines 21
Duplicated Lines 100 %

Coupling/Cohesion

Components 0
Dependencies 1

Importance

Changes 2
Bugs 0 Features 0
Metric Value
c 2
b 0
f 0
dl 21
loc 21
rs 10
wmc 2
lcom 0
cbo 1

2 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 5 5 1
A makePage() 14 14 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1 
<?php
2 View Code Duplication 
	class Page01 extends Template {
0 ignored issues
– show
Duplication introduced by
This class seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
Coding Style Compatibility introduced by
PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

You can fix this by adding a namespace to your class:

namespace YourVendor;

class YourClass { }

When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.

Loading history...
3 
		public function __construct() {
4 
			parent::__construct();
5 
			$this->tags["title"]		= "JATE - Page01";
0 ignored issues
– show
Bug introduced by
The property tags does not exist. Did you maybe forget to declare it?

In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code:

class MyClass { }

$x = new MyClass();
$x->foo = true;

Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion:

class MyClass {
    public $foo;
}

$x = new MyClass();
$x->foo = true;
Loading history...
6 
			$this->tags["content"] = $this->makePage();
7 
		}
8 
		public function makePage() {
9 
			jBlock();
10 
			?>
11 
			<div class="row" style="margin-top:70px;">
12 
				<div class="col-lg-12">
13 
					<div class="well well-sm">
14 
						Page 1!
15 
					</div>
16 
				</div>
17 
			</div>
18 
			<?php
19 
			$temp = jBlockClose();
20 
			return $temp;
21 
		}
22 
	}
23 
?>
24