Inspection of "Grouped the global configuration" - XaBerr/JATE - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7f2391...b0dbdc )

by Federico

created 2016-06-30 13:50 UTC

Status

Braces +6 added lines, -4 removed lines patch added patch discarded remove patch

@@ -1,14 +1,16 @@
 block discarded – undo
 <?php
-	if(!isset($GLOBALS["JATEPath"]))
-		$GLOBALS["JATEPath"] = [];
+	if(!isset($GLOBALS["JATEPath"])) {
+			$GLOBALS["JATEPath"] = [];
+	}
 	$commonLocations = array(
 		"bower_components/JATE/dist/",
 		"vendor/xaberr/jate/dist/",
 		"../../dist/"
 	);
-	foreach ($commonLocations as $i)
-		if(file_exists($i."jate/coreEngine.php")) {
+	foreach ($commonLocations as $i) {
+			if(file_exists($i."jate/coreEngine.php")) {
 			array_push($GLOBALS["JATEPath"], $i);
+	}
 			require_once($i."jate/coreEngine.php");
 			break;
 		}

Please login to merge, or discard this patch.

dist/jate/functions/folder.php 1 patch

Braces +9 added lines, -6 removed lines patch added patch discarded remove patch

@@ -21,10 +21,11 @@  discard block
 block discarded – undo
 		$temp = [];
 		if (is_dir($_dir)) {
 				if ($dirOpened = opendir($_dir)) {
-						while (($file = readdir($dirOpened)) !== false)
-								if( ($file !='.')&&($file !='..') )
+						while (($file = readdir($dirOpened)) !== false) {
+														if( ($file !='.')&&($file !='..') )
 									if($_function($file))
 										array_push($temp,$file);
+						}
 						closedir($dirOpened);
 				}
 		}
@@ -32,14 +33,16 @@  discard block
 block discarded – undo
 	}
 	function require_subfolder( $_dir = "./" ) {
 		$temp = subFolder_file($_dir);
-		foreach ($temp as $i)
-			jRequire($_dir."/".$i);
+		foreach ($temp as $i) {
+					jRequire($_dir."/".$i);
+		}
 	}
 	function require_js( $_dir = "./" ) {
 		$tempArray = [];
 		$temp = subFolder_file($_dir);
-		foreach ($temp as $i)
-			array_push($tempArray, $_dir."/".$i);
+		foreach ($temp as $i) {
+					array_push($tempArray, $_dir."/".$i);
+		}
 		return $tempArray;
 	}
 ?>

Please login to merge, or discard this patch.

dist/jate/functions/block.php 1 patch

Braces +3 added lines, -2 removed lines patch added patch discarded remove patch

@@ -15,8 +15,9 @@
 block discarded – undo
 	function minify_output($_buffer) {
 		$search = array ( '/\>[^\S ]+/s', '/[^\S ]+\</s', '/(\s)+/s' );
 		$replace = array ( '>', '<', '\\1' );
-		if (preg_match("/\<html/i",$_buffer) == 1 && preg_match("/\<\/html\>/i",$_buffer) == 1)
-			$_buffer = preg_replace($search, $replace, utf8_decode($_buffer));
+		if (preg_match("/\<html/i",$_buffer) == 1 && preg_match("/\<\/html\>/i",$_buffer) == 1) {
+					$_buffer = preg_replace($search, $replace, utf8_decode($_buffer));
+		}
 		return utf8_encode($_buffer);
 	}
 ?>

Please login to merge, or discard this patch.

dist/jate/modules/Connection/Connection.php 1 patch

Braces +3 added lines, -2 removed lines patch added patch discarded remove patch

@@ -7,8 +7,9 @@
 block discarded – undo
 			parent::__construct();
 			$args = func_get_args();
 			$count = func_num_args();
-			if (method_exists($this,$func='__construct'.$count))
-				call_user_func_array(array($this,$func),$args);
+			if (method_exists($this,$func='__construct'.$count)) {
+							call_user_func_array(array($this,$func),$args);
+			}
 		}
 		public function __construct0() {
 			$this->connection = null;

Please login to merge, or discard this patch.

dist/status.php 1 patch

Braces +6 added lines, -3 removed lines patch added patch discarded remove patch

@@ -22,8 +22,9 @@  discard block
 block discarded – undo
 					$percent;
 					foreach (getGitLog() as $i) {
 						$cont++;
-						if($cont % $nPerCol == 1)
-							echo '<div class="row">';
+						if($cont % $nPerCol == 1) {
+													echo '<div class="row">';
+						}
 						if(isset($i["tag"])) {
 							$percent = explode(".",$i["tag"]);
 							$percent = 100 * intval($percent[0]) + 10 * intval($percent[1]) + intval($percent[2]);
@@ -32,7 +33,8 @@  discard block
 block discarded – undo
 						<div class="col-lg-<?=$dim?>">
 							<div class="well well-sm miniblock">
 								<div class="autor"><b>Autor:</b> <?=$i["author"]?><br></div>
-								<div class="tag"><b>Tag:</b> <?php if(isset($i["tag"])) echo $i["tag"]?><br></div>
+								<div class="tag"><b>Tag:</b> <?php if(isset($i["tag"])) {
+	echo $i["tag"]?><br></div>
 								<div class="date"><b>Date:</b> <?=$i["date"]?><br></div>
 								<div class="message"><b>Message:</b> <?=$i["message"]?><br></div>
 								<div class="progress">
@@ -46,6 +48,7 @@  discard block
 block discarded – undo
 					<?php
 					if($cont % $nPerCol == 0)
 						echo '</div>';
+}
 					} ?>
 				</div>
 			</div>

Please login to merge, or discard this patch.

dist/jate.php 1 patch

Braces +6 added lines, -4 removed lines patch added patch discarded remove patch

@@ -1,14 +1,16 @@
 block discarded – undo
 <?php
-	if(isset($GLOBALS["JATEPath"]))
-		$GLOBALS["JATEPath"] = [];
+	if(isset($GLOBALS["JATEPath"])) {
+			$GLOBALS["JATEPath"] = [];
+	}
 	$commonLocations = array(
 		"bower_components/JATE/dist/",
 		"vendor/xaberr/jate/dist/",
 		"../../dist/"
 	);
-	foreach ($commonLocations as $i)
-		if(file_exists($i."jate/coreEngine.php")) {
+	foreach ($commonLocations as $i) {
+			if(file_exists($i."jate/coreEngine.php")) {
 			array_push($GLOBALS["JATEPath"], $i);
+	}
 			require_once($i."jate/coreEngine.php");
 			break;
 		}

Please login to merge, or discard this patch.

examples/01essential/jate.php 1 patch

Braces +6 added lines, -4 removed lines patch added patch discarded remove patch

@@ -1,14 +1,16 @@
 block discarded – undo
 <?php
-	if(!isset($GLOBALS["JATEPath"]))
-		$GLOBALS["JATEPath"] = [];
+	if(!isset($GLOBALS["JATEPath"])) {
+			$GLOBALS["JATEPath"] = [];
+	}
 	$commonLocations = array(
 		"bower_components/JATE/dist/",
 		"vendor/xaberr/jate/dist/",
 		"../../dist/"
 	);
-	foreach ($commonLocations as $i)
-		if(file_exists($i."jate/coreEngine.php")) {
+	foreach ($commonLocations as $i) {
+			if(file_exists($i."jate/coreEngine.php")) {
 			array_push($GLOBALS["JATEPath"], $i);
+	}
 			require_once($i."jate/coreEngine.php");
 			break;
 		}

Please login to merge, or discard this patch.

examples/01essential/status.php 1 patch

Braces +6 added lines, -3 removed lines patch added patch discarded remove patch

@@ -22,8 +22,9 @@  discard block
 block discarded – undo
 					$percent;
 					foreach (getGitLog() as $i) {
 						$cont++;
-						if($cont % $nPerCol == 1)
-							echo '<div class="row">';
+						if($cont % $nPerCol == 1) {
+													echo '<div class="row">';
+						}
 						if(isset($i["tag"])) {
 							$percent = explode(".",$i["tag"]);
 							$percent = 100 * intval($percent[0]) + 10 * intval($percent[1]) + intval($percent[2]);
@@ -32,7 +33,8 @@  discard block
 block discarded – undo
 						<div class="col-lg-<?=$dim?>">
 							<div class="well well-sm miniblock">
 								<div class="autor"><b>Autor:</b> <?=$i["author"]?><br></div>
-								<div class="tag"><b>Tag:</b> <?php if(isset($i["tag"])) echo $i["tag"]?><br></div>
+								<div class="tag"><b>Tag:</b> <?php if(isset($i["tag"])) {
+	echo $i["tag"]?><br></div>
 								<div class="date"><b>Date:</b> <?=$i["date"]?><br></div>
 								<div class="message"><b>Message:</b> <?=$i["message"]?><br></div>
 								<div class="progress">
@@ -46,6 +48,7 @@  discard block
 block discarded – undo
 					<?php
 					if($cont % $nPerCol == 0)
 						echo '</div>';
+}
 					} ?>
 				</div>
 			</div>

Please login to merge, or discard this patch.

examples/05database/status.php 1 patch

Braces +6 added lines, -3 removed lines patch added patch discarded remove patch

@@ -22,8 +22,9 @@  discard block
 block discarded – undo
 					$percent;
 					foreach (getGitLog() as $i) {
 						$cont++;
-						if($cont % $nPerCol == 1)
-							echo '<div class="row">';
+						if($cont % $nPerCol == 1) {
+													echo '<div class="row">';
+						}
 						if(isset($i["tag"])) {
 							$percent = explode(".",$i["tag"]);
 							$percent = 100 * intval($percent[0]) + 10 * intval($percent[1]) + intval($percent[2]);
@@ -32,7 +33,8 @@  discard block
 block discarded – undo
 						<div class="col-lg-<?=$dim?>">
 							<div class="well well-sm miniblock">
 								<div class="autor"><b>Autor:</b> <?=$i["author"]?><br></div>
-								<div class="tag"><b>Tag:</b> <?php if(isset($i["tag"])) echo $i["tag"]?><br></div>
+								<div class="tag"><b>Tag:</b> <?php if(isset($i["tag"])) {
+	echo $i["tag"]?><br></div>
 								<div class="date"><b>Date:</b> <?=$i["date"]?><br></div>
 								<div class="message"><b>Message:</b> <?=$i["message"]?><br></div>
 								<div class="progress">
@@ -46,6 +48,7 @@  discard block
 block discarded – undo
 					<?php
 					if($cont % $nPerCol == 0)
 						echo '</div>';
+}
 					} ?>
 				</div>
 			</div>

Please login to merge, or discard this patch.

		@@ -1,14 +1,16 @@
		block discarded – undo
1	1	<?php
2		- if(!isset($GLOBALS["JATEPath"]))
3		- $GLOBALS["JATEPath"] = [];
	2	+ if(!isset($GLOBALS["JATEPath"])) {
	3	+ $GLOBALS["JATEPath"] = [];
	4	+ }
4	5	$commonLocations = array(
5	6	"bower_components/JATE/dist/",
6	7	"vendor/xaberr/jate/dist/",
7	8	"../../dist/"
8	9	);
9		- foreach ($commonLocations as $i)
10		- if(file_exists($i."jate/coreEngine.php")) {
	10	+ foreach ($commonLocations as $i) {
	11	+ if(file_exists($i."jate/coreEngine.php")) {
11	12	array_push($GLOBALS["JATEPath"], $i);
	13	+ }
12	14	require_once($i."jate/coreEngine.php");
13	15	break;
14	16	}

		@@ -21,10 +21,11 @@ discard block
		block discarded – undo
21	21	$temp = [];
22	22	if (is_dir($_dir)) {
23	23	if ($dirOpened = opendir($_dir)) {
24		- while (($file = readdir($dirOpened)) !== false)
25		- if( ($file !='.')&&($file !='..') )
	24	+ while (($file = readdir($dirOpened)) !== false) {
	25	+ if( ($file !='.')&&($file !='..') )
26	26	if($_function($file))
27	27	array_push($temp,$file);
	28	+ }
28	29	closedir($dirOpened);
29	30	}
30	31	}
		@@ -32,14 +33,16 @@ discard block
		block discarded – undo
32	33	}
33	34	function require_subfolder( $_dir = "./" ) {
34	35	$temp = subFolder_file($_dir);
35		- foreach ($temp as $i)
36		- jRequire($_dir."/".$i);
	36	+ foreach ($temp as $i) {
	37	+ jRequire($_dir."/".$i);
	38	+ }
37	39	}
38	40	function require_js( $_dir = "./" ) {
39	41	$tempArray = [];
40	42	$temp = subFolder_file($_dir);
41		- foreach ($temp as $i)
42		- array_push($tempArray, $_dir."/".$i);
	43	+ foreach ($temp as $i) {
	44	+ array_push($tempArray, $_dir."/".$i);
	45	+ }
43	46	return $tempArray;
44	47	}
45	48	?>

		@@ -15,8 +15,9 @@
		block discarded – undo
15	15	function minify_output($_buffer) {
16	16	$search = array ( '/\>[^\S ]+/s', '/[^\S ]+\</s', '/(\s)+/s' );
17	17	$replace = array ( '>', '<', '\\1' );
18		- if (preg_match("/\<html/i",$_buffer) == 1 && preg_match("/\<\/html\>/i",$_buffer) == 1)
19		- $_buffer = preg_replace($search, $replace, utf8_decode($_buffer));
	18	+ if (preg_match("/\<html/i",$_buffer) == 1 && preg_match("/\<\/html\>/i",$_buffer) == 1) {
	19	+ $_buffer = preg_replace($search, $replace, utf8_decode($_buffer));
	20	+ }
20	21	return utf8_encode($_buffer);
21	22	}
22	23	?>

		@@ -7,8 +7,9 @@
		block discarded – undo
7	7	parent::__construct();
8	8	$args = func_get_args();
9	9	$count = func_num_args();
10		- if (method_exists($this,$func='__construct'.$count))
11		- call_user_func_array(array($this,$func),$args);
	10	+ if (method_exists($this,$func='__construct'.$count)) {
	11	+ call_user_func_array(array($this,$func),$args);
	12	+ }
12	13	}
13	14	public function __construct0() {
14	15	$this->connection = null;

		@@ -22,8 +22,9 @@ discard block
		block discarded – undo
22	22	$percent;
23	23	foreach (getGitLog() as $i) {
24	24	$cont++;
25		- if($cont % $nPerCol == 1)
26		- echo '<div class="row">';
	25	+ if($cont % $nPerCol == 1) {
	26	+ echo '<div class="row">';
	27	+ }
27	28	if(isset($i["tag"])) {
28	29	$percent = explode(".",$i["tag"]);
29	30	$percent = 100 * intval($percent[0]) + 10 * intval($percent[1]) + intval($percent[2]);
		@@ -32,7 +33,8 @@ discard block
		block discarded – undo
32	33	<div class="col-lg-<?=$dim?>">
33	34	<div class="well well-sm miniblock">
34	35	<div class="autor"><b>Autor:</b> <?=$i["author"]?><br></div>
35		- <div class="tag"><b>Tag:</b> <?php if(isset($i["tag"])) echo $i["tag"]?><br></div>
	36	+ <div class="tag"><b>Tag:</b> <?php if(isset($i["tag"])) {
	37	+ echo $i["tag"]?><br></div>
36	38	<div class="date"><b>Date:</b> <?=$i["date"]?><br></div>
37	39	<div class="message"><b>Message:</b> <?=$i["message"]?><br></div>
38	40	<div class="progress">
		@@ -46,6 +48,7 @@ discard block
		block discarded – undo
46	48	<?php
47	49	if($cont % $nPerCol == 0)
48	50	echo '</div>';
	51	+}
49	52	} ?>
50	53	</div>
51	54	</div>

XaBerr / JATE

Push — master ( 7f2391...b0dbdc )

Status

Category

Braces +6 added lines, -4 removed lines patch added patch discarded remove patch

Braces +9 added lines, -6 removed lines patch added patch discarded remove patch

Braces +3 added lines, -2 removed lines patch added patch discarded remove patch

Braces +3 added lines, -2 removed lines patch added patch discarded remove patch

Braces +6 added lines, -3 removed lines patch added patch discarded remove patch

Braces +6 added lines, -4 removed lines patch added patch discarded remove patch

Braces +6 added lines, -4 removed lines patch added patch discarded remove patch

Braces +6 added lines, -3 removed lines patch added patch discarded remove patch

Braces +6 added lines, -3 removed lines patch added patch discarded remove patch