View GitHub Repository JATE

Schedule Inspection
Subscribe
Test Failed
Push — master ( ae6d9a...f6b071 )
by Federico
02:22
created

Module::addConnectionMan()   A

↳ Parent: Module

Complexity

Conditions 4
Paths 7

Size

Total Lines 10

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
cc 4
nc 7
nop 2
dl 0
loc 10
rs 9.9332
c 0
b 0
f 0
1 
<?php
0 ignored issues
– show
Coding Style Compatibility introduced by
For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 4 and the first side effect is on line 2.

The PSR-1: Basic Coding Standard recommends that a file should either introduce new symbols, that is classes, functions, constants or similar, or have side effects. Side effects are anything that executes logic, like for example printing output, changing ini settings or writing to a file.

The idea behind this recommendation is that merely auto-loading a class should not change the state of an application. It also promotes a cleaner style of programming and makes your code less prone to errors, because the logic is not spread out all over the place.

To learn more about the PSR-1, please see the PHP-FIG site on the PSR-1.

Loading history...
2 
  jRequire("../Query/Query.php");
3 
  jRequire("../File/File.php");
4 
  class Module {
0 ignored issues
– show
Coding Style Compatibility introduced by
PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

You can fix this by adding a namespace to your class:

namespace YourVendor;

class YourClass { }

When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.

Loading history...
5 
    use Query {
6 
      Query::__construct as private __queryConstruct;
7 
    }
8 
    use File {
9 
      File::__construct as private __fileConstruct;
10 
    }
11 
    public $name;
12 
    public $modules;
13 
    public function __construct() {
14 
      $this->name    = get_class($this);
15 
      $this->modules = [];
16 
      $this->__queryConstruct();
17 
      $this->__fileConstruct();
18 
    }
19 
    public function addModules( $_modules ) {
20 
      if(!is_array($_modules))
21 
        throw new JException("Parameter must be an array.");
22 
      foreach ($_modules as $value)
23 
        $this->addModule($value);
24 
    }
25 
    public function addModule( $_module ) {
26 
      if(!is_object($_module))
27 
        throw new JException("Parameter must be a object.");
28 
      if(! is_subclass_of ($_module, "Module"))
29 
        throw new JException("Parameter must be a object inherited from Module object.");
30 
      $this->modules[$_module->name] = $_module;
31 
      if($this->currentConnection)
32 
        $this->modules[$_module->name]->addConnectionMan($this->currentConnection);
33 
    }
34 
    public function addConnectionMan( $_connection, $_name = "default") {
35 
      try {
36 
        parent::addConnectionMan($_connection, $_name);
37 
        foreach ($this->modules as &$module)
38 
          if(isset($this->currentConnection))
39 
            $module->addConnectionMan($this->currentConnection, $_name);
40 
      } catch (Exception $e) {
41 
        throw new JException($e->getMessage(), 1);
42 
      }
43 
    }
44 
  }
45 
?>
0 ignored issues
– show
Best Practice introduced by
It is not recommended to use PHP's closing tag ?> in files other than templates.

Using a closing tag in PHP files that only contain PHP code is not recommended as you might accidentally add whitespace after the closing tag which would then be output by PHP. This can cause severe problems, for example headers cannot be sent anymore.

A simple precaution is to leave off the closing tag as it is not required, and it also has no negative effects whatsoever.

Loading history...
46